All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: bmt@zurich.ibm.com
Cc: linux-rdma@vger.kernel.org
Subject: [bug report] RDMA/siw: Fix SQ/RQ drain logic
Date: Thu, 24 Oct 2019 23:38:41 +0300	[thread overview]
Message-ID: <20191024203841.GA7912@mwanda> (raw)

Hello Bernard Metzler,

The patch cf049bb31f71: "RDMA/siw: Fix SQ/RQ drain logic" from Oct 4,
2019, leads to the following static checker warning:

	drivers/infiniband/sw/siw/siw_verbs.c:1079 siw_post_receive()
	error: locking inconsistency.  We assume 'read_sem:&qp->state_lock' is both locked and unlocked at the start.

drivers/infiniband/sw/siw/siw_verbs.c
   978  int siw_post_receive(struct ib_qp *base_qp, const struct ib_recv_wr *wr,
   979                       const struct ib_recv_wr **bad_wr)
   980  {
   981          struct siw_qp *qp = to_siw_qp(base_qp);
   982          unsigned long flags;
   983          int rv = 0;
   984  
   985          if (qp->srq) {
   986                  *bad_wr = wr;
   987                  return -EOPNOTSUPP; /* what else from errno.h? */
   988          }
   989          if (!qp->kernel_verbs) {
   990                  siw_dbg_qp(qp, "no kernel post_recv for user mapped sq\n");
   991                  up_read(&qp->state_lock);
                        ^^^^^^^^^^^^^^^^^^^^^^^^
The patch changes the locking so this isn't held here and should be
released.  Should it be held, though?

   992                  *bad_wr = wr;
   993                  return -EINVAL;
   994          }
   995  
   996          /*
   997           * Try to acquire QP state lock. Must be non-blocking
   998           * to accommodate kernel clients needs.
   999           */
  1000          if (!down_read_trylock(&qp->state_lock)) {
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  1001                  if (qp->attrs.state == SIW_QP_STATE_ERROR) {
  1002                          /*
  1003                           * ERROR state is final, so we can be sure
  1004                           * this state will not change as long as the QP
  1005                           * exists.
  1006                           *
  1007                           * This handles an ib_drain_rq() call with
  1008                           * a concurrent request to set the QP state
  1009                           * to ERROR.
  1010                           */
  1011                          rv = siw_rq_flush_wr(qp, wr, bad_wr);
  1012                  } else {

regards,
dan carpenter

             reply	other threads:[~2019-10-24 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 20:38 Dan Carpenter [this message]
2019-10-25  8:16 ` [bug report] RDMA/siw: Fix SQ/RQ drain logic Bernard Metzler
2019-10-25 12:34   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024203841.GA7912@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=bmt@zurich.ibm.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.