diff for duplicates of <20191024204826.GE28043@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 5cff775..d5278a8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -16,7 +16,7 @@ Ya, tracked is better. Waffled between updated and tracked, chose poorly :-) > > struct kvm_memory_slot *mslots = slots->memslots; > > int i; > > -> > if (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) || +> > if (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) || > > WARN_ON_ONCE(!slots->used_slots)) > > return -1; > > @@ -24,7 +24,7 @@ Ya, tracked is better. Waffled between updated and tracked, chose poorly :-) > > if (memslot->base_gfn > mslots[i + 1].base_gfn) > > break; > > -> > WARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn); +> > WARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn); > > > > /* Shift the next memslot forward one and update its index. */ > > mslots[i] = mslots[i + 1]; @@ -59,4 +59,8 @@ That wouldn't work with the binary search though. > The code itself is fine, thanks for the work on documenting it. > > Paolo -> +> +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N1/content_digest index 69ad14b..e6984d1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,29 +9,25 @@ "ref\05320341c-1abb-610b-8f5e-090a6726a9b1@redhat.com\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0" - "Date\0Thu, 24 Oct 2019 20:48:26 +0000\0" + "Date\0Thu, 24 Oct 2019 13:48:26 -0700\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0James Hogan <jhogan@kernel.org>" - Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> - Janosch Frank <frankja@linux.ibm.com> - " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <maz@kernel.org> - David Hildenbrand <david@redhat.com> - Cornelia Huck <cohuck@redhat.com> - Vitaly Kuznetsov <vkuznets@redhat.com> + "Cc\0Cornelia Huck <cohuck@redhat.com>" Wanpeng Li <wanpengli@tencent.com> - Jim Mattson <jmattson@google.com> + Janosch Frank <frankja@linux.ibm.com> + kvm@vger.kernel.org + James Hogan <jhogan@kernel.org> Joerg Roedel <joro@8bytes.org> - James Morse <james.morse@arm.com> - Julien Thierry <julien.thierry.kdev@gmail.com> - Suzuki K Poulose <suzuki.poulose@arm.com> + David Hildenbrand <david@redhat.com> linux-mips@vger.kernel.org kvm-ppc@vger.kernel.org - kvm@vger.kernel.org + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Christian Borntraeger <borntraeger@de.ibm.com> linux-arm-kernel@lists.infradead.org + Marc Zyngier <maz@kernel.org> + Vitaly Kuznetsov <vkuznets@redhat.com> kvmarm@lists.cs.columbia.edu - " linux-kernel@vger.kernel.org\0" + " Jim Mattson <jmattson@google.com>\0" "\00:1\0" "b\0" "On Thu, Oct 24, 2019 at 10:24:09PM +0200, Paolo Bonzini wrote:\n" @@ -52,7 +48,7 @@ "> > \tstruct kvm_memory_slot *mslots = slots->memslots;\n" "> > \tint i;\n" "> > \n" - "> > \tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||\n" + "> > \tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||\n" "> > \t WARN_ON_ONCE(!slots->used_slots))\n" "> > \t\treturn -1;\n" "> > \n" @@ -60,7 +56,7 @@ "> > \t\tif (memslot->base_gfn > mslots[i + 1].base_gfn)\n" "> > \t\t\tbreak;\n" "> > \n" - "> > \t\tWARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);\n" + "> > \t\tWARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);\n" "> > \n" "> > \t\t/* Shift the next memslot forward one and update its index. */\n" "> > \t\tmslots[i] = mslots[i + 1];\n" @@ -95,6 +91,10 @@ "> The code itself is fine, thanks for the work on documenting it.\n" "> \n" "> Paolo\n" - > + "> \n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -c167e403470ba715f63a6882cf0169a74dcabb0bd19ed3f4e632fa5caa5209ac +d6e3d0b5c105d217a0d8547a3ac4c52bc418447d4f76c7408cfbd2eb6556e5e7
diff --git a/a/1.txt b/N2/1.txt index 5cff775..2e7c544 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -16,7 +16,7 @@ Ya, tracked is better. Waffled between updated and tracked, chose poorly :-) > > struct kvm_memory_slot *mslots = slots->memslots; > > int i; > > -> > if (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) || +> > if (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) || > > WARN_ON_ONCE(!slots->used_slots)) > > return -1; > > @@ -24,7 +24,7 @@ Ya, tracked is better. Waffled between updated and tracked, chose poorly :-) > > if (memslot->base_gfn > mslots[i + 1].base_gfn) > > break; > > -> > WARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn); +> > WARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn); > > > > /* Shift the next memslot forward one and update its index. */ > > mslots[i] = mslots[i + 1]; diff --git a/a/content_digest b/N2/content_digest index 69ad14b..459b7df 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -9,7 +9,7 @@ "ref\05320341c-1abb-610b-8f5e-090a6726a9b1@redhat.com\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0" - "Date\0Thu, 24 Oct 2019 20:48:26 +0000\0" + "Date\0Thu, 24 Oct 2019 13:48:26 -0700\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" "Cc\0James Hogan <jhogan@kernel.org>" Paul Mackerras <paulus@ozlabs.org> @@ -52,7 +52,7 @@ "> > \tstruct kvm_memory_slot *mslots = slots->memslots;\n" "> > \tint i;\n" "> > \n" - "> > \tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||\n" + "> > \tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||\n" "> > \t WARN_ON_ONCE(!slots->used_slots))\n" "> > \t\treturn -1;\n" "> > \n" @@ -60,7 +60,7 @@ "> > \t\tif (memslot->base_gfn > mslots[i + 1].base_gfn)\n" "> > \t\t\tbreak;\n" "> > \n" - "> > \t\tWARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);\n" + "> > \t\tWARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);\n" "> > \n" "> > \t\t/* Shift the next memslot forward one and update its index. */\n" "> > \t\tmslots[i] = mslots[i + 1];\n" @@ -97,4 +97,4 @@ "> Paolo\n" > -c167e403470ba715f63a6882cf0169a74dcabb0bd19ed3f4e632fa5caa5209ac +646316a485603c1e03b4fdb91b478358ddfc01307a9add0bd202f8f3a333e8cf
diff --git a/a/1.txt b/N3/1.txt index 5cff775..15fcdc6 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -16,7 +16,7 @@ Ya, tracked is better. Waffled between updated and tracked, chose poorly :-) > > struct kvm_memory_slot *mslots = slots->memslots; > > int i; > > -> > if (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) || +> > if (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) || > > WARN_ON_ONCE(!slots->used_slots)) > > return -1; > > @@ -24,7 +24,7 @@ Ya, tracked is better. Waffled between updated and tracked, chose poorly :-) > > if (memslot->base_gfn > mslots[i + 1].base_gfn) > > break; > > -> > WARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn); +> > WARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn); > > > > /* Shift the next memslot forward one and update its index. */ > > mslots[i] = mslots[i + 1]; @@ -59,4 +59,9 @@ That wouldn't work with the binary search though. > The code itself is fine, thanks for the work on documenting it. > > Paolo -> +> + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index 69ad14b..7c3c37a 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -9,29 +9,29 @@ "ref\05320341c-1abb-610b-8f5e-090a6726a9b1@redhat.com\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0" - "Date\0Thu, 24 Oct 2019 20:48:26 +0000\0" + "Date\0Thu, 24 Oct 2019 13:48:26 -0700\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0James Hogan <jhogan@kernel.org>" - Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> + "Cc\0Cornelia Huck <cohuck@redhat.com>" + Wanpeng Li <wanpengli@tencent.com> Janosch Frank <frankja@linux.ibm.com> + kvm@vger.kernel.org " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <maz@kernel.org> - David Hildenbrand <david@redhat.com> - Cornelia Huck <cohuck@redhat.com> - Vitaly Kuznetsov <vkuznets@redhat.com> - Wanpeng Li <wanpengli@tencent.com> - Jim Mattson <jmattson@google.com> + James Hogan <jhogan@kernel.org> Joerg Roedel <joro@8bytes.org> - James Morse <james.morse@arm.com> - Julien Thierry <julien.thierry.kdev@gmail.com> - Suzuki K Poulose <suzuki.poulose@arm.com> + David Hildenbrand <david@redhat.com> linux-mips@vger.kernel.org kvm-ppc@vger.kernel.org - kvm@vger.kernel.org + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Christian Borntraeger <borntraeger@de.ibm.com> + James Morse <james.morse@arm.com> linux-arm-kernel@lists.infradead.org + Marc Zyngier <maz@kernel.org> + Vitaly Kuznetsov <vkuznets@redhat.com> + Suzuki K Poulose <suzuki.poulose@arm.com> kvmarm@lists.cs.columbia.edu - " linux-kernel@vger.kernel.org\0" + Julien Thierry <julien.thierry.kdev@gmail.com> + " Jim Mattson <jmattson@google.com>\0" "\00:1\0" "b\0" "On Thu, Oct 24, 2019 at 10:24:09PM +0200, Paolo Bonzini wrote:\n" @@ -52,7 +52,7 @@ "> > \tstruct kvm_memory_slot *mslots = slots->memslots;\n" "> > \tint i;\n" "> > \n" - "> > \tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||\n" + "> > \tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||\n" "> > \t WARN_ON_ONCE(!slots->used_slots))\n" "> > \t\treturn -1;\n" "> > \n" @@ -60,7 +60,7 @@ "> > \t\tif (memslot->base_gfn > mslots[i + 1].base_gfn)\n" "> > \t\t\tbreak;\n" "> > \n" - "> > \t\tWARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);\n" + "> > \t\tWARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);\n" "> > \n" "> > \t\t/* Shift the next memslot forward one and update its index. */\n" "> > \t\tmslots[i] = mslots[i + 1];\n" @@ -95,6 +95,11 @@ "> The code itself is fine, thanks for the work on documenting it.\n" "> \n" "> Paolo\n" - > + "> \n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -c167e403470ba715f63a6882cf0169a74dcabb0bd19ed3f4e632fa5caa5209ac +1343350eedc7be7bab785cf2cb66491d884d132ec02d2df84b929cd5db0b9bd5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.