Re: [PATCH v2 1/2] staging: kpc2000: kpc_i2c: Fix lines over 80 chars

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Oct 24, 2019 at 01:35:19PM -0700, Jamal Shareef wrote:
> Fix lines over 80 characters warnings.
> issue found by checkpatch.
> 
> Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
> ---
>  drivers/staging/kpc2000/kpc2000_i2c.c | 203 ++++++++++++++++++--------
>  1 file changed, 139 insertions(+), 64 deletions(-)
> 
> diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
> index bc02534d8dc3..69128fd7fd5e 100644
> --- a/drivers/staging/kpc2000/kpc2000_i2c.c
> +++ b/drivers/staging/kpc2000/kpc2000_i2c.c
> @@ -99,7 +99,8 @@ struct i2c_device {
>  #define SMBHSTSTS_INTR          0x02
>  #define SMBHSTSTS_HOST_BUSY     0x01
>  
> -#define STATUS_FLAGS        (SMBHSTSTS_BYTE_DONE | SMBHSTSTS_FAILED | SMBHSTSTS_BUS_ERR | SMBHSTSTS_DEV_ERR | SMBHSTSTS_INTR)
> +#define STATUS_FLAGS        (SMBHSTSTS_BYTE_DONE | SMBHSTSTS_FAILED | \

Shouldn't you use a tab in this line?

> +		SMBHSTSTS_BUS_ERR | SMBHSTSTS_DEV_ERR | SMBHSTSTS_INTR)

That does not line up very well, it looks worse now :(


>  
>  /* Older devices have their ID defined in <linux/pci_ids.h> */
>  #define PCI_DEVICE_ID_INTEL_COUGARPOINT_SMBUS       0x1c22
> @@ -136,7 +137,9 @@ static int i801_check_pre(struct i2c_device *priv)
>  
>  	status = inb_p(SMBHSTSTS(priv));
>  	if (status & SMBHSTSTS_HOST_BUSY) {
> -		dev_err(&priv->adapter.dev, "SMBus is busy, can't use it! (status=%x)\n", status);
> +		dev_err(&priv->adapter.dev,
> +			"SMBus is busy, can't use it! (status=%x)\n",
> +			status);

Why did you put status on a new line?

>  		return -EBUSY;
>  	}
>  
> @@ -146,7 +149,9 @@ static int i801_check_pre(struct i2c_device *priv)
>  		outb_p(status, SMBHSTSTS(priv));
>  		status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
>  		if (status) {
> -			dev_err(&priv->adapter.dev, "Failed clearing status flags (%02x)\n", status);
> +			dev_err(&priv->adapter.dev,
> +				"Failed clearing status flags (%02x)\n",
> +				status);

Same here, why this last line change?



>  			return -EBUSY;
>  		}
>  	}
> @@ -162,15 +167,20 @@ static int i801_check_post(struct i2c_device *priv, int status, int timeout)
>  	if (timeout) {
>  		dev_err(&priv->adapter.dev, "Transaction timeout\n");
>  		/* try to stop the current command */
> -		dev_dbg(&priv->adapter.dev, "Terminating the current operation\n");
> -		outb_p(inb_p(SMBHSTCNT(priv)) | SMBHSTCNT_KILL, SMBHSTCNT(priv));
> +		dev_dbg(&priv->adapter.dev,
> +			"Terminating the current operation\n");
> +		outb_p(inb_p(SMBHSTCNT(priv)) | SMBHSTCNT_KILL,
> +		       SMBHSTCNT(priv));

SHouldn't this line up a bit differently?

You might want to use a text editor that handles this properly when
adding indentation.  I know vim does it, and I imagine that emacs does
as well.

thanks,

greg k-h