Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check

[Ye Xiaolong <xiaolong.ye@intel.com>]

On 09/18, Tianfei zhang wrote:
>Add pointer null check before dereference.
>
>Coverity issue: 344976
>Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
>Cc: stable@dpdk.org
>
>Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
>---
> drivers/raw/ifpga/base/opae_eth_group.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c
>index d189dd578..be28954e0 100644
>--- a/drivers/raw/ifpga/base/opae_eth_group.c
>+++ b/drivers/raw/ifpga/base/opae_eth_group.c
>@@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base)
> 
> void eth_group_release(struct eth_group_device *dev)
> {
>-	eth_group_hw_uinit(dev);
>-
> 	if (dev) {
>+		eth_group_hw_uinit(dev);
> 		dev->status = ETH_GROUP_DEV_NOUSED;
> 		opae_free(dev);
> 	}
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.