From: Tiwei Bie <tiwei.bie@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Zhihong Wang <zhihong.wang@intel.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix broken Tx checksum offloads
Date: Fri, 25 Oct 2019 14:37:11 +0800 [thread overview]
Message-ID: <20191025063711.GA25838@___> (raw)
In-Reply-To: <1571939170-19998-1-git-send-email-arybchenko@solarflare.com>
On Thu, Oct 24, 2019 at 06:46:09PM +0100, Andrew Rybchenko wrote:
> Missing parenthesis around expression before type cast to struct
> virtio_net_hdr pointer makes the arithmetic to be in
> sizeof(struct virtio_net_hdr) units.
>
> Use rte_pktmbuf_mtod_offset() to fix the problem.
>
> Type of head_size is changed to signed since some compilers bark
> on unary minus applied to unsigned.
>
> Fixes: 1ae55ad38e5e ("net/virtio: fix mbuf data and packet length mismatch")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/virtio/virtio_rxtx.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks,
Tiwei
next prev parent reply other threads:[~2019-10-25 6:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 17:46 [dpdk-dev] [PATCH] net/virtio: fix broken Tx checksum offloads Andrew Rybchenko
2019-10-25 6:37 ` Tiwei Bie [this message]
2019-10-25 8:30 ` Maxime Coquelin
2019-10-25 8:48 ` Maxime Coquelin
2019-10-25 10:22 ` Ferruh Yigit
2019-10-25 14:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025063711.GA25838@___ \
--to=tiwei.bie@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.