From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuil Ivanov <samuil.ivanovbg@gmail.com>
Cc: gregkh@linuxfoundation.org, manishc@marvell.com,
GR-Linux-NIC-Dev@marvell.com, devel@driverdev.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge
Date: Fri, 25 Oct 2019 13:19:05 +0300 [thread overview]
Message-ID: <20191025101705.GM24678@kadam> (raw)
In-Reply-To: <20191024212941.28149-2-samuil.ivanovbg@gmail.com>
On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote:
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 6ec7e3ce3863..e9f1363c5bf2 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2262,7 +2262,7 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, u32 data);
> int ql_unpause_mpi_risc(struct ql_adapter *qdev);
> int ql_pause_mpi_risc(struct ql_adapter *qdev);
> int ql_hard_reset_mpi_risc(struct ql_adapter *qdev);
> -int ql_soft_reset_mpi_risc(struct ql_adapter *qdev);
> +int qlge_soft_reset_mpi_risc(struct ql_adapter *qdev);
The patch series doesn't change all the functions so now it's hodge
podge.
> int ql_dump_risc_ram_area(struct ql_adapter *qdev, void *buf, u32 ram_addr,
> int word_count);
> int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump *mpi_coredump);
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 019b7e6a1b7a..df5344e113ca 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -1312,7 +1312,7 @@ void ql_get_dump(struct ql_adapter *qdev, void *buff)
>
> if (!test_bit(QL_FRC_COREDUMP, &qdev->flags)) {
> if (!ql_core_dump(qdev, buff))
> - ql_soft_reset_mpi_risc(qdev);
> + qlge_soft_reset_mpi_risc(qdev);
> else
> netif_err(qdev, drv, qdev->ndev, "coredump failed!\n");
> } else {
> diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> index 9e422bbbb6ab..efe893935929 100644
> --- a/drivers/staging/qlge/qlge_mpi.c
> +++ b/drivers/staging/qlge/qlge_mpi.c
> @@ -88,9 +88,10 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, u32 data)
> return status;
> }
>
> -int ql_soft_reset_mpi_risc(struct ql_adapter *qdev)
> +int qlge_soft_reset_mpi_risc(struct ql_adapter *qdev)
> {
> int status;
> +
> status = ql_write_mpi_reg(qdev, 0x00001010, 1);
This white space change is unrelated.
> return status;
> }
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-25 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 21:29 [PATCH 0/3] Staging: qlge: Rename of function prefix ql_ to qlge_ Samuil Ivanov
2019-10-24 21:29 ` [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge Samuil Ivanov
2019-10-25 10:19 ` Dan Carpenter [this message]
2019-10-25 14:28 ` Samuil Ivanov
2019-10-25 14:55 ` Dan Carpenter
2019-10-24 21:29 ` [PATCH 2/3] " Samuil Ivanov
2019-10-24 21:29 ` [PATCH 3/3] " Samuil Ivanov
2019-10-25 3:17 ` [PATCH 0/3] Staging: qlge: Rename of function prefix ql_ to qlge_ Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025101705.GM24678@kadam \
--to=dan.carpenter@oracle.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=samuil.ivanovbg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.