From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E493ACA9EA0 for ; Fri, 25 Oct 2019 13:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF7B821872 for ; Fri, 25 Oct 2019 13:42:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="meVJ1grC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504836AbfJYNmE (ORCPT ); Fri, 25 Oct 2019 09:42:04 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47344 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504824AbfJYNmE (ORCPT ); Fri, 25 Oct 2019 09:42:04 -0400 Received: from zn.tnic (p200300EC2F0D3C00E44239D1C9BE3FA7.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:3c00:e442:39d1:c9be:3fa7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A81211EC0CE5; Fri, 25 Oct 2019 15:41:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1572010918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sv5dF6qflHr5ZwIn8QIRu82I7QMFKoEE4TlrSi1RwOQ=; b=meVJ1grCo8aqtBibAed2PwgSaUG7POqonCWl4A+Rymf5qJjd0nRfGqbLEv3HixcqWwZRfL sJz16lZWDW3XrAWDR4vvIAYjOnGQYV5+KBfqAEaSB+mhabwM0Yy3txUIJkVmqzSBvrBrl/ 9L+2/qqafQz0TzdNWt5H8DJXVdUHVMA= Date: Fri, 25 Oct 2019 15:41:58 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 6/6] EDAC/amd64: Set grain per DIMM Message-ID: <20191025134158.GB6483@zn.tnic> References: <20191022203448.13962-1-Yazen.Ghannam@amd.com> <20191022203448.13962-7-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191022203448.13962-7-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Oct 22, 2019 at 08:35:14PM +0000, Ghannam, Yazen wrote: > From: Yazen Ghannam > > The following commit introduced a warning on error reports without a > non-zero grain value. > > 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation") > > The amd64_edac_mod module does not provide a value, so the warning will > be given on the first reported memory error. > > Set the grain per DIMM to cacheline size (64 bytes). This is the current > recommendation. > > Fixes: 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation") > Signed-off-by: Yazen Ghannam > --- > Link: > https://lkml.kernel.org/r/20191018153114.39378-7-Yazen.Ghannam@amd.com > > v1 -> v2: > * No change. > > rfc -> v1: > * New patch. > > drivers/edac/amd64_edac.c | 2 ++ > 1 file changed, 2 insertions(+) This one I can take now. Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette