From: Brian Foster <bfoster@redhat.com>
To: kaixuxia <xiakaixu1987@gmail.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
guaneryu@gmail.com, newtongao@tencent.com,
jasperwang@tencent.com
Subject: Re: [PATCH 1/4] fsstress: show the real file id and parid in rename_f()
Date: Fri, 25 Oct 2019 12:00:11 -0400 [thread overview]
Message-ID: <20191025160011.GD11837@bfoster> (raw)
In-Reply-To: <d68b2f32b3dbe57427e6bacaeb6e4a32d8576b0c.1571926790.git.kaixuxia@tencent.com>
On Thu, Oct 24, 2019 at 10:20:48PM +0800, kaixuxia wrote:
> The source file id and parentid are overwritten by del_from_flist()
> call, and should show the actually values.
>
> Signed-off-by: kaixuxia <kaixuxia@tencent.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> ltp/fsstress.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index 51976f5..95285f1 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -4227,6 +4227,7 @@ rename_f(int opno, long r)
> pathname_t newf;
> int oldid;
> int parid;
> + int oldparid;
> int v;
> int v1;
>
> @@ -4265,10 +4266,12 @@ rename_f(int opno, long r)
> if (e == 0) {
> int xattr_counter = fep->xattr_counter;
>
> - if (flp - flist == FT_DIR) {
> - oldid = fep->id;
> + oldid = fep->id;
> + oldparid = fep->parent;
> +
> + if (flp - flist == FT_DIR)
> fix_parent(oldid, id);
> - }
> +
> del_from_flist(flp - flist, fep - flp->fents);
> add_to_flist(flp - flist, id, parid, xattr_counter);
> }
> @@ -4277,7 +4280,7 @@ rename_f(int opno, long r)
> newf.path, e);
> if (e == 0) {
> printf("%d/%d: rename del entry: id=%d,parent=%d\n",
> - procid, opno, fep->id, fep->parent);
> + procid, opno, oldid, oldparid);
> printf("%d/%d: rename add entry: id=%d,parent=%d\n",
> procid, opno, id, parid);
> }
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2019-10-25 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 14:20 [PATCH 0/4] xfstests: add deadlock between the AGI and AGF with RENAME_WHITEOUT test kaixuxia
2019-10-24 14:20 ` [PATCH 1/4] fsstress: show the real file id and parid in rename_f() kaixuxia
2019-10-25 16:00 ` Brian Foster [this message]
2019-10-24 14:20 ` [PATCH 2/4] fsstress: add NOREPLACE and WHITEOUT renameat2 support kaixuxia
2019-10-25 16:01 ` Brian Foster
2019-10-24 14:20 ` [PATCH 3/4] fsstress: add EXCHANGE " kaixuxia
2019-10-25 16:01 ` Brian Foster
2019-10-24 14:20 ` [PATCH 4/4] xfs: test the deadlock between the AGI and AGF with RENAME_WHITEOUT kaixuxia
2019-10-25 16:01 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025160011.GD11837@bfoster \
--to=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=jasperwang@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=newtongao@tencent.com \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.