From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8026CA9EA0 for ; Fri, 25 Oct 2019 17:18:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4FB621872 for ; Fri, 25 Oct 2019 17:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="h7Yyp/Z8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4FB621872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D28F9183E; Fri, 25 Oct 2019 19:18:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D28F9183E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572023930; bh=DP0lrCOOAXsqg1mACP+FIL4KSMuMsZ6UfI6nRt+cSMc=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=h7Yyp/Z80nAIdmxV7ENrNOmo1wAx/LQyfpdEEScDREHHfSQrPsDIC6qm612rVLVyb z+H/Zu2uDc3pZaGMA6fHrl8J2Ko2VRISOdTWDmm+aPfUF0QTx+mztVazac1wmHJdiI GmWi8GvXlO2QF/k2Djg+/aXvpCuupjzJntALnCTA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 57123F80368; Fri, 25 Oct 2019 19:18:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76A7CF8036F; Fri, 25 Oct 2019 19:17:59 +0200 (CEST) Received: from muru.com (muru.com [72.249.23.125]) by alsa1.perex.cz (Postfix) with ESMTP id 091A1F80274 for ; Fri, 25 Oct 2019 19:17:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 091A1F80274 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 158DF80CD; Fri, 25 Oct 2019 17:18:10 +0000 (UTC) Date: Fri, 25 Oct 2019 10:17:33 -0700 From: Tony Lindgren To: Peter Ujfalusi Message-ID: <20191025171733.GW5607@atomide.com> References: <20191025130528.3556-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191025130528.3556-1-peter.ujfalusi@ti.com> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: hns@goldelico.com, alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, jarkko.nikula@bitmer.com Subject: Re: [alsa-devel] [PATCH v2] ASoC: ti: omap-mcpdm: Add support for pdmclk clock handling X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, * Peter Ujfalusi [191025 13:05]: > McPDM module receives it's functional clock from external source. This > clock is the pdmclk provided by the twl6040 audio IC. If the clock is not > available all register accesses to McPDM fails and the module is not > operational. > > this has been lurking in my next-wip branch for some time... > It might not needed anymore as I have not heard about issues with McPDM for a > while. > > It was dropped back then because some core parts were not picked in time and > this caused some issues, but can not find the exact reason Yes it's a strange solution to clock the internal mcpdm module externally :) AFAIK it's now already handled properly by ti-sysc. We have a common omap4-mcpdm.dtsi configure mcpdm clock forthe module, then ti-sysc driver defers probe until the mcpdm clock is available. And for omap5 we have omap5-board-common.dtsi configure it. So probably the only thing omap-mcpdm.c driver needs to do is to call PM runtime functions, maybe it's already doing that. Regards, Tony _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel