From: Tim Kourt <tim.a.kourt@linux.intel.com>
To: iwd@lists.01.org
Subject: [PATCH 1/5] client: Consolidate cancelation replies
Date: Fri, 25 Oct 2019 13:32:04 -0700 [thread overview]
Message-ID: <20191025203208.30628-1-tim.a.kourt@linux.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
---
client/agent.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/client/agent.c b/client/agent.c
index 8af714a2..b80e5727 100644
--- a/client/agent.c
+++ b/client/agent.c
@@ -50,6 +50,15 @@ static struct pending_op {
struct l_queue *saved_input;
} pending_op;
+static struct l_dbus_message *agent_reply_canceled(
+ struct l_dbus_message *message,
+ const char *text)
+{
+ return l_dbus_message_new_error(message,
+ IWD_AGENT_INTERFACE ".Error.Canceled",
+ "Error: %s", text);
+}
+
static struct l_dbus_message *agent_error(const char *text)
{
display_error(text);
@@ -342,9 +351,8 @@ static void process_input_username_password(const char *prompt)
if (l_queue_isempty(pending_op.saved_input)) {
/* received username */
if (!strlen(prompt)) {
- reply = l_dbus_message_new_error(pending_message,
- IWD_AGENT_INTERFACE ".Error.Canceled",
- "Canceled by user");
+ reply = agent_reply_canceled(pending_message,
+ "Canceled by user");
goto send_reply;
}
@@ -372,9 +380,8 @@ static void process_input_passphrase(const char *prompt)
struct l_dbus_message *reply;
if (!strlen(prompt)) {
- reply = l_dbus_message_new_error(pending_message,
- IWD_AGENT_INTERFACE ".Error.Canceled",
- "Canceled by user");
+ reply = agent_reply_canceled(pending_message,
+ "Canceled by user");
goto send_reply;
}
--
2.13.6
next reply other threads:[~2019-10-25 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 20:32 Tim Kourt [this message]
2019-10-25 20:32 ` [PATCH 2/5] client: Modify error handler to return cancelation msg Tim Kourt
2019-10-25 20:32 ` [PATCH 3/5] client: Respond to invalid agent requests Tim Kourt
2019-10-25 20:32 ` [PATCH 4/5] client: Fail on requests with invalid arguments Tim Kourt
2019-10-25 20:32 ` [PATCH 5/5] doc: Update agent API with possible errors Tim Kourt
2019-10-28 15:49 ` [PATCH 1/5] client: Consolidate cancelation replies Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025203208.30628-1-tim.a.kourt@linux.intel.com \
--to=tim.a.kourt@linux.intel.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.