All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Schmauss <erik.schmauss@intel.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>, linux-acpi@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com,
	Erik Schmauss <erik.schmauss@intel.com>,
	Bob Moore <robert.moore@intel.com>
Subject: [PATCH v2 08/12] ACPICA: debugger: surround field unit output with braces '{'
Date: Fri, 25 Oct 2019 14:36:56 -0700	[thread overview]
Message-ID: <20191025213700.14685-9-erik.schmauss@intel.com> (raw)
In-Reply-To: <20191025213700.14685-1-erik.schmauss@intel.com>

ACPICA commit 76ca57291d007d33087982a4b28cd1ee9bcd37a6

This helps differentiate the type of named objects between field
units and buffers. In other words, without this symbol, it would be
difficult to tell whether a particular named object is a buffer or a
field unit.

Link: https://github.com/acpica/acpica/commit/76ca5729
Signed-off-by: Erik Schmauss <erik.schmauss@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
---
 drivers/acpi/acpica/dbnames.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/dbnames.c b/drivers/acpi/acpica/dbnames.c
index bce2cfb17356..3615e1a6efd8 100644
--- a/drivers/acpi/acpica/dbnames.c
+++ b/drivers/acpi/acpica/dbnames.c
@@ -552,6 +552,11 @@ acpi_db_walk_for_fields(acpi_handle obj_handle,
 	buffer.length = ACPI_ALLOCATE_LOCAL_BUFFER;
 	acpi_evaluate_object(obj_handle, NULL, NULL, &buffer);
 
+	/*
+	 * Since this is a field unit, surround the output in braces
+	 */
+	acpi_os_printf("{");
+
 	ret_value = (union acpi_object *)buffer.pointer;
 	switch (ret_value->type) {
 	case ACPI_TYPE_INTEGER:
@@ -571,7 +576,7 @@ acpi_db_walk_for_fields(acpi_handle obj_handle,
 
 		break;
 	}
-	acpi_os_printf("\n");
+	acpi_os_printf("}\n");
 
 	ACPI_FREE(buffer.pointer);
 
-- 
2.21.0


  parent reply	other threads:[~2019-10-25 21:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 21:36 [PATCH v2 00/12] ACPICA version 20191018v2 Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 01/12] ACPICA: Results from Clang changes/fixes From Clang V5.0.1. Mostly "set but never read" warnings Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 02/12] ACPICA: Win OSL: Replace get_tick_count with get_tick_count64 Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 03/12] ACPICA: More Clang changes - V8.0.1 Fixed all "dead assignment" warnings Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 04/12] ACPICA: Add new external interface, acpi_unload_table Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 05/12] ACPICA: make acpi_load_table() return table index Erik Schmauss
2019-10-26 14:44   ` Andy Shevchenko
2019-10-28 17:15     ` Schmauss, Erik
2019-10-28 15:52   ` Andy Shevchenko
2019-10-25 21:36 ` [PATCH v2 06/12] ACPICA: utilities: add flag to only display data when dumping buffers Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 07/12] ACPICA: debugger: add command to dump all fields of a particular subtype Erik Schmauss
2019-10-25 21:36 ` Erik Schmauss [this message]
2019-10-25 21:36 ` [PATCH v2 09/12] ACPICA: debugger: add field unit support for acpi_db_get_next_token Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 10/12] ACPICA: acpiexec: initialize all simple types and field units from user input Erik Schmauss
2019-10-25 21:36 ` [PATCH v2 11/12] ACPICA: debugger: remove leading whitespaces when converting a string to a buffer Erik Schmauss
2019-10-25 21:37 ` [PATCH v2 12/12] ACPICA: Update version to 20191018 Erik Schmauss
2019-10-26 14:42 ` [PATCH v2 00/12] ACPICA version 20191018v2 Andy Shevchenko
2019-10-28 15:58 ` Andy Shevchenko
2019-10-28 17:49   ` Schmauss, Erik
2019-10-28 21:16     ` Rafael J. Wysocki
2019-10-29  9:56       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025213700.14685-9-erik.schmauss@intel.com \
    --to=erik.schmauss@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.