From: Christoph Hellwig <hch@infradead.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
mad skateman <madskateman@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Paul Mackerras <paulus@samba.org>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
"contact@a-eon.com" <contact@a-eon.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Christian Zigotzky <info@xenosoft.de>
Subject: Re: Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates
Date: Fri, 25 Oct 2019 23:39:18 -0700 [thread overview]
Message-ID: <20191026063918.GA24015@infradead.org> (raw)
In-Reply-To: <CAL_JsqLZV1sXc053QMLcV-dV1BbGcRtX3eu1zbtNA_N3hzQE4g@mail.gmail.com>
On Fri, Oct 25, 2019 at 05:28:45PM -0500, Rob Herring wrote:
> This doesn't work?:
>
> if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev->of_node))
> value |= ESDHC_DMA_SNOOP;
> else
> value &= ~ESDHC_DMA_SNOOP;
>
> While I said use the compatibles, using the kconfig symbol is easier
> than sorting out which compatibles are PPC SoCs. Though if that's
> already done elsewhere in the driver, you could set a flag and use
> that here. I'd be surprised if this was the only difference between
> ARM and PPC SoCs for this block.
I think the right thing is a Kconfig variable that the architectures
selects which says if OF is by default coherent or incoherent, and then
use that in of_dma_is_coherent.
next prev parent reply other threads:[~2019-10-26 6:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7b549219-a2e1-08c7-331b-9c3e4fdb8a8f@xenosoft.de>
[not found] ` <3aeae0d8-e9be-2585-cbbd-70263cb495f1@xenosoft.de>
[not found] ` <20191015125105.GU25745@shell.armlinux.org.uk>
[not found] ` <5611f3bc-68aa-78ec-182a-1cb414202314@xenosoft.de>
[not found] ` <20191015131750.GV25745@shell.armlinux.org.uk>
2019-10-23 5:42 ` Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates Michael Ellerman
2019-10-23 6:41 ` Benjamin Herrenschmidt
2019-10-23 13:52 ` Rob Herring
2019-10-23 14:12 ` Russell King - ARM Linux admin
2019-10-23 14:31 ` Russell King - ARM Linux admin
2019-10-25 22:28 ` Rob Herring
2019-10-26 6:39 ` Christoph Hellwig [this message]
2019-10-28 8:47 ` Benjamin Herrenschmidt
2019-10-28 8:45 ` Benjamin Herrenschmidt
2019-10-23 14:20 ` Christian Zigotzky
2019-11-04 14:44 ` Christian Zigotzky
2019-11-05 7:50 ` Bug 205201 - overflow of DMA mask and bus mask Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026063918.GA24015@infradead.org \
--to=hch@infradead.org \
--cc=chzigotzky@xenosoft.de \
--cc=contact@a-eon.com \
--cc=info@xenosoft.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madskateman@gmail.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=rtd2@xtra.co.nz \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.