From: Wolfram Sang <wsa@the-dreams.de>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>, Annaliese McDermond <nh6z@nh6z.net>,
Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC] i2c: bcm2835: Store pointer to bus clock
Date: Sat, 26 Oct 2019 17:33:15 +0200 [thread overview]
Message-ID: <20191026153314.GA5137@kunai> (raw)
In-Reply-To: <1572093288-6223-1-git-send-email-wahrenst@gmx.net>
[-- Attachment #1.1: Type: text/plain, Size: 288 bytes --]
> a NULL pointer dereference on driver unload. It seems that we can't fetch
> the bus clock via devm_clk_get in bcm2835_i2c_remove. As an alternative
Uh, yes, devm_* doesn't make sense in a remove function. We could
probably use plain clk_get/put here, but a pointer seems fine, too.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-26 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 12:34 [PATCH RFC] i2c: bcm2835: Store pointer to bus clock Stefan Wahren
2019-10-26 12:34 ` Stefan Wahren
2019-10-26 15:33 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026153314.GA5137@kunai \
--to=wsa@the-dreams.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=nh6z@nh6z.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.