From: Greg KH <gregkh@linuxfoundation.org>
To: "Frank A. Cancio Bello" <frank@generalsoftwareinc.com>
Cc: outreachy-kernel@googlegroups.com,
saiprakash.ranjan@codeaurora.org, joel@joelfernandes.org
Subject: Re: [PATCH] staging: ks7010: Fix unnecessary long lines
Date: Sun, 27 Oct 2019 08:04:56 +0100 [thread overview]
Message-ID: <20191027070456.GA1703830@kroah.com> (raw)
In-Reply-To: <20191027034056.GA20613@linux-kernel-dev>
On Sun, Oct 27, 2019 at 03:40:56AM +0000, Frank A. Cancio Bello wrote:
> checkpatch message: "WARNING:LONG_LINE: line over 80 characters"
>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
>
> This is the first patch that I send for "Outreachy December 2019 to
> March 2020". My plan is to keep these first patches very simple.
> Once they get approved I will move to less trivial fixes ;)
>
> drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
> drivers/staging/ks7010/ks_hostif.c | 9 ++++++---
> drivers/staging/ks7010/ks_wlan_net.c | 3 ++-
> 3 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 4b379542ecd5..c7ba658e234e 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -446,7 +446,8 @@ static void ks_wlan_hw_rx(struct ks_wlan_private *priv, size_t size)
> DUMP_PREFIX_OFFSET,
> rx_buffer->data, 32);
> #endif
> - ret = ks7010_sdio_writeb(priv, READ_STATUS_REG, REG_STATUS_IDLE);
> + ret = ks7010_sdio_writeb(priv,
> + READ_STATUS_REG, REG_STATUS_IDLE);
Why not just wrap the last parameter? That's the normal way to do
something like this.
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-27 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 3:40 [PATCH] staging: ks7010: Fix unnecessary long lines Frank A. Cancio Bello
2019-10-27 7:04 ` Greg KH [this message]
2019-10-28 1:32 ` Frank A. Cancio Bello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027070456.GA1703830@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=frank@generalsoftwareinc.com \
--cc=joel@joelfernandes.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.