Re: [Outreachy kernel] [PATCH] staging: speakup: Fix multiple assignments on a single line

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Oct 27, 2019 at 05:06:40AM +0000, Frank A. Cancio Bello wrote:
> checkpatch message: "multiple assignments should be avoided"
> 
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
> 
> This is the second patch that I send for "Outreachy December 2019 to
> March 2020".
> 
>  drivers/staging/speakup/main.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 488f2539aa9a..6f5a58bd1f81 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -263,9 +263,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
>  
>  static void speakup_date(struct vc_data *vc)
>  {
> -	spk_x = spk_cx = vc->vc_x;
> -	spk_y = spk_cy = vc->vc_y;
> -	spk_pos = spk_cp = vc->vc_pos;
> +	spk_cx = vc->vc_x;
> +	spk_x = spk_cx;
> +	spk_cy = vc->vc_y;
> +	spk_y = spk_cy;
> +	spk_cp = vc->vc_pos;
> +	spk_pos = spk_cp;

As Julia said, the original is better here.

thanks,

greg k-h