From: Shawn Guo <shawnguo@kernel.org>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@lists.codethink.co.uk, Jun Nie <jun.nie@linaro.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] zx: make zx_smp_prepare_cpus static
Date: Mon, 28 Oct 2019 11:06:23 +0800 [thread overview]
Message-ID: <20191028030621.GG16985@dragon> (raw)
In-Reply-To: <20191017103934.6814-1-ben.dooks@codethink.co.uk>
On Thu, Oct 17, 2019 at 11:39:34AM +0100, Ben Dooks (Codethink) wrote:
> The zx_smp_prepare_cpus is not declared and not directly
> exported outside of the file it is in. Make it static to
> remove the following sparse warning:
>
> arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Shawn Guo <shawnguo@kernel.org>
@Arnd, please help apply it to arm-soc, thanks!
Shawn
> ---
> Cc: Jun Nie <jun.nie@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/mach-zx/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
> index d4e1d3792224..43a33eaff388 100644
> --- a/arch/arm/mach-zx/platsmp.c
> +++ b/arch/arm/mach-zx/platsmp.c
> @@ -38,7 +38,7 @@ static void __iomem *pcu_base;
> static void __iomem *matrix_base;
> static void __iomem *scu_base;
>
> -void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> +static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> {
> struct device_node *np;
> unsigned long base = 0;
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-28 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 10:39 [PATCH] zx: make zx_smp_prepare_cpus static Ben Dooks (Codethink)
2019-10-28 3:06 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028030621.GG16985@dragon \
--to=shawnguo@kernel.org \
--cc=arnd@arndb.de \
--cc=ben.dooks@codethink.co.uk \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.