From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iOyPm-0002nr-5u for mharc-grub-devel@gnu.org; Mon, 28 Oct 2019 02:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39688) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOyPj-0002ni-Lt for grub-devel@gnu.org; Mon, 28 Oct 2019 02:22:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOyPg-0008F1-Lj for grub-devel@gnu.org; Mon, 28 Oct 2019 02:22:02 -0400 Received: from m9a0002g.houston.softwaregrp.com ([15.124.64.67]:45794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iOyPg-0008Cq-F8 for grub-devel@gnu.org; Mon, 28 Oct 2019 02:22:00 -0400 Received: FROM m9a0002g.houston.softwaregrp.com (15.121.0.190) BY m9a0002g.houston.softwaregrp.com WITH ESMTP FOR grub-devel@gnu.org; Mon, 28 Oct 2019 06:21:19 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M9W0067.microfocus.com (2002:f79:be::f79:be) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 28 Oct 2019 06:21:39 +0000 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (15.124.72.13) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 28 Oct 2019 06:21:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcU5RhQ7GE96jT6luMQeobGvSeTsMGxB0biiJm4krDzzSV78JSIfEqZ2dr52vAlXAb4DOqv9XVQ6V8Hp+kYixztzsPzqCCHp1FGBbvzJCfb3wM8d34ERa1N5GysOG0RDuyOEdwQuPf38/ETEukXOZXuNI5AuFgNDVXCCmEI8Tr2RKt7Z4i8HJZ/U0eTP/ooxnZ4WWQfLPfuJiorPuXUQrwVW8ajsHRcbO+HE05YoocpGb5+6u8Omm0rYZKdOXyD+Mey7LmKHyALBo65CNWqp7MqXOsOP/ll9rYdDS2A4OT+OjV/TU6YJB0AQcvE5hdLuaD6T8NpMG4Ft5p09Pb8UdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4Hwq6WX1h5UdlBfhfN0bbGpn2MhNlMeLZ2Nk/FveDg=; b=QEIlquV0+Rm0x3WdB6mgWGVgpUcN5mKH0OhjhPwqBy00BXn2jaJ2yEPlaemfAeWzmbOAqjXZRqkSytSAOOAufOfy8HoXqS50qU2teOcy0yA1xh+nbmR9Xnz7BmrIKNk+EUW67selXihQn1B/hXEkMUD6UZDCX+iVNmSFT+tDgvM2YiE6ss9P1p20rT2jiLy3O3AYbNwZb1mJNOutS57I8P6A3smdSg7495QbdzQuRp1hSUPA/VEmhRBRJjThaGT+5QA3wmiPEbUYfqxTirSQ0aCVO2hTIdaAmtTGfMcEh6Qn+zxZXr69ujGHUhKyC5qSkgKdTLAEH5fog4fq1v4JUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from BY5PR18MB3122.namprd18.prod.outlook.com (10.255.139.11) by BY5PR18MB3268.namprd18.prod.outlook.com (10.255.137.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Mon, 28 Oct 2019 06:21:33 +0000 Received: from BY5PR18MB3122.namprd18.prod.outlook.com ([fe80::297d:fc41:ae2a:13d9]) by BY5PR18MB3122.namprd18.prod.outlook.com ([fe80::297d:fc41:ae2a:13d9%5]) with mapi id 15.20.2387.025; Mon, 28 Oct 2019 06:21:33 +0000 From: Michael Chang To: The development of GNU GRUB Subject: Re: [PATCH] Enable pager by default Thread-Topic: [PATCH] Enable pager by default Thread-Index: AQHVhbHR4EwPnH/tAECTdh/EmdMy46dlNACAgAEmfQCAAF1bAIACrJQAgACBx4CAAQXmAIAACNGAgASvhoA= Date: Mon, 28 Oct 2019 06:21:33 +0000 Message-ID: <20191028062121.GA4715@mazu> References: <20191018124318.16361-1-javierm@redhat.com> <20191021145619.gewxm5eys4qu2ahp@tomti.i.net-space.pl> <6569e1ee-36e9-b774-0332-b746d591843b@redhat.com> <20191022140428.ignbsxgngmq4bm6x@tomti.i.net-space.pl> <20191024065440.GB8270@mazu> <20191024143909.ebhal3kbt2nt43qg@tomti.i.net-space.pl> <20191025061632.GA16881@mazu> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0019.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::31) To BY5PR18MB3122.namprd18.prod.outlook.com (2603:10b6:a03:1af::11) authentication-results: spf=none (sender IP is ) smtp.mailfrom=MChang@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [60.251.47.116] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8bfde82a-6453-42df-8719-08d75b6f141a x-ms-traffictypediagnostic: BY5PR18MB3268: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0204F0BDE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(7916004)(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(199004)(189003)(80792005)(229853002)(486006)(305945005)(476003)(6436002)(6486002)(1076003)(53546011)(64756008)(6506007)(66556008)(14444005)(66446008)(55236004)(256004)(102836004)(186003)(99286004)(7736002)(3846002)(66946007)(6116002)(6246003)(446003)(11346002)(52116002)(386003)(66476007)(25786009)(76176011)(478600001)(2906002)(966005)(81166006)(81156014)(6916009)(8936002)(66066001)(26005)(8676002)(86362001)(33716001)(33656002)(5660300002)(6306002)(14454004)(9686003)(316002)(6512007)(71200400001)(71190400001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY5PR18MB3268; H:BY5PR18MB3122.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:3; MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: luySGV+hZWIk6FDrEP97xfqHjdhzMq8yxRVR7qTSejevNm3ATOQimkKw12ydPGONrrchgwnaIeWhjJuqttdWKVNKGMTLsW8e5+NeeBWJsdgL8rggURZsBiGygz0zStpJyVTOhCN+2iYg2z9e4Jzx5Tcz8enmUtmT9Vb7gtGuiAlzSEH/Y/FCLcN2m0eVaFWFqhX8lSFzdzDcM1AMdCJhWt2E8wJ91t3ESs5Mg4kqrG88f1XDQJLjn1/+X8lLuKw799nPJaAvuo4U+bp9rtQHxLEuiSFe+y05AL3B3zub0OBDiDbju9uZJu6yn19w7YdfR8rBFlC8m8hag4qptfar7KqP7kw4nrnd2naP9nvT1LrYr4YL8VNMi6aIb97B6Fx+oi+GeA/4fwPDzwkHKGnd6485D4hQj8uxgnfoRU7ywt0DBDpiLxPsoZ1CvrZXI9hKk6Wlf4CC7nT3pPIL1pH70bMaU3JOphTgpn4ElOAzoCg= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8bfde82a-6453-42df-8719-08d75b6f141a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2019 06:21:33.6912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hbv4pnOCZKmzUSfsXa7REVBJlR12luL8/Hz5mHdYp9VUelqjRGplJu+jCKjHm/CO X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3268 X-OriginatorOrg: suse.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 15.124.64.67 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2019 06:22:05 -0000 On Fri, Oct 25, 2019 at 08:48:05AM +0200, Vladimir 'phcoder' Serbinenko wro= te: > On Fri, 25 Oct 2019, 08:20 Michael Chang, wrote: >=20 > > On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote: > > > On Thu, Oct 24, 2019 at 06:54:53AM +0000, Michael Chang wrote: > > > > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > > > > > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canilla= s > > wrote: > > > > > > Hello Daniel, > > > > > > > > > > > > On 10/21/19 4:56 PM, Daniel Kiper wrote: > > > > > > > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez > > Canillas wrote: > > > > > > >> From: Peter Jones > > > > > > >> > > > > > > >> When user enters into the GRUB shell and tries to use help > > command, lot of > > > > > > >> information is scrolled out of screen and the user doesn't h= ave > > chance to > > > > > > >> read it. Also, there isn't any information about 'set pager= =3D1' > > at the end > > > > > > >> of the help output, to tell the user how scrolling could be > > enabled. > > > > > > >> > > > > > > >> So just enable pager by default which leads to a much better > > experience. > > > > > > > > > > > > > > Hmmm... What will happen if a command produce tons of output > > during boot > > > > > > > process? I am afraid that it will hang indefinitely waiting f= or > > an user > > > > > > > input. This should not happen. So, I tend to agree that curre= nt > > help > > > > > > > command behavior is annoying but I do not like the solution. > > > > > > > > > > > > Ok. I'll then explore having a paginated output only for the he= lp > > command > > > > > > instead of globally enabling it by default. > > > > > > > > > > Great! Though I would think about something which can be used als= o in > > > > > other commands producing a lot of output. Maybe we should introdu= ce > > "-p" > > > > > (pause) command line option for such commands. And I am not again= st > > > > > using existing code to do a pause. We just have to do it carefull= y. > > > > > > > > I'd like to add option to the list, which is grub could provide the > > > > information to have the commands able to tell they are executed in > > > > shell's interactive (aka command-line) or batch mode. After they co= uld > > > > turn on/off paginated output according to the shell mode they are w= ith. > > > > > > Sounds interesting. However, I would go further. If pager =3D=3D 1 an= d we are > > > in batch mode then paging is inactive. If pager =3D=3D 2 and we are i= n batch > > > mode then paging is active. If we are in interactive mode then if > > > pager !=3D 0 then paging is active. > > > > I agree completely. In this way we no longer have to worry about settin= g > > page=3D1 would disrupt boot process as some command output could go ove= rly > > log and at the same time setting page=3D2 could enforce paginated outpu= t > > everywhere, like what is working now. :) > > > This increases complexity. Like what is batch mode. Is running sourcefile > batch or no? Yes, any running script (via source or similar) from interactive shell is also batch mode, only the command directly read from user's input in grub's command shell is considered interactive. > There will be edge cases like this. More complexity is more > risk. Moreover in this case the risk is not contained unlike in e.g. > filesystem modules that are not even loaded unless needed. Also it fails = at > informing the user. In fact it does the opposite by making it more > confusing at first glance. Informing the user on welcome message is bette= r OK. Adimttedly new behavior is more complex and more difficult to tell would inadvertantly enable interactive output. I am fine going with either way being discussed in this thread. :) Thanks, Michael >=20 > > > > Thanks, > > Michael > > > > > > > > Daniel > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel