From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Igor Russkikh <igor.russkikh@aquantia.com>,
"David S. Miller" <davem@davemloft.net>,
Dmitry Bezrukov <dmitry.bezrukov@aquantia.com>,
Nikita Danilov <nikita.danilov@aquantia.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: [PATCH net-next] net: aquantia: fix error handling in aq_nic_init
Date: Mon, 28 Oct 2019 01:56:33 -0500 [thread overview]
Message-ID: <20191028065633.GA2412@embeddedor> (raw)
Fix currenty ignored returned error by properly error checking
aq_phy_init().
Addresses-Coverity-ID: 1487376 ("Unused value")
Fixes: dbcd6806af42 ("net: aquantia: add support for Phy access")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
index 433adc099e44..1914aa0a19d0 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
@@ -341,7 +341,8 @@ int aq_nic_init(struct aq_nic_s *self)
if (self->aq_nic_cfg.aq_hw_caps->media_type == AQ_HW_MEDIA_TYPE_TP) {
self->aq_hw->phy_id = HW_ATL_PHY_ID_MAX;
- err = aq_phy_init(self->aq_hw);
+ if (!aq_phy_init(self->aq_hw))
+ goto err_exit;
}
for (i = 0U, aq_vec = self->aq_vec[0];
--
2.23.0
next reply other threads:[~2019-10-28 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 6:56 Gustavo A. R. Silva [this message]
2019-10-28 10:53 ` [EXT] [PATCH net-next] net: aquantia: fix error handling in aq_nic_init Igor Russkikh
2019-10-28 12:00 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028065633.GA2412@embeddedor \
--to=gustavo@embeddedor.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmitry.bezrukov@aquantia.com \
--cc=igor.russkikh@aquantia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.danilov@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.