From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Egor Pomozov <epomozov@marvell.com>,
Igor Russkikh <igor.russkikh@aquantia.com>,
"David S. Miller" <davem@davemloft.net>,
Sergey Samoilenko <sergey.samoilenko@aquantia.com>,
Dmitry Bezrukov <dmitry.bezrukov@aquantia.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: [PATCH net-next] net: aquantia: fix error handling in aq_ptp_poll
Date: Mon, 28 Oct 2019 02:04:47 -0500 [thread overview]
Message-ID: <20191028070447.GA3659@embeddedor> (raw)
Fix currenty ignored returned error by properly checking *err* after
calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().
Addresses-Coverity-ID: 1487357 ("Unused value")
Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
index 3ec08415e53e..92b666f7d242 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
@@ -678,6 +678,8 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget)
err = aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(aq_nic->aq_hw,
&aq_ptp->hwts_rx);
+ if (err < 0)
+ goto err_exit;
was_cleaned = true;
}
--
2.23.0
next reply other threads:[~2019-10-28 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 7:04 Gustavo A. R. Silva [this message]
2019-10-28 9:53 ` [EXT] [PATCH net-next] net: aquantia: fix error handling in aq_ptp_poll Igor Russkikh
2019-10-29 23:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028070447.GA3659@embeddedor \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=dmitry.bezrukov@aquantia.com \
--cc=epomozov@marvell.com \
--cc=igor.russkikh@aquantia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.samoilenko@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.