From: Peter Zijlstra <peterz@infradead.org>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, walken@google.com, dbueso@suse.de,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2 1/2] lib/rbtree: set successor's parent unconditionally
Date: Mon, 28 Oct 2019 10:20:45 +0100 [thread overview]
Message-ID: <20191028092045.GC4114@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191028021442.5450-1-richardw.yang@linux.intel.com>
On Mon, Oct 28, 2019 at 10:14:41AM +0800, Wei Yang wrote:
> Both in Case 2 and 3, we exchange n and s. This mean no matter whether
> child2 is NULL or not, successor's parent should be assigned to node's.
>
> This patch takes this step out to make it explicit and reduce the
> ambiguity.
>
> Besides, this step reduces some symbol size like rb_erase().
>
> KERN_CONFIG upstream patched
> OPT_FOR_PERF 877 870
> OPT_FOR_SIZE 635 621
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2019-10-28 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 2:14 [Patch v2 1/2] lib/rbtree: set successor's parent unconditionally Wei Yang
2019-10-28 2:14 ` [Patch v2 2/2] lib/rbtree: get successor's color directly Wei Yang
2019-10-28 9:21 ` Peter Zijlstra
2019-10-28 4:29 ` [Patch v2 1/2] lib/rbtree: set successor's parent unconditionally Michel Lespinasse
2019-10-28 6:23 ` Wei Yang
2019-10-28 9:20 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028092045.GC4114@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=richardw.yang@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.