All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Roulin <aroulin@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
	nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com,
	j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH iproute2-next 3/3] iplink: bond: print 3ad actor/partner oper states as strings
Date: Mon, 28 Oct 2019 09:58:02 -0700	[thread overview]
Message-ID: <20191028095802.5b5d5b43@hermes.lan> (raw)
In-Reply-To: <1572132594-2006-4-git-send-email-aroulin@cumulusnetworks.com>

On Sat, 26 Oct 2019 16:29:54 -0700
Andy Roulin <aroulin@cumulusnetworks.com> wrote:

> +	if (!is_json_context())
> +		fprintf(fp, " <");


You don't need conditional here.
Use:
	print_string(PRINT_FP, NULL, " <", NULL);

  parent reply	other threads:[~2019-10-28 16:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26 23:29 [PATCH iproute2-net-next 0/3] pretty-print 802.3ad slave state Andy Roulin
2019-10-26 23:29 ` [PATCH net-next 1/3] bonding: move 3ad port state defs to include/uapi Andy Roulin
2019-10-26 23:29 ` [PATCH iproute2-next 2/3] include/uapi: update bonding kernel header Andy Roulin
2019-10-26 23:29 ` [PATCH iproute2-next 3/3] iplink: bond: print 3ad actor/partner oper states as strings Andy Roulin
2019-10-27  9:41   ` Nikolay Aleksandrov
2019-10-28 16:58   ` Stephen Hemminger [this message]
2019-10-27  1:31 ` [PATCH iproute2-net-next 0/3] pretty-print 802.3ad slave state David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028095802.5b5d5b43@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=andy@greyhouse.net \
    --cc=aroulin@cumulusnetworks.com \
    --cc=dsahern@gmail.com \
    --cc=j.vosburgh@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.