From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3461CA9EBC for ; Mon, 28 Oct 2019 10:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F38A214D9 for ; Mon, 28 Oct 2019 10:24:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732042AbfJ1KYJ (ORCPT ); Mon, 28 Oct 2019 06:24:09 -0400 Received: from mga05.intel.com ([192.55.52.43]:28313 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731694AbfJ1KYJ (ORCPT ); Mon, 28 Oct 2019 06:24:09 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 03:24:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,239,1569308400"; d="scan'208";a="374192692" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 28 Oct 2019 03:24:07 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iP2By-00010f-3I; Mon, 28 Oct 2019 12:24:06 +0200 Date: Mon, 28 Oct 2019 12:24:06 +0200 From: Andy Shevchenko To: Hans de Goede Cc: "Rafael J . Wysocki" , Len Brown , Mika Westerberg , linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 5/6] ACPI / button: Add DMI quirk for Asus T200TA Message-ID: <20191028102406.GL32742@smile.fi.intel.com> References: <20191026202436.311894-1-hdegoede@redhat.com> <20191026202436.311894-5-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191026202436.311894-5-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sat, Oct 26, 2019 at 10:24:35PM +0200, Hans de Goede wrote: > The Asus T200TA lid has some weird behavior where _LID keeps reporting > closed after every second openening of the lid. Causing immediate > re-suspend after opening every other open. > > I've looked at the AML code but it involves talking to the EC and we > have no idea what the EC is doing. Setting lid_init_state to > ACPI_BUTTON_LID_INIT_OPEN fixes the unwanted behavior, so this commit > adds a DMI based quirk to use ACPI_BUTTON_LID_INIT_OPEN on the T200TA. Reviewed-by: Andy Shevchenko > > Signed-off-by: Hans de Goede > --- > Changes in v2: > - New patch in v2 of this series > --- > drivers/acpi/button.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c > index e4b2aa43265b..a090e9542d82 100644 > --- a/drivers/acpi/button.c > +++ b/drivers/acpi/button.c > @@ -77,6 +77,18 @@ MODULE_DEVICE_TABLE(acpi, button_device_ids); > > /* Please keep this list sorted alphabetically by vendor and model */ > static const struct dmi_system_id dmi_lid_quirks[] = { > + { > + /* > + * Asus T200TA, _LID keeps reporting closed after every second > + * openening of the lid. Causing immediate re-suspend after > + * opening every other open. Using LID_INIT_OPEN fixes this. > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "T200TA"), > + }, > + .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN, > + }, > { > /* GP-electronic T701, _LID method points to a floating GPIO */ > .matches = { > -- > 2.23.0 > -- With Best Regards, Andy Shevchenko