From: coverity-bot <keescook@chromium.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: find_idlest_group(): Null pointer dereferences
Date: Mon, 28 Oct 2019 16:03:20 -0700 [thread overview]
Message-ID: <201910281603.4378C08@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
57abff067a08 ("sched/fair: Rework find_idlest_group()")
Coverity reported the following:
*** CID 1487371: Null pointer dereferences (FORWARD_NULL)
/kernel/sched/fair.c: 8319 in find_idlest_group()
8313 case group_asym_packing:
8314 /* Those type are not used in the slow wakeup path */
8315 return NULL;
8316
8317 case group_misfit_task:
8318 /* Select group with the highest max capacity */
vvv CID 1487371: Null pointer dereferences (FORWARD_NULL)
vvv Dereferencing null pointer "local".
8319 if (local->sgc->max_capacity >= idlest->sgc->max_capacity)
8320 return NULL;
8321 break;
8322
8323 case group_has_spare:
8324 if (sd->flags & SD_NUMA) {
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487371 ("Null pointer dereferences")
Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2019-10-28 23:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 23:03 coverity-bot [this message]
2019-10-29 8:07 ` Coverity: find_idlest_group(): Null pointer dereferences Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281603.4378C08@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.