From: coverity-bot <keescook@chromium.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: execlists_update_context(): Integer handling issues
Date: Mon, 28 Oct 2019 16:04:09 -0700 [thread overview]
Message-ID: <201910281603.AE297D69@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
08fff7aeddc9 ("drm/i915/tgl: Wa_1607138340")
Coverity reported the following:
*** CID 1487369: Integer handling issues (NO_EFFECT)
/drivers/gpu/drm/i915/gt/intel_lrc.c: 1057 in execlists_update_context()
1051 mb();
1052
1053 desc = ce->lrc_desc;
1054 ce->lrc_desc &= ~CTX_DESC_FORCE_RESTORE;
1055
1056 /* Wa_1607138340:tgl */
vvv CID 1487369: Integer handling issues (NO_EFFECT)
vvv This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "rq->i915->drm.pdev->revision >= 0".
1057 if (IS_TGL_REVID(rq->i915, TGL_REVID_A0, TGL_REVID_A0))
1058 desc |= CTX_DESC_FORCE_RESTORE;
1059
1060 return desc;
1061 }
1062
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487369 ("Integer handling issues")
Fixes: 08fff7aeddc9 ("drm/i915/tgl: Wa_1607138340")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281603.AE297D69@keescook \
--to=keescook@chromium.org \
--cc=chris@chris-wilson.co.uk \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.