From: Christoph Hellwig <hch@infradead.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Sultan Alsawaf <sultan@kerneltoast.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
Palmer Dabbelt <palmer@sifive.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Ming Lei <ming.lei@redhat.com>,
Gal Pressman <galpress@amazon.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scatterlist: Speed up for_each_sg() loop macro
Date: Mon, 28 Oct 2019 09:28:16 -0700 [thread overview]
Message-ID: <20191028162816.GA17182@infradead.org> (raw)
In-Reply-To: <20191028162320.GF29652@ziepe.ca>
On Mon, Oct 28, 2019 at 01:23:20PM -0300, Jason Gunthorpe wrote:
> This testing is making assumptions about how 'nr' is used and the
> construction of the sgl though
>
> If any chains are partially populated, or for some reason the driver
> starts at a different sgl, it will break. You'll need to somehow
> show none of those possibilities are happening.
And there is nothing forcing a particular layout, there just happens
to be a layout that the generic allocator gives you. I'm not even
sure the original patch handles the SCSI case of small inlines segments
properly.
next prev parent reply other threads:[~2019-10-28 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 21:33 [PATCH] scatterlist: Speed up for_each_sg() loop macro Sultan Alsawaf
2019-10-28 14:17 ` Jason Gunthorpe
2019-10-28 16:18 ` Sultan Alsawaf
2019-10-28 16:23 ` Jason Gunthorpe
2019-10-28 16:28 ` Christoph Hellwig [this message]
2019-10-28 16:37 ` Sultan Alsawaf
2019-10-28 16:29 ` Sultan Alsawaf
2019-10-28 23:46 ` kbuild test robot
2019-10-28 23:46 ` kbuild test robot
2019-10-29 2:25 ` Ming Lei
2019-11-01 3:33 ` [scatterlist] 8f39742f03: suspend_stress.fail kernel test robot
2019-11-01 3:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028162816.GA17182@infradead.org \
--to=hch@infradead.org \
--cc=galpress@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=palmer@sifive.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sultan@kerneltoast.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.