From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2] tpm: Add major_version sysfs file
Date: Mon, 28 Oct 2019 22:53:13 +0200 [thread overview]
Message-ID: <20191028205313.GH8279@linux.intel.com> (raw)
In-Reply-To: <20191025193103.30226-1-jsnitsel@redhat.com>
On Fri, Oct 25, 2019 at 12:31:03PM -0700, Jerry Snitselaar wrote:
> + return sprintf(buf, "%s\n", chip->flags & TPM_CHIP_FLAG_TPM2
> + ? "2.0" : "1.2");
This is not right. Should be either "1" or "2".
/Jarkko
next prev parent reply other threads:[~2019-10-28 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 19:31 [PATCH v2] tpm: Add major_version sysfs file Jerry Snitselaar
2019-10-28 20:53 ` Jarkko Sakkinen [this message]
2019-10-28 21:05 ` Jerry Snitselaar
2019-10-29 9:17 ` Jarkko Sakkinen
2019-10-29 12:43 ` Jason Gunthorpe
2019-10-29 14:22 ` Jarkko Sakkinen
2019-10-29 14:56 ` James Bottomley
2019-10-29 15:22 ` Jason Gunthorpe
2019-10-29 19:11 ` Jerry Snitselaar
2019-10-31 21:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028205313.GH8279@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.