From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414B6CA9EC0 for ; Tue, 29 Oct 2019 01:55:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11C4621721 for ; Tue, 29 Oct 2019 01:55:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IAt6IlL7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730017AbfJ2Bzl (ORCPT ); Mon, 28 Oct 2019 21:55:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39460 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728432AbfJ2Bzk (ORCPT ); Mon, 28 Oct 2019 21:55:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sjXFPKiWrLyR6LHPsDmQMC4ULkd5iUf14tApuhtKjWI=; b=IAt6IlL7bCnqA3YBZLRZvaQQW1 jX/49ygOkpMCKL4CYlyAL3+myL5k2dBmepZJ0srWGH5EaG4V+v2aQZiL37wdBxOGAB/1NrXKXRzoO 8KHPgiKv82Qihw59TQeEUycm98Z8T7P+p1pD4waTBYzgN5hk8ESJhSML+9djW52PtPGA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iPGjR-0001Hv-VC; Tue, 29 Oct 2019 02:55:37 +0100 Date: Tue, 29 Oct 2019 02:55:37 +0100 From: Andrew Lunn To: Ioana Ciornei Cc: davem@davemloft.net, netdev@vger.kernel.org, laurentiu.tudor@nxp.com, f.fainelli@gmail.com, linux@armlinux.org.uk Subject: Re: [PATCH net-next v3 4/5] dpaa2-eth: add MAC/PHY support through phylink Message-ID: <20191029015537.GI15259@lunn.ch> References: <1571998630-17108-1-git-send-email-ioana.ciornei@nxp.com> <1571998630-17108-5-git-send-email-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571998630-17108-5-git-send-email-ioana.ciornei@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 25, 2019 at 01:17:09PM +0300, Ioana Ciornei wrote: > The dpaa2-eth driver now has support for connecting to its associated > PHY device found through standard OF bindings. > > This happens when the DPNI object (that the driver probes on) gets > connected to a DPMAC. When that happens, the device tree is looked up by > the DPMAC ID, and the associated PHY bindings are found. > > The old logic of handling the net device's link state by hand still > needs to be kept, as the DPNI can be connected to other devices on the > bus than a DPMAC: other DPNI, DPSW ports, etc. This logic is only > engaged when there is no DPMAC (and therefore no phylink instance) > attached. > > The MC firmware support multiple type of DPMAC links: TYPE_FIXED, > TYPE_PHY. The TYPE_FIXED mode does not require any DPMAC management from > Linux side, and as such, the driver will not handle such a DPMAC. > > Although PHYLINK typically handles SFP cages and in-band AN modes, for > the moment the driver only supports the RGMII interfaces found on the > LX2160A. Support for other modes will come later. > > Signed-off-by: Ioana Ciornei Reviewed-by: Andrew Lunn Andrew