Re: [PATCH] doc: fix warnings for unused files in toctree

[Jonathan Corbet <corbet@lwn.net>]

On Mon, 28 Oct 2019 18:26:09 +0100
Héctor Orón Martínez <hector.oron@gmail.com> wrote:

>   I was planning to add more fixes in separated commit, but while
> working on it, apparently it could be part of the previous commit.
>   Apologies, find updated patch.

Thanks for working to improve the documentation!  I do have a couple of
requests, though...

 - Please send patches inline, rather than as attachments; that makes
   them much easier to review.

 - Please work against docs-next and look at the history of what you are
   working on. For example:

> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
> index b541e97c7ab1..d2f3c95ea9ed 100644
> --- a/Documentation/driver-api/dma-buf.rst
> +++ b/Documentation/driver-api/dma-buf.rst
> @@ -115,18 +115,6 @@ Kernel Functions and Structures Reference
>  .. kernel-doc:: include/linux/dma-buf.h
>     :internal:
>  
> -Reservation Objects
> --------------------
> -
> -.. kernel-doc:: drivers/dma-buf/reservation.c
> -   :doc: Reservation Object Overview
> -
> -.. kernel-doc:: drivers/dma-buf/reservation.c
> -   :export:
> -
> -.. kernel-doc:: include/linux/reservation.h
> -   :internal:

This is not a correct fix; those files have been renamed, not removed.
There is a (correct) fix in docs-next, and has been for some weeks now.

If you could please review the rest of your patch and resubmit against
docs-next, I would appreciate it.

Many thanks,

jon