From: Simon Horman <simon.horman@netronome.com>
To: Joe Perches <joe@perches.com>
Cc: Saurav Girepunje <saurav.girepunje@gmail.com>,
kvalo@codeaurora.org, davem@davemloft.net, swinslow@gmail.com,
will@kernel.org, opensource@jilayne.com, baijiaju1990@gmail.com,
tglx@linutronix.de, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] b43: Fix use true/false for bool type
Date: Tue, 29 Oct 2019 09:43:44 +0100 [thread overview]
Message-ID: <20191029084344.GD23615@netronome.com> (raw)
In-Reply-To: <055503c8dce7546a8253de1d795ad71870eeb362.camel@perches.com>
On Tue, Oct 29, 2019 at 01:30:34AM -0700, Joe Perches wrote:
> On Tue, 2019-10-29 at 09:24 +0100, Simon Horman wrote:
> > I wonder why bools rather than a bitmask was chosen
> > for this field, it seems rather space intensive in its current form.
>
> 4 bools is not intensive.
Thanks, point taken.
>
> > > diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> []
> > > @@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
> []
> > > - wl->tx_queue_stopped[queue_num] = 1;
> > > + wl->tx_queue_stopped[queue_num] = true;
>
>
next prev parent reply other threads:[~2019-10-29 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 19:02 [PATCH] b43: Fix use true/false for bool type Saurav Girepunje
2019-10-29 8:24 ` Simon Horman
2019-10-29 8:30 ` Joe Perches
2019-10-29 8:43 ` Simon Horman [this message]
2019-10-29 8:43 ` Simon Horman
2019-10-31 8:07 ` [PATCH] b43: main: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029084344.GD23615@netronome.com \
--to=simon.horman@netronome.com \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opensource@jilayne.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.