From mboxrd@z Thu Jan 1 00:00:00 1970 From: LABBE Corentin Date: Tue, 29 Oct 2019 12:42:03 +0000 Subject: Re: [PATCH -next] crypto: amlogic - Use kmemdup in meson_aes_setkey() Message-Id: <20191029124203.GB18754@Red> List-Id: References: <20191029015523.126987-1-yuehaibing@huawei.com> In-Reply-To: <20191029015523.126987-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Oct 29, 2019 at 01:55:23AM +0000, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing > --- > drivers/crypto/amlogic/amlogic-gxl-cipher.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c > index e9283ffdbd23..78e776c58705 100644 > --- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c > +++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c > @@ -372,10 +372,9 @@ int meson_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, > kfree(op->key); > } > op->keylen = keylen; > - op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA); > + op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); > if (!op->key) > return -ENOMEM; > - memcpy(op->key, key, keylen); > > return crypto_sync_skcipher_setkey(op->fallback_tfm, key, keylen); > } > > > Acked-by: Corentin Labbe Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43999CA9EAE for ; Tue, 29 Oct 2019 12:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 169BF21721 for ; Tue, 29 Oct 2019 12:42:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="oLxdOYd2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729452AbfJ2MmX (ORCPT ); Tue, 29 Oct 2019 08:42:23 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44506 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728321AbfJ2MmW (ORCPT ); Tue, 29 Oct 2019 08:42:22 -0400 Received: by mail-wr1-f68.google.com with SMTP id z11so13447859wro.11 for ; Tue, 29 Oct 2019 05:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BPXp7xNo1ijPMANZMC0OJQTiJUBGfJGREatgOxfICDA=; b=oLxdOYd2VPtLQZ8doEBWg3jJLtOOjZP0nu8AK0107eeu0xUi1HabO38UPUHtrxB2vJ r2mpnITzdzYIIqJ/W3iu+aEU8bgU4W0LncSrHb+UQAu7yhrjvZI4vKFMOCu2U9pFXqvi +5xbARGaMsnVr6r9l4LLzbw7OBSPNHSspPiIO0ZVlEYHkjpEBRj6pbDsjuIcyXnBmLTr LladgHavdxtVP4r13zbSlUYLXfn2vMjbA7T9FSdKXeaQbQXd+XiBUhQOrQ9IEcwF2azi q3OobcCUiDAGnX66Oc5MQpSpIzVfs2BYD9l8AoBtaj1Ri+QnV0jQr/Zi2OM9ICYyL8H5 mh2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BPXp7xNo1ijPMANZMC0OJQTiJUBGfJGREatgOxfICDA=; b=PG8vXLAvpN2D7ysaji4i/PEMjITpNIux5E9MD5Crh2HO15dW+hx4E3TD2ipzH3oNy8 gDadopr2mI09AvQ30CRABYLwT4s4SREhN0/CVV8D1RkylNKescWaUDbYozFrVhweXhqq +q7b+gIkgKgZlNSNnP3G5/EBuKjzq5wuezngFnjiVNQKWzfqYtLpDzNVohsgXcLkwRQc Ynz6+JTarLGK+0oQx4Az02qZhCrZuZC5amIRHqkE5UkQGn3imACKADoFUeeqF70M26KR 6BF4ZOITt1OBc2jgk1c1E/sskgkxY2YGcBnvtOHzR1gG7B6pnLnkm5FIEEk7pToWhWRR uYhw== X-Gm-Message-State: APjAAAUrC/WKm76Sex5cZ6zQGzAVeYuTO+LWrcCWqSmRr5gdU7rTv9iO aznjWyj7MfSYsEBk4NcPKGozpg== X-Google-Smtp-Source: APXvYqwqHf4wuK2I5AO9f/kEeooVPfRaL4aX5EEIOq9YjaTwHJCt7yKNkRGNPtbE0yZCGA/QU/7aIQ== X-Received: by 2002:adf:fbc4:: with SMTP id d4mr1318049wrs.265.1572352940992; Tue, 29 Oct 2019 05:42:20 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id f143sm3375496wme.40.2019.10.29.05.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 05:42:20 -0700 (PDT) Date: Tue, 29 Oct 2019 13:42:03 +0100 From: LABBE Corentin To: YueHaibing Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] crypto: amlogic - Use kmemdup in meson_aes_setkey() Message-ID: <20191029124203.GB18754@Red> References: <20191029015523.126987-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029015523.126987-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Oct 29, 2019 at 01:55:23AM +0000, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing > --- > drivers/crypto/amlogic/amlogic-gxl-cipher.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c > index e9283ffdbd23..78e776c58705 100644 > --- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c > +++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c > @@ -372,10 +372,9 @@ int meson_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, > kfree(op->key); > } > op->keylen = keylen; > - op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA); > + op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); > if (!op->key) > return -ENOMEM; > - memcpy(op->key, key, keylen); > > return crypto_sync_skcipher_setkey(op->fallback_tfm, key, keylen); > } > > > Acked-by: Corentin Labbe Thanks