From: Vincent Cheng <vincent.cheng.xh@renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock
Date: Tue, 29 Oct 2019 15:00:08 +0000 [thread overview]
Message-ID: <20191029145953.GA29825@renesas.com> (raw)
In-Reply-To: <20191025193228.GA31398@bogus>
On Fri, Oct 25, 2019 at 03:32:28PM EDT, Rob Herring wrote:
>On Mon, Oct 21, 2019 at 03:57:47PM -0400, vincent.cheng.xh@renesas.com wrote:
>> From: Vincent Cheng <vincent.cheng.xh@renesas.com>
>>
>> Add device tree binding doc for the IDT ClockMatrix PTP clock.
>>
>> +
>> +examples:
>> + - |
>> + phc@5b {
>
>ptp@5b
>
>Examples are built now and this fails:
>
>Documentation/devicetree/bindings/ptp/ptp-idtcm.example.dts:19.15-28:
>Warning (reg_format): /example-0/phc@5b:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
>
>The problem is i2c devices need to be shown under an i2c bus node.
>
>> + compatible = "idt,8a34000";
>> + reg = <0x5b>;
>> + };
I am trying to replicate the problem locally to confirm the fix prior to re-submission.
I have tried the following:
./tools/dt-doc-validate ~/projects/linux/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
./tools/dt-extract-example ~/projects/linux/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml > example.dts
How to validate the example.dts file against the schema in ptp-idtcm.yaml?
Thanks in advance.
Regards,
Vincent
next prev parent reply other threads:[~2019-10-29 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 19:57 [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock vincent.cheng.xh
2019-10-21 19:57 ` [PATCH v3 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix vincent.cheng.xh
2019-10-25 19:32 ` [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock Rob Herring
2019-10-29 15:00 ` Vincent Cheng [this message]
2019-10-29 21:20 ` Rob Herring
2019-10-30 2:45 ` Vincent Cheng
2019-10-30 2:54 ` Vincent Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029145953.GA29825@renesas.com \
--to=vincent.cheng.xh@renesas.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.