All of lore.kernel.org
 help / color / mirror / Atom feed
From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH RFC i-g-t 08/10] lib/igt_fb.c: Update tile sizes for GEN12 Color Clear
Date: Tue, 29 Oct 2019 14:31:06 -0700	[thread overview]
Message-ID: <20191029213106.GE15634@InViCtUs> (raw)
In-Reply-To: <20190925130931.29107-9-mika.kahola@intel.com>

On Wed, Sep 25, 2019 at 04:09:29PM +0300, Mika Kahola wrote:
> Update tile sizes for GEN12 Color Clear.
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  lib/igt_fb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 618e7a63..603636be 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -383,6 +383,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  		break;
>  	case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
>  	case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> +	case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
>  		igt_require_intel(fd);
>  		switch (fb_bpp) {
>  		case 8:
> @@ -466,6 +467,7 @@ static bool is_ccs_modifier(uint64_t modifier)
>  
>  	return modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS ||
>  		modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ||
> +		modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ||
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC uses 3 planes. The third plane for Clear Color structure.
We need to make additional changes to support 3rd plane.

- Radhakrishna(RK) Sripada
>  		modifier == I915_FORMAT_MOD_Y_TILED_CCS ||
>  		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
>  }
> @@ -688,6 +690,7 @@ uint64_t igt_fb_mod_to_tiling(uint64_t modifier)
>  	case LOCAL_I915_FORMAT_MOD_Y_TILED_CCS:
>  	case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
>  	case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> +	case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
>  		return I915_TILING_Y;
>  	case LOCAL_I915_FORMAT_MOD_Yf_TILED:
>  	case LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS:
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-10-29 21:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 13:09 [igt-dev] [PATCH RFC i-g-t 00/10] GEN12 render and media compression with Clear Color Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 01/10] Format modifier for Intel Gen-12 render compression Mika Kahola
2019-10-29 21:26   ` Radhakrishna Sripada
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 02/10] lib/igt_fb.c: Update tile sizes for GEN12 CCS Mika Kahola
2019-10-29 21:25   ` Radhakrishna Sripada
2019-10-30 11:23     ` Kahola, Mika
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 03/10] tests/kms_ccs: Add GEN12 CCS render compression format modifiers Mika Kahola
2019-10-29 21:27   ` Radhakrishna Sripada
2019-10-30 13:47     ` Kahola, Mika
2019-10-30 13:55       ` Ville Syrjälä
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 04/10] Format modifier for Intel Gen-12 media compression Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 05/10] lib/igt_fb.c: Update tile sizes for GEN12 MCS Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 06/10] tests/kms_ccs: Add GEN12 CCS media compression format modifiers Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 07/10] Format modifier for Gen-12 render engine with Color Clear Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 08/10] lib/igt_fb.c: Update tile sizes for GEN12 " Mika Kahola
2019-10-29 21:31   ` Radhakrishna Sripada [this message]
2019-10-30 10:29     ` Kahola, Mika
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 09/10] tests/kms_ccs: Add GEN12 CCS Color Clear format modifiers Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 10/10] tests/kms_getgfb: Update GEN12 CCS " Mika Kahola
2019-09-25 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for GEN12 render and media compression with Clear Color Patchwork
2019-09-26  4:23 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029213106.GE15634@InViCtUs \
    --to=radhakrishna.sripada@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.