From: Simon Horman <simon.horman@netronome.com>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc()
Date: Wed, 30 Oct 2019 13:27:01 +0100 [thread overview]
Message-ID: <20191030122659.GA23163@netronome.com> (raw)
In-Reply-To: <909fa55ac93fa8727ee1d9ec273011056ad7d61f.1572382598.git.gnault@redhat.com>
On Tue, Oct 29, 2019 at 09:57:10PM +0100, Guillaume Nault wrote:
> This parameter has never been used.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> drivers/net/vxlan.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 3d9bcc957f7d..5ffea8e34771 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -793,8 +793,7 @@ static int vxlan_gro_complete(struct sock *sk, struct sk_buff *skb, int nhoff)
> return eth_gro_complete(skb, nhoff + sizeof(struct vxlanhdr));
> }
>
> -static struct vxlan_fdb *vxlan_fdb_alloc(struct vxlan_dev *vxlan,
> - const u8 *mac, __u16 state,
> +static struct vxlan_fdb *vxlan_fdb_alloc(const u8 *mac, __u16 state,
> __be32 src_vni, __u16 ndm_flags)
> {
> struct vxlan_fdb *f;
> @@ -835,7 +834,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
> return -ENOSPC;
>
> netdev_dbg(vxlan->dev, "add %pM -> %pIS\n", mac, ip);
> - f = vxlan_fdb_alloc(vxlan, mac, state, src_vni, ndm_flags);
> + f = vxlan_fdb_alloc(mac, state, src_vni, ndm_flags);
> if (!f)
> return -ENOMEM;
>
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-10-30 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 20:57 [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc() Guillaume Nault
2019-10-30 12:27 ` Simon Horman [this message]
2019-10-31 0:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030122659.GA23163@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.