From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2494ACA9EC5 for ; Wed, 30 Oct 2019 13:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0ED320856 for ; Wed, 30 Oct 2019 13:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572442176; bh=igiX650YpjR8H3mGZ/ALPmIk+Lrkf/kUdT1CdvytKdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XZ2OUALjJeV0LsQkNux8nLpGy8lzAdLg4QkVU9x8H+ZTIBo+/d/YKm0fSZVvTM3BP an8agFxTTpIeq/DqygacHIQLw3Vfw3niRn0w8FspKgSauor7l06NxMsaLctFl77wLu 1nF6VEnyWpEhQsFmEtPr1IiDjdjLQvhW00TolZDo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbfJ3N3f (ORCPT ); Wed, 30 Oct 2019 09:29:35 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:44702 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbfJ3N3e (ORCPT ); Wed, 30 Oct 2019 09:29:34 -0400 Received: by mail-ot1-f68.google.com with SMTP id n48so2055016ota.11; Wed, 30 Oct 2019 06:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2PIp3nuujjbVDTCQlERuQPPmNS4hMz6vAUUQvwn05Tc=; b=HCru8Ej2p19n/vaYXq0Vuji5lWKCNrkqKpiBpfQ+0eQJ+UNkYiN0kCMRhYPXBsOV44 LF/HfHmdCwHFLkHSf7OOPvHN/VX4g4IZZiYiMF2uzcFGq5nP3uXWjiI+YGfZ6NvFWtp1 guA8AYHYihnaXhbuMKuXiaPl+8z3Ow9GIvBEYedo/sW4wvId3dtqiOIFh7fvZBz0pdMm isdPwWD/Llz39wfX9KKX/mtomWoNi9jTyjJEZOcYVn3E9c4pG2lMsbxzuI+6yjosh5+r lFis5fL7IGMSKLgNQD23g/gYx3nfIBz17JkvCA+hed/FDO6Tz4a8qowpwswTS9Q7goay ZEWQ== X-Gm-Message-State: APjAAAXe2PLU20K+ZKZ1dJm9uCZVqUrr+Zp57UAxBnKPHnXWlaD2ionr BpO2iz0YQLnW7q3x/tAJ6g== X-Google-Smtp-Source: APXvYqxZ/cduY/57uFpVQbDA+dzUHNgNL7l4CUKcqiu/GlyrSfqJ4CfvFx7pOS+ityjeM2CS6IH5vA== X-Received: by 2002:a05:6830:1e65:: with SMTP id m5mr13647806otr.41.1572442173786; Wed, 30 Oct 2019 06:29:33 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id u1sm9804oie.37.2019.10.30.06.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 06:29:33 -0700 (PDT) Date: Wed, 30 Oct 2019 08:29:32 -0500 From: Rob Herring To: John Stultz Cc: Rob Herring , lkml , Mark Rutland , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , "Andrew F . Davis" , Chenbo Feng , Alistair Strachan , Sandeep Patil , Hridya Valsaraju , devicetree , dri-devel Subject: Re: [RFC][PATCH 1/3] dt-bindings: dma-buf: heaps: Describe CMA regions to be added to dmabuf heaps interface. Message-ID: <20191030132932.GA7292@bogus> References: <20191025225009.50305-1-john.stultz@linaro.org> <20191025225009.50305-2-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 25, 2019 at 04:55:35PM -0700, John Stultz wrote: > On Fri, Oct 25, 2019 at 4:32 PM Rob Herring wrote: > > > > On Fri, Oct 25, 2019 at 5:51 PM John Stultz wrote: > > > > > > This binding specifies which CMA regions should be added to the > > > dmabuf heaps interface. > > > > Is this an ION DT binding in disguise? I thought I killed that. ;) > > Maybe? I may not have been paying attention back then. :) > > > > +Example: > > > +This example has a camera CMA node in reserved memory, which is then > > > +referenced by the dmabuf-heap-cma node. > > > + > > > + > > > + reserved-memory { > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > + ... > > > + cma_camera: cma-camera { > > > + compatible = "shared-dma-pool"; > > > + reg = <0x0 0x24C00000 0x0 0x4000000>; > > > + reusable; > > > + }; > > > + ... > > > + }; > > > + > > > + cma_heap { > > > + compatible = "dmabuf-heap-cma"; > > > + memory-region = <&cma_camera>; > > > > Why the indirection here? Can't you just add a flag property to > > reserved-memory nodes like we do to flag CMA nodes? > > Happy to try. Do you mean like with the "reuasable" tag? Or more like > the "linux,cma-default" tag? Probably like "linux,cma-default" as it is a hint for who to manage it rather than a characteristic of the region. > Do you have a preference for the flag name here? Not really. > > As I suspected, it's because in patch 2 you're just abusing DT to > > instantiate platform devices. We already support binding drivers to > > reserved-memory nodes directly. > > Sorry, one of those "when all you know how to do is hammer, everything > looks like a nail" issues. > Is there a specific example for binding drivers to reserved-memory > nodes I can try to follow? ramoops and I think there's a QCom driver. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464C0C47E49 for ; Wed, 30 Oct 2019 13:29:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27927217D9 for ; Wed, 30 Oct 2019 13:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27927217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 827156E9E1; Wed, 30 Oct 2019 13:29:35 +0000 (UTC) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9965C6E9E1 for ; Wed, 30 Oct 2019 13:29:34 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id z6so2111417otb.2 for ; Wed, 30 Oct 2019 06:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2PIp3nuujjbVDTCQlERuQPPmNS4hMz6vAUUQvwn05Tc=; b=FPLvmstzQsrgo24soyrObkc9YrsROlC1IF4n6f6eKXdB8bND3awLRmsURwB80c/UNy H6UZ6N2xoE9tacsIlQZyUidoC8+ySssNuDsjhsuQ5TCf/FOWuqJ7S2qxCGRobbK9BWi3 1/rELVM+0AjJa0hzXl0k8xFj+mS91icNm2XiHZLX5ub5+303pEt63ObYEJxjY3p42CS7 nFFp3xcbyxvuYvfc8tT1vVySfdfTS2t0YbFyH37GcUNYMdM8hz1E664E4B7GiE/PFPAm NwnolvgMpAAHNNrtiAI2A10QN8GMFPaU7kiqgsueOtt7J7JMd59ZAEEVLDTaysovcCYu nKOg== X-Gm-Message-State: APjAAAX/ZmaJssFbDSEC7wwNJh8rF8eeIdNXJZfkCgcWjtAAdCVGmYla U6/5Hi2F0ic2utTfDrgp4Q== X-Google-Smtp-Source: APXvYqxZ/cduY/57uFpVQbDA+dzUHNgNL7l4CUKcqiu/GlyrSfqJ4CfvFx7pOS+ityjeM2CS6IH5vA== X-Received: by 2002:a05:6830:1e65:: with SMTP id m5mr13647806otr.41.1572442173786; Wed, 30 Oct 2019 06:29:33 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id u1sm9804oie.37.2019.10.30.06.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 06:29:33 -0700 (PDT) Date: Wed, 30 Oct 2019 08:29:32 -0500 From: Rob Herring To: John Stultz Subject: Re: [RFC][PATCH 1/3] dt-bindings: dma-buf: heaps: Describe CMA regions to be added to dmabuf heaps interface. Message-ID: <20191030132932.GA7292@bogus> References: <20191025225009.50305-1-john.stultz@linaro.org> <20191025225009.50305-2-john.stultz@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Rob Herring , Sandeep Patil , Chenbo Feng , lkml , Liam Mark , Alistair Strachan , dri-devel , "Andrew F . Davis" , Hridya Valsaraju , Pratik Patel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191030132932.7IgFXRLYhDahsFO0nb4O2aWFKdJ1e2gBF6uSqC4U3yU@z> T24gRnJpLCBPY3QgMjUsIDIwMTkgYXQgMDQ6NTU6MzVQTSAtMDcwMCwgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gRnJpLCBPY3QgMjUsIDIwMTkgYXQgNDozMiBQTSBSb2IgSGVycmluZyA8cm9iLmUu aGVycmluZ0BnbWFpbC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgT2N0IDI1LCAyMDE5IGF0 IDU6NTEgUE0gSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+IHdyb3RlOgo+ID4g Pgo+ID4gPiBUaGlzIGJpbmRpbmcgc3BlY2lmaWVzIHdoaWNoIENNQSByZWdpb25zIHNob3VsZCBi ZSBhZGRlZCB0byB0aGUKPiA+ID4gZG1hYnVmIGhlYXBzIGludGVyZmFjZS4KPiA+Cj4gPiBJcyB0 aGlzIGFuIElPTiBEVCBiaW5kaW5nIGluIGRpc2d1aXNlPyBJIHRob3VnaHQgSSBraWxsZWQgdGhh dC4gOykKPiAKPiBNYXliZT8gSSBtYXkgbm90IGhhdmUgYmVlbiBwYXlpbmcgYXR0ZW50aW9uIGJh Y2sgdGhlbi4gIDopCj4gCj4gPiA+ICtFeGFtcGxlOgo+ID4gPiArVGhpcyBleGFtcGxlIGhhcyBh IGNhbWVyYSBDTUEgbm9kZSBpbiByZXNlcnZlZCBtZW1vcnksIHdoaWNoIGlzIHRoZW4KPiA+ID4g K3JlZmVyZW5jZWQgYnkgdGhlIGRtYWJ1Zi1oZWFwLWNtYSBub2RlLgo+ID4gPiArCj4gPiA+ICsK PiA+ID4gKyAgICAgICByZXNlcnZlZC1tZW1vcnkgewo+ID4gPiArICAgICAgICAgICAgICAgI2Fk ZHJlc3MtY2VsbHMgPSA8Mj47Cj4gPiA+ICsgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwy PjsKPiA+ID4gKyAgICAgICAgICAgICAgIHJhbmdlczsKPiA+ID4gKyAgICAgICAgICAgICAgIC4u Lgo+ID4gPiArICAgICAgICAgICAgICAgY21hX2NhbWVyYTogY21hLWNhbWVyYSB7Cj4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAic2hhcmVkLWRtYS1wb29sIjsKPiA+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MCAweDI0QzAwMDAwIDB4MCAweDQw MDAwMDA+Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICByZXVzYWJsZTsKPiA+ID4gKyAg ICAgICAgICAgICAgIH07Cj4gPiA+ICsgICAgICAgICAgICAgICAuLi4KPiA+ID4gKyAgICAgICB9 Owo+ID4gPiArCj4gPiA+ICsgICAgICAgY21hX2hlYXAgewo+ID4gPiArICAgICAgICAgICAgICAg Y29tcGF0aWJsZSA9ICJkbWFidWYtaGVhcC1jbWEiOwo+ID4gPiArICAgICAgICAgICAgICAgbWVt b3J5LXJlZ2lvbiA9IDwmY21hX2NhbWVyYT47Cj4gPgo+ID4gV2h5IHRoZSBpbmRpcmVjdGlvbiBo ZXJlPyBDYW4ndCB5b3UganVzdCBhZGQgYSBmbGFnIHByb3BlcnR5IHRvCj4gPiByZXNlcnZlZC1t ZW1vcnkgbm9kZXMgbGlrZSB3ZSBkbyB0byBmbGFnIENNQSBub2Rlcz8KPiAKPiBIYXBweSB0byB0 cnkuIERvIHlvdSBtZWFuIGxpa2Ugd2l0aCB0aGUgInJldWFzYWJsZSIgdGFnPyAgT3IgbW9yZSBs aWtlCj4gdGhlICJsaW51eCxjbWEtZGVmYXVsdCIgdGFnPwoKUHJvYmFibHkgbGlrZSAibGludXgs Y21hLWRlZmF1bHQiIGFzIGl0IGlzIGEgaGludCBmb3Igd2hvIHRvIG1hbmFnZSBpdCAKcmF0aGVy IHRoYW4gYSBjaGFyYWN0ZXJpc3RpYyBvZiB0aGUgcmVnaW9uLgogCj4gRG8geW91IGhhdmUgYSBw cmVmZXJlbmNlIGZvciB0aGUgZmxhZyBuYW1lIGhlcmU/CgpOb3QgcmVhbGx5LgoKCj4gPiBBcyBJ IHN1c3BlY3RlZCwgaXQncyBiZWNhdXNlIGluIHBhdGNoIDIgeW91J3JlIGp1c3QgYWJ1c2luZyBE VCB0bwo+ID4gaW5zdGFudGlhdGUgcGxhdGZvcm0gZGV2aWNlcy4gV2UgYWxyZWFkeSBzdXBwb3J0 IGJpbmRpbmcgZHJpdmVycyB0bwo+ID4gcmVzZXJ2ZWQtbWVtb3J5IG5vZGVzIGRpcmVjdGx5Lgo+ IAo+IFNvcnJ5LCBvbmUgb2YgdGhvc2UgIndoZW4gYWxsIHlvdSBrbm93IGhvdyB0byBkbyBpcyBo YW1tZXIsIGV2ZXJ5dGhpbmcKPiBsb29rcyBsaWtlIGEgbmFpbCIgaXNzdWVzLgo+IElzIHRoZXJl IGEgc3BlY2lmaWMgZXhhbXBsZSBmb3IgYmluZGluZyBkcml2ZXJzIHRvIHJlc2VydmVkLW1lbW9y eQo+IG5vZGVzIEkgY2FuIHRyeSB0byBmb2xsb3c/CgpyYW1vb3BzIGFuZCBJIHRoaW5rIHRoZXJl J3MgYSBRQ29tIGRyaXZlci4KClJvYgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw=