From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [CI 01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. Date: Wed, 30 Oct 2019 15:37:04 +0200 Message-ID: <20191030133704.GI1208@intel.com> References: <20191029072229.27092-1-maarten.lankhorst@linux.intel.com> <20191029183557.GE1208@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5B406E9EA for ; Wed, 30 Oct 2019 13:37:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMzAsIDIwMTkgYXQgMTA6MTc6NTJBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjktMTAtMjAxOSBvbSAxOTozNSBzY2hyZWVmIFZpbGxlIFN5cmrDpGzD pDoKPiA+IE9uIFR1ZSwgT2N0IDI5LCAyMDE5IGF0IDA4OjIyOjE4QU0gKzAxMDAsIE1hYXJ0ZW4g TGFua2hvcnN0IHdyb3RlOgo+ID4+IFVzZSB0aGlzIGluIGFsbCB0aGUgcGxhY2VzIHdoZXJlIHdl IHRyeSB0byBhY3F1aXJlIHBsYW5lcyBhZnRlciB0aGUgcGxhbmVzCj4gPj4gYXRvbWljX2NoZWNr KCkuCj4gPj4KPiA+PiBJbiBjYXNlIG9mIGludGVsX21vZGVzZXRfYWxsX3BpcGVzKCkgdGhpcyBp cyBub3QgeWV0IGRvbmUgYWZ0ZXIgYXRvbWljX2NoZWNrLAo+ID4+IGJ1dCBzZWVtcyBsaWtlIGl0 IHdpbGwgYmUgaW4gdGhlIGZ1dHVyZS4gVG8gYWRkIHNvbWUgcGFyYW5vaWEsIGFkZCBhbGwgcGxh bmVzCj4gPj4gcmF0aGVyIHRoYW4gYWN0aXZlIHBsYW5lcywgYmVjYXVzZSBvZiBiaWdqb2luZXIg YW5kIHBsYW5hciBZVVYgc3VwcG9ydCBoYXZpbmcKPiA+PiBleHRyYSBwbGFuZXMgb3V0c2lkZSBv ZiB0aGUgY29yZSdzIHZpZXcgdGhhdCB3b3VsZG4ndCBiZSBhZGRlZCBvdGhlcndpc2UuCj4gPj4K PiA+PiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4+IC0gQWx3YXlzIGFkZCBhbGwgcGxhbmVzLCB0byBo YW5kbGUgZm9yY2UgcGxhbmUgdXBkYXRlcyB0byB3b3JrIGNvcnJlY3RseQo+ID4+ICAgd2l0aCBh IGRpc2FibGVkIGN1cnNvciBwbGFuZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4gLS0tCj4g Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWljLmMgICB8IDQxICsr KysrKysrKy0tLS0tLS0tLS0KPiA+PiAgLi4uL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0 b21pY19wbGFuZS5jIHwgMTUgKysrKysrKwo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2NkY2xrLmMgICAgfCAxNSArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfY29sb3IuYyAgICB8ICA3ICsrLS0KPiA+PiAgLi4uL2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV90eXBlcy5oICAgIHwgIDYgKysrCj4gPj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMgICAgICAgICAgICAgICB8IDE0ICsrKystLS0KPiA+PiAg NiBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPiA+Pgo+ ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21p Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWMuYwo+ID4+IGlu ZGV4IDljZDZkMjM0OGExZS4uODBkZjZjMjMzNTgxIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWljLmMKPiA+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pYy5jCj4gPj4gQEAgLTMxMywxMyArMzEzLDEw IEBAIGludCBpbnRlbF9hdG9taWNfc2V0dXBfc2NhbGVycyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gPj4gIAkJCSAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0 YywKPiA+PiAgCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ ID4+ICB7Cj4gPj4gLQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9IE5VTEw7Cj4gPj4gLQlzdHJ1 Y3QgaW50ZWxfcGxhbmUgKmludGVsX3BsYW5lOwo+ID4+IC0Jc3RydWN0IGludGVsX3BsYW5lX3N0 YXRlICpwbGFuZV9zdGF0ZSA9IE5VTEw7Cj4gPj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zY2FsZXJf c3RhdGUgKnNjYWxlcl9zdGF0ZSA9Cj4gPj4gIAkJJmNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZTsK PiA+PiAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpkcm1fc3RhdGUgPSBjcnRjX3N0YXRlLT5i YXNlLnN0YXRlOwo+ID4+IC0Jc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUg PSB0b19pbnRlbF9hdG9taWNfc3RhdGUoZHJtX3N0YXRlKTsKPiA+PiArCXN0cnVjdCBpbnRlbF9h dG9taWNfc3RhdGUgKnN0YXRlID0gdG9faW50ZWxfYXRvbWljX3N0YXRlKGRybV9zdGF0ZSk7Cj4g Pj4gIAlpbnQgbnVtX3NjYWxlcnNfbmVlZDsKPiA+PiAgCWludCBpOwo+ID4+ICAKPiA+PiBAQCAt MzQ2LDYgKzM0Myw3IEBAIGludCBpbnRlbF9hdG9taWNfc2V0dXBfc2NhbGVycyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPj4gIAo+ID4+ICAJLyogd2Fsa3Rocm91Z2ggc2Nh bGVyX3VzZXJzIGJpdHMgYW5kIHN0YXJ0IGFzc2lnbmluZyBzY2FsZXJzICovCj4gPj4gIAlmb3Ig KGkgPSAwOyBpIDwgc2l6ZW9mKHNjYWxlcl9zdGF0ZS0+c2NhbGVyX3VzZXJzKSAqIDg7IGkrKykg ewo+ID4+ICsJCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPSBOVUxMOwo+ ID4+ICAJCWludCAqc2NhbGVyX2lkOwo+ID4+ICAJCWNvbnN0IGNoYXIgKm5hbWU7Cj4gPj4gIAkJ aW50IGlkeDsKPiA+PiBAQCAtMzYxLDE5ICszNTksMTYgQEAgaW50IGludGVsX2F0b21pY19zZXR1 cF9zY2FsZXJzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+PiAgCQkJLyog cGFuZWwgZml0dGVyIGNhc2U6IGFzc2lnbiBhcyBhIGNydGMgc2NhbGVyICovCj4gPj4gIAkJCXNj YWxlcl9pZCA9ICZzY2FsZXJfc3RhdGUtPnNjYWxlcl9pZDsKPiA+PiAgCQl9IGVsc2Ugewo+ID4+ IC0JCQluYW1lID0gIlBMQU5FIjsKPiA+PiArCQkJc3RydWN0IGludGVsX3BsYW5lICpwbGFuZTsK PiA+PiAgCj4gPj4gIAkJCS8qIHBsYW5lIHNjYWxlciBjYXNlOiBhc3NpZ24gYXMgYSBwbGFuZSBz Y2FsZXIgKi8KPiA+PiAgCQkJLyogZmluZCB0aGUgcGxhbmUgdGhhdCBzZXQgdGhlIGJpdCBhcyBz Y2FsZXJfdXNlciAqLwo+ID4+IC0JCQlwbGFuZSA9IGRybV9zdGF0ZS0+cGxhbmVzW2ldLnB0cjsK PiA+PiAgCj4gPj4gIAkJCS8qCj4gPj4gIAkJCSAqIHRvIGVuYWJsZS9kaXNhYmxlIGhxIG1vZGUs IGFkZCBwbGFuZXMgdGhhdCBhcmUgdXNpbmcgc2NhbGVyCj4gPj4gIAkJCSAqIGludG8gdGhpcyB0 cmFuc2FjdGlvbgo+ID4+ICAJCQkgKi8KPiA+PiAtCQkJaWYgKCFwbGFuZSkgewo+ID4+IC0JCQkJ c3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGU7Cj4gPj4gLQo+ID4+ICsJCQlpZiAoIWRybV9z dGF0ZS0+cGxhbmVzW2ldLnB0cikgewo+ID4+ICAJCQkJLyoKPiA+PiAgCQkJCSAqIEdMSysgc2Nh bGVycyBkb24ndCBoYXZlIGEgSFEgbW9kZSBzbyBpdAo+ID4+ICAJCQkJICogaXNuJ3QgbmVjZXNz YXJ5IHRvIGNoYW5nZSBiZXR3ZWVuIEhRIGFuZCBkeW4gbW9kZQo+ID4+IEBAIC0zODIsMjQgKzM3 NywyOCBAQCBpbnQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ID4+ICAJCQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTAg fHwgSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpCj4gPj4gIAkJCQkJY29udGludWU7Cj4gPj4gIAo+ ID4+IC0JCQkJcGxhbmUgPSBkcm1fcGxhbmVfZnJvbV9pbmRleCgmZGV2X3ByaXYtPmRybSwgaSk7 Cj4gPj4gLQkJCQlzdGF0ZSA9IGRybV9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlKGRybV9zdGF0ZSwg cGxhbmUpOwo+ID4+IC0JCQkJaWYgKElTX0VSUihzdGF0ZSkpIHsKPiA+PiAtCQkJCQlEUk1fREVC VUdfS01TKCJGYWlsZWQgdG8gYWRkIFtQTEFORTolZF0gdG8gZHJtX3N0YXRlXG4iLAo+ID4+IC0J CQkJCQlwbGFuZS0+YmFzZS5pZCk7Cj4gPj4gLQkJCQkJcmV0dXJuIFBUUl9FUlIoc3RhdGUpOwo+ ID4+ICsJCQkJcGxhbmUgPSB0b19pbnRlbF9wbGFuZShkcm1fcGxhbmVfZnJvbV9pbmRleCgmZGV2 X3ByaXYtPmRybSwgaSkpOwo+ID4+ICsJCQkJcGxhbmVfc3RhdGUgPQo+ID4+ICsJCQkJCWludGVs X2F0b21pY19nZXRfcGxhbmVfc3RhdGVfYWZ0ZXJfY2hlY2soc3RhdGUsCj4gPj4gKwkJCQkJCQkJ CQkgY3J0Y19zdGF0ZSwKPiA+PiArCQkJCQkJCQkJCSBwbGFuZSk7Cj4gPj4gKwkJCQlpZiAoSVNf RVJSKHBsYW5lX3N0YXRlKSkgewo+ID4+ICsJCQkJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byBh ZGQgW1BMQU5FOiVkXSB0byBkcm1fc3RhdGU6ICVsaVxuIiwKPiA+PiArCQkJCQkJcGxhbmUtPmJh c2UuYmFzZS5pZCwgUFRSX0VSUihwbGFuZV9zdGF0ZSkpOwo+ID4+ICsJCQkJCXJldHVybiBQVFJf RVJSKHBsYW5lX3N0YXRlKTsKPiA+PiAgCQkJCX0KPiA+PiArCQkJfSBlbHNlIHsKPiA+PiArCQkJ CXBsYW5lID0gdG9faW50ZWxfcGxhbmUoZHJtX3N0YXRlLT5wbGFuZXNbaV0ucHRyKTsKPiA+PiAr CQkJCXBsYW5lX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RhdGUs Cj4gPj4gKwkJCQkJCQkJCSAgICAgICBwbGFuZSk7Cj4gPj4gIAkJCX0KPiA+PiAgCj4gPj4gLQkJ CWludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOwo+ID4+IC0JCQlpZHggPSBwbGFu ZS0+YmFzZS5pZDsKPiA+PiAtCj4gPj4gIAkJCS8qIHBsYW5lIG9uIGRpZmZlcmVudCBjcnRjIGNh bm5vdCBiZSBhIHNjYWxlciB1c2VyIG9mIHRoaXMgY3J0YyAqLwo+ID4+IC0JCQlpZiAoV0FSTl9P TihpbnRlbF9wbGFuZS0+cGlwZSAhPSBpbnRlbF9jcnRjLT5waXBlKSkKPiA+PiArCQkJaWYgKFdB Uk5fT04ocGxhbmUtPnBpcGUgIT0gaW50ZWxfY3J0Yy0+cGlwZSkpCj4gPj4gIAkJCQljb250aW51 ZTsKPiA+PiAgCj4gPj4gLQkJCXBsYW5lX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9uZXdfcGxh bmVfc3RhdGUoaW50ZWxfc3RhdGUsCj4gPj4gLQkJCQkJCQkJICAgICAgIGludGVsX3BsYW5lKTsK PiA+PiArCQkJbmFtZSA9ICJQTEFORSI7Cj4gPj4gKwkJCWlkeCA9IHBsYW5lLT5iYXNlLmJhc2Uu aWQ7Cj4gPj4gIAkJCXNjYWxlcl9pZCA9ICZwbGFuZV9zdGF0ZS0+c2NhbGVyX2lkOwo+ID4+ICAJ CX0KPiA+PiAgCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfYXRvbWljX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs X2F0b21pY19wbGFuZS5jCj4gPj4gaW5kZXggOThmNTU3YTlmOGVlLi5hOWUyNjg0YzZiNmQgMTAw NjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWNf cGxhbmUuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRv bWljX3BsYW5lLmMKPiA+PiBAQCAtNDAyLDYgKzQwMiwyMSBAQCB2b2lkIGk5eHhfdXBkYXRlX3Bs YW5lc19vbl9jcnRjKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4+ICAJfQo+ ID4+ICB9Cj4gPj4gIAo+ID4+ICtzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKgo+ID4+ICtpbnRl bF9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlX2FmdGVyX2NoZWNrKHN0cnVjdCBpbnRlbF9hdG9taWNf c3RhdGUgKnN0YXRlLAo+ID4+ICsJCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2Ny dGNfc3RhdGUsCj4gPj4gKwkJCQkJIHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUpCj4gPj4gK3sK PiA+PiArCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPQo+ID4+ICsJCWlu dGVsX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiA+PiArCj4gPj4gKwlp ZiAoSVNfRVJSKHBsYW5lX3N0YXRlKSkKPiA+PiArCQlyZXR1cm4gcGxhbmVfc3RhdGU7Cj4gPj4g Kwo+ID4+ICsJbmV3X2NydGNfc3RhdGUtPnVwZGF0ZV9wbGFuZXMgfD0gQklUKHBsYW5lLT5pZCk7 Cj4gPj4gKwlyZXR1cm4gcGxhbmVfc3RhdGU7Cj4gPj4gK30KPiA+IFdpdGggdGhlIGh3IHN0YXRl IGJlaW5nIHBlcnNpc3RlbnQgbm93IEkgZ3Vlc3Mgd2UgZG9uJ3QgbmVlZCB0aGlzCj4gPiBhbnlt b3JlPwo+IAo+IFllcywgaXQgd291bGQgc3RpbCBiZSB1c2VmdWwgZm9yIGFubm90YXRpb24gdGhv dWdoLiA6KQoKVG8gbWUgaXQgc2VlbXMgdG8ganVzdCBoaWRlIHRoaW5ncyAodGhlIHVwZGF0ZV9w bGFuZXMgYml0bWFzawphZGp1c3RtZW50KSwgc28gaXQncyBub3QgYXQgYWxsIG92YnZpb3VzIGZv ciB0aGUgcmVhZGVyIHRoYXQKY2FsbGluZyB0aGlzIHdpbGwgcmVzdWx0IGluIHRoZSBwbGFuZSBy ZWdpc3RlcnMgcmVhbGx5IGdldHRpbmcKcHJvZ3JhbW1lZC4KCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00550CA9EC5 for ; Wed, 30 Oct 2019 13:37:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC2C120659 for ; Wed, 30 Oct 2019 13:37:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC2C120659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6027F6E9EA; Wed, 30 Oct 2019 13:37:10 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5B406E9EA for ; Wed, 30 Oct 2019 13:37:08 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:37:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="190278846" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 30 Oct 2019 06:37:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 30 Oct 2019 15:37:04 +0200 Date: Wed, 30 Oct 2019 15:37:04 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maarten Lankhorst Message-ID: <20191030133704.GI1208@intel.com> References: <20191029072229.27092-1-maarten.lankhorst@linux.intel.com> <20191029183557.GE1208@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [CI 01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191030133704.AjFfggiRRlE2abOUmXCgdFmXq9uqVyMPOrM9y9QLE4I@z> T24gV2VkLCBPY3QgMzAsIDIwMTkgYXQgMTA6MTc6NTJBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjktMTAtMjAxOSBvbSAxOTozNSBzY2hyZWVmIFZpbGxlIFN5cmrDpGzD pDoKPiA+IE9uIFR1ZSwgT2N0IDI5LCAyMDE5IGF0IDA4OjIyOjE4QU0gKzAxMDAsIE1hYXJ0ZW4g TGFua2hvcnN0IHdyb3RlOgo+ID4+IFVzZSB0aGlzIGluIGFsbCB0aGUgcGxhY2VzIHdoZXJlIHdl IHRyeSB0byBhY3F1aXJlIHBsYW5lcyBhZnRlciB0aGUgcGxhbmVzCj4gPj4gYXRvbWljX2NoZWNr KCkuCj4gPj4KPiA+PiBJbiBjYXNlIG9mIGludGVsX21vZGVzZXRfYWxsX3BpcGVzKCkgdGhpcyBp cyBub3QgeWV0IGRvbmUgYWZ0ZXIgYXRvbWljX2NoZWNrLAo+ID4+IGJ1dCBzZWVtcyBsaWtlIGl0 IHdpbGwgYmUgaW4gdGhlIGZ1dHVyZS4gVG8gYWRkIHNvbWUgcGFyYW5vaWEsIGFkZCBhbGwgcGxh bmVzCj4gPj4gcmF0aGVyIHRoYW4gYWN0aXZlIHBsYW5lcywgYmVjYXVzZSBvZiBiaWdqb2luZXIg YW5kIHBsYW5hciBZVVYgc3VwcG9ydCBoYXZpbmcKPiA+PiBleHRyYSBwbGFuZXMgb3V0c2lkZSBv ZiB0aGUgY29yZSdzIHZpZXcgdGhhdCB3b3VsZG4ndCBiZSBhZGRlZCBvdGhlcndpc2UuCj4gPj4K PiA+PiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4+IC0gQWx3YXlzIGFkZCBhbGwgcGxhbmVzLCB0byBo YW5kbGUgZm9yY2UgcGxhbmUgdXBkYXRlcyB0byB3b3JrIGNvcnJlY3RseQo+ID4+ICAgd2l0aCBh IGRpc2FibGVkIGN1cnNvciBwbGFuZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4gLS0tCj4g Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWljLmMgICB8IDQxICsr KysrKysrKy0tLS0tLS0tLS0KPiA+PiAgLi4uL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0 b21pY19wbGFuZS5jIHwgMTUgKysrKysrKwo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2NkY2xrLmMgICAgfCAxNSArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfY29sb3IuYyAgICB8ICA3ICsrLS0KPiA+PiAgLi4uL2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV90eXBlcy5oICAgIHwgIDYgKysrCj4gPj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMgICAgICAgICAgICAgICB8IDE0ICsrKystLS0KPiA+PiAg NiBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPiA+Pgo+ ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21p Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWMuYwo+ID4+IGlu ZGV4IDljZDZkMjM0OGExZS4uODBkZjZjMjMzNTgxIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWljLmMKPiA+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pYy5jCj4gPj4gQEAgLTMxMywxMyArMzEzLDEw IEBAIGludCBpbnRlbF9hdG9taWNfc2V0dXBfc2NhbGVycyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gPj4gIAkJCSAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0 YywKPiA+PiAgCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ ID4+ICB7Cj4gPj4gLQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9IE5VTEw7Cj4gPj4gLQlzdHJ1 Y3QgaW50ZWxfcGxhbmUgKmludGVsX3BsYW5lOwo+ID4+IC0Jc3RydWN0IGludGVsX3BsYW5lX3N0 YXRlICpwbGFuZV9zdGF0ZSA9IE5VTEw7Cj4gPj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zY2FsZXJf c3RhdGUgKnNjYWxlcl9zdGF0ZSA9Cj4gPj4gIAkJJmNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZTsK PiA+PiAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpkcm1fc3RhdGUgPSBjcnRjX3N0YXRlLT5i YXNlLnN0YXRlOwo+ID4+IC0Jc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUg PSB0b19pbnRlbF9hdG9taWNfc3RhdGUoZHJtX3N0YXRlKTsKPiA+PiArCXN0cnVjdCBpbnRlbF9h dG9taWNfc3RhdGUgKnN0YXRlID0gdG9faW50ZWxfYXRvbWljX3N0YXRlKGRybV9zdGF0ZSk7Cj4g Pj4gIAlpbnQgbnVtX3NjYWxlcnNfbmVlZDsKPiA+PiAgCWludCBpOwo+ID4+ICAKPiA+PiBAQCAt MzQ2LDYgKzM0Myw3IEBAIGludCBpbnRlbF9hdG9taWNfc2V0dXBfc2NhbGVycyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPj4gIAo+ID4+ICAJLyogd2Fsa3Rocm91Z2ggc2Nh bGVyX3VzZXJzIGJpdHMgYW5kIHN0YXJ0IGFzc2lnbmluZyBzY2FsZXJzICovCj4gPj4gIAlmb3Ig KGkgPSAwOyBpIDwgc2l6ZW9mKHNjYWxlcl9zdGF0ZS0+c2NhbGVyX3VzZXJzKSAqIDg7IGkrKykg ewo+ID4+ICsJCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPSBOVUxMOwo+ ID4+ICAJCWludCAqc2NhbGVyX2lkOwo+ID4+ICAJCWNvbnN0IGNoYXIgKm5hbWU7Cj4gPj4gIAkJ aW50IGlkeDsKPiA+PiBAQCAtMzYxLDE5ICszNTksMTYgQEAgaW50IGludGVsX2F0b21pY19zZXR1 cF9zY2FsZXJzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+PiAgCQkJLyog cGFuZWwgZml0dGVyIGNhc2U6IGFzc2lnbiBhcyBhIGNydGMgc2NhbGVyICovCj4gPj4gIAkJCXNj YWxlcl9pZCA9ICZzY2FsZXJfc3RhdGUtPnNjYWxlcl9pZDsKPiA+PiAgCQl9IGVsc2Ugewo+ID4+ IC0JCQluYW1lID0gIlBMQU5FIjsKPiA+PiArCQkJc3RydWN0IGludGVsX3BsYW5lICpwbGFuZTsK PiA+PiAgCj4gPj4gIAkJCS8qIHBsYW5lIHNjYWxlciBjYXNlOiBhc3NpZ24gYXMgYSBwbGFuZSBz Y2FsZXIgKi8KPiA+PiAgCQkJLyogZmluZCB0aGUgcGxhbmUgdGhhdCBzZXQgdGhlIGJpdCBhcyBz Y2FsZXJfdXNlciAqLwo+ID4+IC0JCQlwbGFuZSA9IGRybV9zdGF0ZS0+cGxhbmVzW2ldLnB0cjsK PiA+PiAgCj4gPj4gIAkJCS8qCj4gPj4gIAkJCSAqIHRvIGVuYWJsZS9kaXNhYmxlIGhxIG1vZGUs IGFkZCBwbGFuZXMgdGhhdCBhcmUgdXNpbmcgc2NhbGVyCj4gPj4gIAkJCSAqIGludG8gdGhpcyB0 cmFuc2FjdGlvbgo+ID4+ICAJCQkgKi8KPiA+PiAtCQkJaWYgKCFwbGFuZSkgewo+ID4+IC0JCQkJ c3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGU7Cj4gPj4gLQo+ID4+ICsJCQlpZiAoIWRybV9z dGF0ZS0+cGxhbmVzW2ldLnB0cikgewo+ID4+ICAJCQkJLyoKPiA+PiAgCQkJCSAqIEdMSysgc2Nh bGVycyBkb24ndCBoYXZlIGEgSFEgbW9kZSBzbyBpdAo+ID4+ICAJCQkJICogaXNuJ3QgbmVjZXNz YXJ5IHRvIGNoYW5nZSBiZXR3ZWVuIEhRIGFuZCBkeW4gbW9kZQo+ID4+IEBAIC0zODIsMjQgKzM3 NywyOCBAQCBpbnQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ID4+ICAJCQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTAg fHwgSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpCj4gPj4gIAkJCQkJY29udGludWU7Cj4gPj4gIAo+ ID4+IC0JCQkJcGxhbmUgPSBkcm1fcGxhbmVfZnJvbV9pbmRleCgmZGV2X3ByaXYtPmRybSwgaSk7 Cj4gPj4gLQkJCQlzdGF0ZSA9IGRybV9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlKGRybV9zdGF0ZSwg cGxhbmUpOwo+ID4+IC0JCQkJaWYgKElTX0VSUihzdGF0ZSkpIHsKPiA+PiAtCQkJCQlEUk1fREVC VUdfS01TKCJGYWlsZWQgdG8gYWRkIFtQTEFORTolZF0gdG8gZHJtX3N0YXRlXG4iLAo+ID4+IC0J CQkJCQlwbGFuZS0+YmFzZS5pZCk7Cj4gPj4gLQkJCQkJcmV0dXJuIFBUUl9FUlIoc3RhdGUpOwo+ ID4+ICsJCQkJcGxhbmUgPSB0b19pbnRlbF9wbGFuZShkcm1fcGxhbmVfZnJvbV9pbmRleCgmZGV2 X3ByaXYtPmRybSwgaSkpOwo+ID4+ICsJCQkJcGxhbmVfc3RhdGUgPQo+ID4+ICsJCQkJCWludGVs X2F0b21pY19nZXRfcGxhbmVfc3RhdGVfYWZ0ZXJfY2hlY2soc3RhdGUsCj4gPj4gKwkJCQkJCQkJ CQkgY3J0Y19zdGF0ZSwKPiA+PiArCQkJCQkJCQkJCSBwbGFuZSk7Cj4gPj4gKwkJCQlpZiAoSVNf RVJSKHBsYW5lX3N0YXRlKSkgewo+ID4+ICsJCQkJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byBh ZGQgW1BMQU5FOiVkXSB0byBkcm1fc3RhdGU6ICVsaVxuIiwKPiA+PiArCQkJCQkJcGxhbmUtPmJh c2UuYmFzZS5pZCwgUFRSX0VSUihwbGFuZV9zdGF0ZSkpOwo+ID4+ICsJCQkJCXJldHVybiBQVFJf RVJSKHBsYW5lX3N0YXRlKTsKPiA+PiAgCQkJCX0KPiA+PiArCQkJfSBlbHNlIHsKPiA+PiArCQkJ CXBsYW5lID0gdG9faW50ZWxfcGxhbmUoZHJtX3N0YXRlLT5wbGFuZXNbaV0ucHRyKTsKPiA+PiAr CQkJCXBsYW5lX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RhdGUs Cj4gPj4gKwkJCQkJCQkJCSAgICAgICBwbGFuZSk7Cj4gPj4gIAkJCX0KPiA+PiAgCj4gPj4gLQkJ CWludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOwo+ID4+IC0JCQlpZHggPSBwbGFu ZS0+YmFzZS5pZDsKPiA+PiAtCj4gPj4gIAkJCS8qIHBsYW5lIG9uIGRpZmZlcmVudCBjcnRjIGNh bm5vdCBiZSBhIHNjYWxlciB1c2VyIG9mIHRoaXMgY3J0YyAqLwo+ID4+IC0JCQlpZiAoV0FSTl9P TihpbnRlbF9wbGFuZS0+cGlwZSAhPSBpbnRlbF9jcnRjLT5waXBlKSkKPiA+PiArCQkJaWYgKFdB Uk5fT04ocGxhbmUtPnBpcGUgIT0gaW50ZWxfY3J0Yy0+cGlwZSkpCj4gPj4gIAkJCQljb250aW51 ZTsKPiA+PiAgCj4gPj4gLQkJCXBsYW5lX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9uZXdfcGxh bmVfc3RhdGUoaW50ZWxfc3RhdGUsCj4gPj4gLQkJCQkJCQkJICAgICAgIGludGVsX3BsYW5lKTsK PiA+PiArCQkJbmFtZSA9ICJQTEFORSI7Cj4gPj4gKwkJCWlkeCA9IHBsYW5lLT5iYXNlLmJhc2Uu aWQ7Cj4gPj4gIAkJCXNjYWxlcl9pZCA9ICZwbGFuZV9zdGF0ZS0+c2NhbGVyX2lkOwo+ID4+ICAJ CX0KPiA+PiAgCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfYXRvbWljX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs X2F0b21pY19wbGFuZS5jCj4gPj4gaW5kZXggOThmNTU3YTlmOGVlLi5hOWUyNjg0YzZiNmQgMTAw NjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWNf cGxhbmUuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRv bWljX3BsYW5lLmMKPiA+PiBAQCAtNDAyLDYgKzQwMiwyMSBAQCB2b2lkIGk5eHhfdXBkYXRlX3Bs YW5lc19vbl9jcnRjKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4+ICAJfQo+ ID4+ICB9Cj4gPj4gIAo+ID4+ICtzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKgo+ID4+ICtpbnRl bF9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlX2FmdGVyX2NoZWNrKHN0cnVjdCBpbnRlbF9hdG9taWNf c3RhdGUgKnN0YXRlLAo+ID4+ICsJCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2Ny dGNfc3RhdGUsCj4gPj4gKwkJCQkJIHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUpCj4gPj4gK3sK PiA+PiArCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPQo+ID4+ICsJCWlu dGVsX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiA+PiArCj4gPj4gKwlp ZiAoSVNfRVJSKHBsYW5lX3N0YXRlKSkKPiA+PiArCQlyZXR1cm4gcGxhbmVfc3RhdGU7Cj4gPj4g Kwo+ID4+ICsJbmV3X2NydGNfc3RhdGUtPnVwZGF0ZV9wbGFuZXMgfD0gQklUKHBsYW5lLT5pZCk7 Cj4gPj4gKwlyZXR1cm4gcGxhbmVfc3RhdGU7Cj4gPj4gK30KPiA+IFdpdGggdGhlIGh3IHN0YXRl IGJlaW5nIHBlcnNpc3RlbnQgbm93IEkgZ3Vlc3Mgd2UgZG9uJ3QgbmVlZCB0aGlzCj4gPiBhbnlt b3JlPwo+IAo+IFllcywgaXQgd291bGQgc3RpbCBiZSB1c2VmdWwgZm9yIGFubm90YXRpb24gdGhv dWdoLiA6KQoKVG8gbWUgaXQgc2VlbXMgdG8ganVzdCBoaWRlIHRoaW5ncyAodGhlIHVwZGF0ZV9w bGFuZXMgYml0bWFzawphZGp1c3RtZW50KSwgc28gaXQncyBub3QgYXQgYWxsIG92YnZpb3VzIGZv ciB0aGUgcmVhZGVyIHRoYXQKY2FsbGluZyB0aGlzIHdpbGwgcmVzdWx0IGluIHRoZSBwbGFuZSBy ZWdpc3RlcnMgcmVhbGx5IGdldHRpbmcKcHJvZ3JhbW1lZC4KCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4