From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 357CBCA9EC5 for ; Wed, 30 Oct 2019 13:51:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 320A920874 for ; Wed, 30 Oct 2019 13:51:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="UDXtMas5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320A920874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D0EF81F68; Wed, 30 Oct 2019 14:50:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D0EF81F68 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572443471; bh=V+5rm9+vcdAn6bqhKfVULBxHLzeK3vf4f/zBd/ZRxZ0=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UDXtMas5h8rYADiiucpRkmJM7zhfat2LoMHtCy+Ugliqr5ZA1sOplbsk6dfbp8A1R 8zfaeU4fZzVbUYRQK68MxygP6z092nbkO0MA8KR0g8wgVNIw3FzHiA2oMt0Cns9/xu QyLda79H2lvbOfxUhaS7WnfmkFZvutEsnidjcXJU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 60FE6F802BD; Wed, 30 Oct 2019 14:50:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5F632F80361; Wed, 30 Oct 2019 14:50:19 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A4EF7F802A1 for ; Wed, 30 Oct 2019 14:50:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A4EF7F802A1 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:50:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="198682225" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 30 Oct 2019 06:50:10 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 30 Oct 2019 15:50:09 +0200 Date: Wed, 30 Oct 2019 15:50:09 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Takashi Iwai Message-ID: <20191030135009.GJ1208@intel.com> References: <20191029191050.GF1208@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org Subject: Re: [alsa-devel] pcm_lock deadlock X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Oct 29, 2019 at 09:52:57PM +0100, Takashi Iwai wrote: > On Tue, 29 Oct 2019 20:10:50 +0100, > From: Takashi Iwai > Subject: [PATCH] ALSA: hda - Fix mutex deadlock in HDMI codec driver > = > The commit ade49db337a9 ("ALSA: hda/hdmi - Allow audio component for > AMD/ATI and Nvidia HDMI") introduced the spec->pcm_lock mutex lock to > the whole generic_hdmi_init() function for avoiding the race with the > audio component registration. However, this caused a dead lock when > the unsolicited event is handled without the audio component, as the > codec gets runtime-resumed in hdmi_present_sense() which is already > inside the spec->pcm_lock in its caller. > = > For avoiding this deadlock, add a new mutex only for the audio > component binding that is used in both generic_hdmi_init() and the > audio notifier registration where the jack callbacks are handled / > re-registered. > = > Fixes: ade49db337a9 ("ALSA: hda/hdmi - Allow audio component for AMD/ATI = and Nvidia HDMI") > Reported-by: Ville Syrj=E4l=E4 > Signed-off-by: Takashi Iwai > --- > sound/pci/hda/patch_hdmi.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > = > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 795cbda32cbb..d9b5ba361409 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -145,6 +145,7 @@ struct hdmi_spec { > struct snd_array pins; /* struct hdmi_spec_per_pin */ > struct hdmi_pcm pcm_rec[16]; > struct mutex pcm_lock; > + struct mutex bind_lock; /* for audio component binding */ Missing mutex_init() for this guy. Tested-by: Ville Syrj=E4l=E4 > /* pcm_bitmap means which pcms have been assigned to pins*/ > unsigned long pcm_bitmap; > int pcm_used; /* counter of pcm_rec[] */ > @@ -2258,7 +2259,7 @@ static int generic_hdmi_init(struct hda_codec *code= c) > struct hdmi_spec *spec =3D codec->spec; > int pin_idx; > = > - mutex_lock(&spec->pcm_lock); > + mutex_lock(&spec->bind_lock); > spec->use_jack_detect =3D !codec->jackpoll_interval; > for (pin_idx =3D 0; pin_idx < spec->num_pins; pin_idx++) { > struct hdmi_spec_per_pin *per_pin =3D get_pin(spec, pin_idx); > @@ -2275,7 +2276,7 @@ static int generic_hdmi_init(struct hda_codec *code= c) > snd_hda_jack_detect_enable_callback(codec, pin_nid, > jack_callback); > } > - mutex_unlock(&spec->pcm_lock); > + mutex_unlock(&spec->bind_lock); > return 0; > } > = > @@ -2451,7 +2452,7 @@ static void generic_acomp_notifier_set(struct drm_a= udio_component *acomp, > int i; > = > spec =3D container_of(acomp->audio_ops, struct hdmi_spec, drm_audio_ops= ); > - mutex_lock(&spec->pcm_lock); > + mutex_lock(&spec->bind_lock); > spec->use_acomp_notifier =3D use_acomp; > spec->codec->relaxed_resume =3D use_acomp; > /* reprogram each jack detection logic depending on the notifier */ > @@ -2461,7 +2462,7 @@ static void generic_acomp_notifier_set(struct drm_a= udio_component *acomp, > get_pin(spec, i)->pin_nid, > use_acomp); > } > - mutex_unlock(&spec->pcm_lock); > + mutex_unlock(&spec->bind_lock); > } > = > /* enable / disable the notifier via master bind / unbind */ > -- = > 2.16.4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: pcm_lock deadlock Date: Wed, 30 Oct 2019 15:50:09 +0200 Message-ID: <20191030135009.GJ1208@intel.com> References: <20191029191050.GF1208@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A08426E9FA for ; Wed, 30 Oct 2019 13:50:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Takashi Iwai Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjksIDIwMTkgYXQgMDk6NTI6NTdQTSArMDEwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgo+IE9uIFR1ZSwgMjkgT2N0IDIwMTkgMjA6MTA6NTAgKzAxMDAsCj4gRnJvbTogVGFrYXNo aSBJd2FpIDx0aXdhaUBzdXNlLmRlPgo+IFN1YmplY3Q6IFtQQVRDSF0gQUxTQTogaGRhIC0gRml4 IG11dGV4IGRlYWRsb2NrIGluIEhETUkgY29kZWMgZHJpdmVyCj4gCj4gVGhlIGNvbW1pdCBhZGU0 OWRiMzM3YTkgKCJBTFNBOiBoZGEvaGRtaSAtIEFsbG93IGF1ZGlvIGNvbXBvbmVudCBmb3IKPiBB TUQvQVRJIGFuZCBOdmlkaWEgSERNSSIpIGludHJvZHVjZWQgdGhlIHNwZWMtPnBjbV9sb2NrIG11 dGV4IGxvY2sgdG8KPiB0aGUgd2hvbGUgZ2VuZXJpY19oZG1pX2luaXQoKSBmdW5jdGlvbiBmb3Ig YXZvaWRpbmcgdGhlIHJhY2Ugd2l0aCB0aGUKPiBhdWRpbyBjb21wb25lbnQgcmVnaXN0cmF0aW9u LiAgSG93ZXZlciwgdGhpcyBjYXVzZWQgYSBkZWFkIGxvY2sgd2hlbgo+IHRoZSB1bnNvbGljaXRl ZCBldmVudCBpcyBoYW5kbGVkIHdpdGhvdXQgdGhlIGF1ZGlvIGNvbXBvbmVudCwgYXMgdGhlCj4g Y29kZWMgZ2V0cyBydW50aW1lLXJlc3VtZWQgaW4gaGRtaV9wcmVzZW50X3NlbnNlKCkgd2hpY2gg aXMgYWxyZWFkeQo+IGluc2lkZSB0aGUgc3BlYy0+cGNtX2xvY2sgaW4gaXRzIGNhbGxlci4KPiAK PiBGb3IgYXZvaWRpbmcgdGhpcyBkZWFkbG9jaywgYWRkIGEgbmV3IG11dGV4IG9ubHkgZm9yIHRo ZSBhdWRpbwo+IGNvbXBvbmVudCBiaW5kaW5nIHRoYXQgaXMgdXNlZCBpbiBib3RoIGdlbmVyaWNf aGRtaV9pbml0KCkgYW5kIHRoZQo+IGF1ZGlvIG5vdGlmaWVyIHJlZ2lzdHJhdGlvbiB3aGVyZSB0 aGUgamFjayBjYWxsYmFja3MgYXJlIGhhbmRsZWQgLwo+IHJlLXJlZ2lzdGVyZWQuCj4gCj4gRml4 ZXM6IGFkZTQ5ZGIzMzdhOSAoIkFMU0E6IGhkYS9oZG1pIC0gQWxsb3cgYXVkaW8gY29tcG9uZW50 IGZvciBBTUQvQVRJIGFuZCBOdmlkaWEgSERNSSIpCj4gUmVwb3J0ZWQtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVGFr YXNoaSBJd2FpIDx0aXdhaUBzdXNlLmRlPgo+IC0tLQo+ICBzb3VuZC9wY2kvaGRhL3BhdGNoX2hk bWkuYyB8IDkgKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3NvdW5kL3BjaS9oZGEvcGF0Y2hfaGRtaS5j IGIvc291bmQvcGNpL2hkYS9wYXRjaF9oZG1pLmMKPiBpbmRleCA3OTVjYmRhMzJjYmIuLmQ5YjVi YTM2MTQwOSAxMDA2NDQKPiAtLS0gYS9zb3VuZC9wY2kvaGRhL3BhdGNoX2hkbWkuYwo+ICsrKyBi L3NvdW5kL3BjaS9oZGEvcGF0Y2hfaGRtaS5jCj4gQEAgLTE0NSw2ICsxNDUsNyBAQCBzdHJ1Y3Qg aGRtaV9zcGVjIHsKPiAgCXN0cnVjdCBzbmRfYXJyYXkgcGluczsgLyogc3RydWN0IGhkbWlfc3Bl Y19wZXJfcGluICovCj4gIAlzdHJ1Y3QgaGRtaV9wY20gcGNtX3JlY1sxNl07Cj4gIAlzdHJ1Y3Qg bXV0ZXggcGNtX2xvY2s7Cj4gKwlzdHJ1Y3QgbXV0ZXggYmluZF9sb2NrOyAvKiBmb3IgYXVkaW8g Y29tcG9uZW50IGJpbmRpbmcgKi8KCk1pc3NpbmcgbXV0ZXhfaW5pdCgpIGZvciB0aGlzIGd1eS4K ClRlc3RlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KCj4gIAkvKiBwY21fYml0bWFwIG1lYW5zIHdoaWNoIHBjbXMgaGF2ZSBiZWVuIGFzc2lnbmVk IHRvIHBpbnMqLwo+ICAJdW5zaWduZWQgbG9uZyBwY21fYml0bWFwOwo+ICAJaW50IHBjbV91c2Vk OwkvKiBjb3VudGVyIG9mIHBjbV9yZWNbXSAqLwo+IEBAIC0yMjU4LDcgKzIyNTksNyBAQCBzdGF0 aWMgaW50IGdlbmVyaWNfaGRtaV9pbml0KHN0cnVjdCBoZGFfY29kZWMgKmNvZGVjKQo+ICAJc3Ry dWN0IGhkbWlfc3BlYyAqc3BlYyA9IGNvZGVjLT5zcGVjOwo+ICAJaW50IHBpbl9pZHg7Cj4gIAo+ IC0JbXV0ZXhfbG9jaygmc3BlYy0+cGNtX2xvY2spOwo+ICsJbXV0ZXhfbG9jaygmc3BlYy0+Ymlu ZF9sb2NrKTsKPiAgCXNwZWMtPnVzZV9qYWNrX2RldGVjdCA9ICFjb2RlYy0+amFja3BvbGxfaW50 ZXJ2YWw7Cj4gIAlmb3IgKHBpbl9pZHggPSAwOyBwaW5faWR4IDwgc3BlYy0+bnVtX3BpbnM7IHBp bl9pZHgrKykgewo+ICAJCXN0cnVjdCBoZG1pX3NwZWNfcGVyX3BpbiAqcGVyX3BpbiA9IGdldF9w aW4oc3BlYywgcGluX2lkeCk7Cj4gQEAgLTIyNzUsNyArMjI3Niw3IEBAIHN0YXRpYyBpbnQgZ2Vu ZXJpY19oZG1pX2luaXQoc3RydWN0IGhkYV9jb2RlYyAqY29kZWMpCj4gIAkJCXNuZF9oZGFfamFj a19kZXRlY3RfZW5hYmxlX2NhbGxiYWNrKGNvZGVjLCBwaW5fbmlkLAo+ICAJCQkJCQkJICAgIGph Y2tfY2FsbGJhY2spOwo+ICAJfQo+IC0JbXV0ZXhfdW5sb2NrKCZzcGVjLT5wY21fbG9jayk7Cj4g KwltdXRleF91bmxvY2soJnNwZWMtPmJpbmRfbG9jayk7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAK PiBAQCAtMjQ1MSw3ICsyNDUyLDcgQEAgc3RhdGljIHZvaWQgZ2VuZXJpY19hY29tcF9ub3RpZmll cl9zZXQoc3RydWN0IGRybV9hdWRpb19jb21wb25lbnQgKmFjb21wLAo+ICAJaW50IGk7Cj4gIAo+ ICAJc3BlYyA9IGNvbnRhaW5lcl9vZihhY29tcC0+YXVkaW9fb3BzLCBzdHJ1Y3QgaGRtaV9zcGVj LCBkcm1fYXVkaW9fb3BzKTsKPiAtCW11dGV4X2xvY2soJnNwZWMtPnBjbV9sb2NrKTsKPiArCW11 dGV4X2xvY2soJnNwZWMtPmJpbmRfbG9jayk7Cj4gIAlzcGVjLT51c2VfYWNvbXBfbm90aWZpZXIg PSB1c2VfYWNvbXA7Cj4gIAlzcGVjLT5jb2RlYy0+cmVsYXhlZF9yZXN1bWUgPSB1c2VfYWNvbXA7 Cj4gIAkvKiByZXByb2dyYW0gZWFjaCBqYWNrIGRldGVjdGlvbiBsb2dpYyBkZXBlbmRpbmcgb24g dGhlIG5vdGlmaWVyICovCj4gQEAgLTI0NjEsNyArMjQ2Miw3IEBAIHN0YXRpYyB2b2lkIGdlbmVy aWNfYWNvbXBfbm90aWZpZXJfc2V0KHN0cnVjdCBkcm1fYXVkaW9fY29tcG9uZW50ICphY29tcCwK PiAgCQkJCQkgICAgICBnZXRfcGluKHNwZWMsIGkpLT5waW5fbmlkLAo+ICAJCQkJCSAgICAgIHVz ZV9hY29tcCk7Cj4gIAl9Cj4gLQltdXRleF91bmxvY2soJnNwZWMtPnBjbV9sb2NrKTsKPiArCW11 dGV4X3VubG9jaygmc3BlYy0+YmluZF9sb2NrKTsKPiAgfQo+ICAKPiAgLyogZW5hYmxlIC8gZGlz YWJsZSB0aGUgbm90aWZpZXIgdmlhIG1hc3RlciBiaW5kIC8gdW5iaW5kICovCj4gLS0gCj4gMi4x Ni40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C009CA9EC5 for ; Wed, 30 Oct 2019 13:50:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C50F2087E for ; Wed, 30 Oct 2019 13:50:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C50F2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C8656E9FA; Wed, 30 Oct 2019 13:50:15 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A08426E9FA for ; Wed, 30 Oct 2019 13:50:13 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:50:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="198682225" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 30 Oct 2019 06:50:10 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 30 Oct 2019 15:50:09 +0200 Date: Wed, 30 Oct 2019 15:50:09 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Takashi Iwai Message-ID: <20191030135009.GJ1208@intel.com> References: <20191029191050.GF1208@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] pcm_lock deadlock X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191030135009.Zji4YUqi1TdPuSZoINvmAoyM8LyIa6OwEaYJsHO5nj0@z> T24gVHVlLCBPY3QgMjksIDIwMTkgYXQgMDk6NTI6NTdQTSArMDEwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgo+IE9uIFR1ZSwgMjkgT2N0IDIwMTkgMjA6MTA6NTAgKzAxMDAsCj4gRnJvbTogVGFrYXNo aSBJd2FpIDx0aXdhaUBzdXNlLmRlPgo+IFN1YmplY3Q6IFtQQVRDSF0gQUxTQTogaGRhIC0gRml4 IG11dGV4IGRlYWRsb2NrIGluIEhETUkgY29kZWMgZHJpdmVyCj4gCj4gVGhlIGNvbW1pdCBhZGU0 OWRiMzM3YTkgKCJBTFNBOiBoZGEvaGRtaSAtIEFsbG93IGF1ZGlvIGNvbXBvbmVudCBmb3IKPiBB TUQvQVRJIGFuZCBOdmlkaWEgSERNSSIpIGludHJvZHVjZWQgdGhlIHNwZWMtPnBjbV9sb2NrIG11 dGV4IGxvY2sgdG8KPiB0aGUgd2hvbGUgZ2VuZXJpY19oZG1pX2luaXQoKSBmdW5jdGlvbiBmb3Ig YXZvaWRpbmcgdGhlIHJhY2Ugd2l0aCB0aGUKPiBhdWRpbyBjb21wb25lbnQgcmVnaXN0cmF0aW9u LiAgSG93ZXZlciwgdGhpcyBjYXVzZWQgYSBkZWFkIGxvY2sgd2hlbgo+IHRoZSB1bnNvbGljaXRl ZCBldmVudCBpcyBoYW5kbGVkIHdpdGhvdXQgdGhlIGF1ZGlvIGNvbXBvbmVudCwgYXMgdGhlCj4g Y29kZWMgZ2V0cyBydW50aW1lLXJlc3VtZWQgaW4gaGRtaV9wcmVzZW50X3NlbnNlKCkgd2hpY2gg aXMgYWxyZWFkeQo+IGluc2lkZSB0aGUgc3BlYy0+cGNtX2xvY2sgaW4gaXRzIGNhbGxlci4KPiAK PiBGb3IgYXZvaWRpbmcgdGhpcyBkZWFkbG9jaywgYWRkIGEgbmV3IG11dGV4IG9ubHkgZm9yIHRo ZSBhdWRpbwo+IGNvbXBvbmVudCBiaW5kaW5nIHRoYXQgaXMgdXNlZCBpbiBib3RoIGdlbmVyaWNf aGRtaV9pbml0KCkgYW5kIHRoZQo+IGF1ZGlvIG5vdGlmaWVyIHJlZ2lzdHJhdGlvbiB3aGVyZSB0 aGUgamFjayBjYWxsYmFja3MgYXJlIGhhbmRsZWQgLwo+IHJlLXJlZ2lzdGVyZWQuCj4gCj4gRml4 ZXM6IGFkZTQ5ZGIzMzdhOSAoIkFMU0E6IGhkYS9oZG1pIC0gQWxsb3cgYXVkaW8gY29tcG9uZW50 IGZvciBBTUQvQVRJIGFuZCBOdmlkaWEgSERNSSIpCj4gUmVwb3J0ZWQtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVGFr YXNoaSBJd2FpIDx0aXdhaUBzdXNlLmRlPgo+IC0tLQo+ICBzb3VuZC9wY2kvaGRhL3BhdGNoX2hk bWkuYyB8IDkgKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3NvdW5kL3BjaS9oZGEvcGF0Y2hfaGRtaS5j IGIvc291bmQvcGNpL2hkYS9wYXRjaF9oZG1pLmMKPiBpbmRleCA3OTVjYmRhMzJjYmIuLmQ5YjVi YTM2MTQwOSAxMDA2NDQKPiAtLS0gYS9zb3VuZC9wY2kvaGRhL3BhdGNoX2hkbWkuYwo+ICsrKyBi L3NvdW5kL3BjaS9oZGEvcGF0Y2hfaGRtaS5jCj4gQEAgLTE0NSw2ICsxNDUsNyBAQCBzdHJ1Y3Qg aGRtaV9zcGVjIHsKPiAgCXN0cnVjdCBzbmRfYXJyYXkgcGluczsgLyogc3RydWN0IGhkbWlfc3Bl Y19wZXJfcGluICovCj4gIAlzdHJ1Y3QgaGRtaV9wY20gcGNtX3JlY1sxNl07Cj4gIAlzdHJ1Y3Qg bXV0ZXggcGNtX2xvY2s7Cj4gKwlzdHJ1Y3QgbXV0ZXggYmluZF9sb2NrOyAvKiBmb3IgYXVkaW8g Y29tcG9uZW50IGJpbmRpbmcgKi8KCk1pc3NpbmcgbXV0ZXhfaW5pdCgpIGZvciB0aGlzIGd1eS4K ClRlc3RlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KCj4gIAkvKiBwY21fYml0bWFwIG1lYW5zIHdoaWNoIHBjbXMgaGF2ZSBiZWVuIGFzc2lnbmVk IHRvIHBpbnMqLwo+ICAJdW5zaWduZWQgbG9uZyBwY21fYml0bWFwOwo+ICAJaW50IHBjbV91c2Vk OwkvKiBjb3VudGVyIG9mIHBjbV9yZWNbXSAqLwo+IEBAIC0yMjU4LDcgKzIyNTksNyBAQCBzdGF0 aWMgaW50IGdlbmVyaWNfaGRtaV9pbml0KHN0cnVjdCBoZGFfY29kZWMgKmNvZGVjKQo+ICAJc3Ry dWN0IGhkbWlfc3BlYyAqc3BlYyA9IGNvZGVjLT5zcGVjOwo+ICAJaW50IHBpbl9pZHg7Cj4gIAo+ IC0JbXV0ZXhfbG9jaygmc3BlYy0+cGNtX2xvY2spOwo+ICsJbXV0ZXhfbG9jaygmc3BlYy0+Ymlu ZF9sb2NrKTsKPiAgCXNwZWMtPnVzZV9qYWNrX2RldGVjdCA9ICFjb2RlYy0+amFja3BvbGxfaW50 ZXJ2YWw7Cj4gIAlmb3IgKHBpbl9pZHggPSAwOyBwaW5faWR4IDwgc3BlYy0+bnVtX3BpbnM7IHBp bl9pZHgrKykgewo+ICAJCXN0cnVjdCBoZG1pX3NwZWNfcGVyX3BpbiAqcGVyX3BpbiA9IGdldF9w aW4oc3BlYywgcGluX2lkeCk7Cj4gQEAgLTIyNzUsNyArMjI3Niw3IEBAIHN0YXRpYyBpbnQgZ2Vu ZXJpY19oZG1pX2luaXQoc3RydWN0IGhkYV9jb2RlYyAqY29kZWMpCj4gIAkJCXNuZF9oZGFfamFj a19kZXRlY3RfZW5hYmxlX2NhbGxiYWNrKGNvZGVjLCBwaW5fbmlkLAo+ICAJCQkJCQkJICAgIGph Y2tfY2FsbGJhY2spOwo+ICAJfQo+IC0JbXV0ZXhfdW5sb2NrKCZzcGVjLT5wY21fbG9jayk7Cj4g KwltdXRleF91bmxvY2soJnNwZWMtPmJpbmRfbG9jayk7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAK PiBAQCAtMjQ1MSw3ICsyNDUyLDcgQEAgc3RhdGljIHZvaWQgZ2VuZXJpY19hY29tcF9ub3RpZmll cl9zZXQoc3RydWN0IGRybV9hdWRpb19jb21wb25lbnQgKmFjb21wLAo+ICAJaW50IGk7Cj4gIAo+ ICAJc3BlYyA9IGNvbnRhaW5lcl9vZihhY29tcC0+YXVkaW9fb3BzLCBzdHJ1Y3QgaGRtaV9zcGVj LCBkcm1fYXVkaW9fb3BzKTsKPiAtCW11dGV4X2xvY2soJnNwZWMtPnBjbV9sb2NrKTsKPiArCW11 dGV4X2xvY2soJnNwZWMtPmJpbmRfbG9jayk7Cj4gIAlzcGVjLT51c2VfYWNvbXBfbm90aWZpZXIg PSB1c2VfYWNvbXA7Cj4gIAlzcGVjLT5jb2RlYy0+cmVsYXhlZF9yZXN1bWUgPSB1c2VfYWNvbXA7 Cj4gIAkvKiByZXByb2dyYW0gZWFjaCBqYWNrIGRldGVjdGlvbiBsb2dpYyBkZXBlbmRpbmcgb24g dGhlIG5vdGlmaWVyICovCj4gQEAgLTI0NjEsNyArMjQ2Miw3IEBAIHN0YXRpYyB2b2lkIGdlbmVy aWNfYWNvbXBfbm90aWZpZXJfc2V0KHN0cnVjdCBkcm1fYXVkaW9fY29tcG9uZW50ICphY29tcCwK PiAgCQkJCQkgICAgICBnZXRfcGluKHNwZWMsIGkpLT5waW5fbmlkLAo+ICAJCQkJCSAgICAgIHVz ZV9hY29tcCk7Cj4gIAl9Cj4gLQltdXRleF91bmxvY2soJnNwZWMtPnBjbV9sb2NrKTsKPiArCW11 dGV4X3VubG9jaygmc3BlYy0+YmluZF9sb2NrKTsKPiAgfQo+ICAKPiAgLyogZW5hYmxlIC8gZGlz YWJsZSB0aGUgbm90aWZpZXIgdmlhIG1hc3RlciBiaW5kIC8gdW5iaW5kICovCj4gLS0gCj4gMi4x Ni40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA==