From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Mesut Ali Ergin <mesut.a.ergin@intel.com>
Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized
Date: Wed, 30 Oct 2019 22:01:16 +0800 [thread overview]
Message-ID: <20191030140115.GH11315@intel.com> (raw)
In-Reply-To: <20191028074109.GG33024@intel.com>
Latest update, since i40e now has added FDIR ID to vector rx after patchset
https://patches.dpdk.org/cover/60820/ being merged, this patch is no longer
needed, so just drop it from next-net-intel.
Thanks,
Xiaolong
On 10/28, Ye Xiaolong wrote:
>Sorry for missing this patch for a long time.
>
>On 06/03, Mesut Ali Ergin wrote:
>>Runtime requests to install an rte_flow with MARK action should fail
>>if the device was started and a vector RX function was already chosen
>>for during configuration time.
>>
>>Currently, i40e rte_flow driver would successfully install the flow
>>with MARK action, even when vector RX functions are in use. However,
>>those vector RX functions will fail to retrieve the MARK data from the
>>device descriptor into the mbuf. The original app installing the flow
>>would never know what went wrong. The function introduced in this patch
>>must be adjusted if/when certain vector RX functions start supporting
>>correct FDIR processing for MARK actions.
>>
>>Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
>>Cc: stable@dpdk.org
>>
>>Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
>>
>>v3:
>> - Check for support made in an function for future extensibility
>> - Fixes code style warnings
>> - CC stable w/ fix reference
>>v2:
>> - Check added to fail MARK request only if the device was started
>>---
>
>Minor nit, you should put the change logs after above '---' line, then they can be
>ignored when git-am, fix it while merging.
>
>> drivers/net/i40e/i40e_flow.c | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>
>Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>Applied to dpdk-next-net-intel. Thanks.
prev parent reply other threads:[~2019-10-30 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 17:44 [dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized Mesut Ali Ergin
2019-10-28 7:41 ` Ye Xiaolong
2019-10-30 14:01 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030140115.GH11315@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=mesut.a.ergin@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.