From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Date: Wed, 30 Oct 2019 18:05:59 +0000 Subject: Re: [PATCH] soc: samsung: exynos-asv: Potential NULL dereference in exynos_asv_update_opps() Message-Id: <20191030180559.GA8016@kozik-lap> List-Id: References: <20191029182742.GC17569@mwanda> In-Reply-To: <20191029182742.GC17569@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org On Tue, Oct 29, 2019 at 09:27:42PM +0300, Dan Carpenter wrote: > The dev_pm_opp_get_opp_table() returns error pointers if it's disabled > in the config and it returns NULL if there is an error. This code only > checks for error pointers so it could lead to an Oops inside the > dev_pm_opp_put_opp_table() function. > > Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver") > Signed-off-by: Dan Carpenter > --- > When we add a new driver, could we specify the which prefix will be used > going forward? In other words commit 5ea428595cc5 could have the > prefix "soc: samsung: exynos-asv: Add Exynos Adaptive Supply Voltage > driver". The "exynos-asv" bit was missing so the first person to send a > fix has to guess what is desired. Indeed, I usually do not add it on first commit to avoid duplication (prefix and later explanation) but I see that it would be helpful. Thanks, applied. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09FDCA9EC5 for ; Wed, 30 Oct 2019 18:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 600C02087E for ; Wed, 30 Oct 2019 18:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572458765; bh=rZB+jB/GhHIadQPBUNnMZMqEdc0Z25SHClG1fS9zNIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yFxazmldYntJjQX7eTDOvBiWgW+VvCxdS+F/Bjk7BhtZTXyhDnyH/fqcr7Easvr/1 CSEzdsN5AMxZFqxx86pNoHALYV1Yt1sfbP9FVP6zzd/hWAz7zvgRCJifTCzy0fGO4H +qYXpPWWHrizKSy1UkZkEpR+++U3P0dXuSXwpAV8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727763AbfJ3SGF (ORCPT ); Wed, 30 Oct 2019 14:06:05 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:44395 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727762AbfJ3SGE (ORCPT ); Wed, 30 Oct 2019 14:06:04 -0400 Received: by mail-ed1-f68.google.com with SMTP id b18so2505459edr.11; Wed, 30 Oct 2019 11:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FrSVqR4rubXbOdoO4xIlrJ/g2AylU6DO+rRGS6ug+TM=; b=uVssUMm6cjQdfCDkO8kwHYzIulhlCr5/nE+SqtXo0+491WDXG7QWahSPeru0ZFYibn leaeEqPllET5IXOrX4qF6Skb+8y1383gTzhgM5hVDvNNiuS9QUNPygPkJ9O9n9XFosCB t+064iV3AKOecHEQxo0lCsGy+Q/rX4oq83ZEMGu7xVqJWX/56DH16NdLtW6QMgP7NhaG 74a5oG4XF2fx3XwBYWxnejHJ5mfEeI2USU+utgsQq/fiZfpH2LEY0Gqttw508k1Kft6U uwYojeyMFqv+WxjK6+JSCSapwJUwX88ydsGPBd5F9aXWBefdXvvbR8KZEid32+reyFKn gbCg== X-Gm-Message-State: APjAAAU7NLQ/9XMwvQlISZmY5zwAlw6oVhpL/Cv1wY0Xn1hpMpSSC8ki VurfnIUFAYuWU6jXm+qZH6s= X-Google-Smtp-Source: APXvYqzu4HoYoArCMfuZiHHYx5XLueApspB4kJAI+3/Kg9OneW/pR4iKPXYNA//dTC9X/UDqISTrsw== X-Received: by 2002:a17:906:c793:: with SMTP id cw19mr886699ejb.25.1572458762736; Wed, 30 Oct 2019 11:06:02 -0700 (PDT) Received: from kozik-lap ([194.230.155.180]) by smtp.googlemail.com with ESMTPSA id d26sm17952edu.37.2019.10.30.11.06.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Oct 2019 11:06:01 -0700 (PDT) Date: Wed, 30 Oct 2019 19:05:59 +0100 From: Krzysztof Kozlowski To: Dan Carpenter Cc: Kukjin Kim , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] soc: samsung: exynos-asv: Potential NULL dereference in exynos_asv_update_opps() Message-ID: <20191030180559.GA8016@kozik-lap> References: <20191029182742.GC17569@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191029182742.GC17569@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Tue, Oct 29, 2019 at 09:27:42PM +0300, Dan Carpenter wrote: > The dev_pm_opp_get_opp_table() returns error pointers if it's disabled > in the config and it returns NULL if there is an error. This code only > checks for error pointers so it could lead to an Oops inside the > dev_pm_opp_put_opp_table() function. > > Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver") > Signed-off-by: Dan Carpenter > --- > When we add a new driver, could we specify the which prefix will be used > going forward? In other words commit 5ea428595cc5 could have the > prefix "soc: samsung: exynos-asv: Add Exynos Adaptive Supply Voltage > driver". The "exynos-asv" bit was missing so the first person to send a > fix has to guess what is desired. Indeed, I usually do not add it on first commit to avoid duplication (prefix and later explanation) but I see that it would be helpful. Thanks, applied. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6A7CA9EC5 for ; Wed, 30 Oct 2019 18:06:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59317208E3 for ; Wed, 30 Oct 2019 18:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LRKChi29" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59317208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GRePvmCFL5ljw6VFjcr8Ef/Cng76fybHcQaWT+d1Hak=; b=LRKChi29sTPHFj bt/L/Nn1dfRjYlaEmDhc6nMHvsWPs2JSHgwFOo3+V6D17FZGileINGF31wrX5KAwpML/3w+NKv6j1 zCaW+XY7/sO21pcqQNjGUHMs9RAfUVcjFdDROaUcLy52ILFiN47vz2rlhL87iVT831zLlJ3TNqWm3 vG4yhFUuKwejzehQ+PnuWtCFhsZOfrwdhS7Xwq2tZb7o5prBwuxSD7++3xH1fxI62gROf0UtL/f9l l7u3ljIWXpG+yOr2DomA7BlqsAp6i+o3CzHAlKnKfk28bdoi438+bdXeKp4NrVrMbduwiL8kmG9RR bAyFzTRMIZPTUH719TDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPsME-0006xI-B1; Wed, 30 Oct 2019 18:06:10 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPsMB-0006wM-B8 for linux-arm-kernel@lists.infradead.org; Wed, 30 Oct 2019 18:06:08 +0000 Received: by mail-ed1-f68.google.com with SMTP id f25so2508075edw.10 for ; Wed, 30 Oct 2019 11:06:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FrSVqR4rubXbOdoO4xIlrJ/g2AylU6DO+rRGS6ug+TM=; b=d/JM+CkvoQlItCGARygWNrP+Mqqq36jwNfrSHBJbLeB12U+ggDKsgpQyfqb9BuqjFi SKmuTHkxYc4REjzcQrNHH8iJU7D4elwXzUvn47QCqBcgL4sYsjj7sFtxnLUM5frhow+F Euz4d2/RGOVvZMwJF1dT+POTgjA9BdlxGbL2Hp2qAJu3dehPH9KPw6PWxc+NdwZM5eRx A77GjOSFxfC2FMfmqtl1U61rLjkdd74g5SdOqbn4pvVzx0w2CmmkskcoEPbXPXvKUrPk i0qoJ7+kAA95QLIfwG2Vi4jdqfP6ver4Tk0v5U4lHhkI2jw8aCQFDp9+VAY1H6dPvd5Z nWsw== X-Gm-Message-State: APjAAAV8zHcTPDMlunb1HnBLDadbC570COAomdY7QCLzfW0NXXDUuzsS dFL9lJm7U6oJ6ctLtx2bskrv/NkP X-Google-Smtp-Source: APXvYqzu4HoYoArCMfuZiHHYx5XLueApspB4kJAI+3/Kg9OneW/pR4iKPXYNA//dTC9X/UDqISTrsw== X-Received: by 2002:a17:906:c793:: with SMTP id cw19mr886699ejb.25.1572458762736; Wed, 30 Oct 2019 11:06:02 -0700 (PDT) Received: from kozik-lap ([194.230.155.180]) by smtp.googlemail.com with ESMTPSA id d26sm17952edu.37.2019.10.30.11.06.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Oct 2019 11:06:01 -0700 (PDT) Date: Wed, 30 Oct 2019 19:05:59 +0100 From: Krzysztof Kozlowski To: Dan Carpenter Subject: Re: [PATCH] soc: samsung: exynos-asv: Potential NULL dereference in exynos_asv_update_opps() Message-ID: <20191030180559.GA8016@kozik-lap> References: <20191029182742.GC17569@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191029182742.GC17569@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191030_110607_381149_8B5C12D8 X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 29, 2019 at 09:27:42PM +0300, Dan Carpenter wrote: > The dev_pm_opp_get_opp_table() returns error pointers if it's disabled > in the config and it returns NULL if there is an error. This code only > checks for error pointers so it could lead to an Oops inside the > dev_pm_opp_put_opp_table() function. > > Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver") > Signed-off-by: Dan Carpenter > --- > When we add a new driver, could we specify the which prefix will be used > going forward? In other words commit 5ea428595cc5 could have the > prefix "soc: samsung: exynos-asv: Add Exynos Adaptive Supply Voltage > driver". The "exynos-asv" bit was missing so the first person to send a > fix has to guess what is desired. Indeed, I usually do not add it on first commit to avoid duplication (prefix and later explanation) but I see that it would be helpful. Thanks, applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel