From: Bjorn Helgaas <helgaas@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, davem@davemloft.net,
robh+dt@kernel.org, mark.rutland@arm.com, axboe@kernel.dk,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/5] net: stmmac: pci: Add Loongson GMAC
Date: Wed, 30 Oct 2019 15:36:57 -0500 [thread overview]
Message-ID: <20191030203657.GA247440@google.com> (raw)
In-Reply-To: <20191030135347.3636-4-jiaxun.yang@flygoat.com>
On Wed, Oct 30, 2019 at 09:53:45PM +0800, Jiaxun Yang wrote:
> This device will be setup by parsing DeviceTree node
> of pci device.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> +static int loongson_pci_of_setup(struct pci_dev *pdev,
> + struct plat_stmmacenet_data *plat)
> +{
> + struct device_node *np;
> + np = pci_device_to_OF_node(pdev);
> +
> + if(!np) {
Please pay attention to the existing coding style in the file and
follow it. In this and other cases below, add a space in "if (".
> + if(!of_device_is_compatible(np, "loongson,pci-gmac")) {
> + return stmmac_parse_config_dt(np, plat);
Remove the double space here.
> + if(info->of_irq) {
> + STMMAC_DEVICE(LOONGSON, PCI_DEVICE_ID_LOONGSON_GMAC, loongson_of_pci_info),
And here.
next prev parent reply other threads:[~2019-10-30 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 13:53 [PATCH 0/5] PCI Devices for Loongson PCH Jiaxun Yang
2019-10-30 13:53 ` [PATCH 1/5] PCI: pci_ids: Add Loongson IDs Jiaxun Yang
2019-10-30 20:40 ` Bjorn Helgaas
2019-10-30 13:53 ` [PATCH 2/5] net: stmmac: Split devicetree parse Jiaxun Yang
2019-11-01 12:18 ` Andrew Murray
2019-11-01 22:43 ` kbuild test robot
2019-11-01 22:43 ` kbuild test robot
2019-11-01 22:45 ` kbuild test robot
2019-11-01 22:45 ` kbuild test robot
2019-10-30 13:53 ` [PATCH 3/5] net: stmmac: pci: Add Loongson GMAC Jiaxun Yang
2019-10-30 20:36 ` Bjorn Helgaas [this message]
2019-10-30 13:53 ` [PATCH 4/5] dt-bindings: net: document loongson.pci-gmac Jiaxun Yang
2019-10-31 8:35 ` Simon Horman
2019-10-31 10:57 ` Jiaxun Yang
2019-10-31 20:42 ` Simon Horman
2019-10-30 13:53 ` [PATCH 5/5] libata/ahci: Apply non-standard BAR fix for Loongson Jiaxun Yang
2019-10-31 10:39 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030203657.GA247440@google.com \
--to=helgaas@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=joabreu@synopsys.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.