From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7289CA9ECB for ; Thu, 31 Oct 2019 14:52:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4E1C2086D for ; Thu, 31 Oct 2019 14:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EYhbd96G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4E1C2086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=52OWUG38tH6u4HmcfsJU031Kf3RzJdE0ycyJLrBVC/c=; b=EYhbd96GvRx0lA gg93W06pE5rMNtZS/XzAufz4xZMe/CLX+RFHqU9sMn+wjD/ZaeIbUX9PRbE3XjgLM9XQ/6QDt1zkd p+USPnRdpQhIF2+nxN1aQqIi/U2f2PT0sQhqGZS8Tx9LvLBNaF5U5uaCw4BSgIQgGs5TunNwoIM37 J5b0PM/xzhAvwvb29EPF44vk3iDF8rXOtKJ1taJS/z0tAg5f1072D+FYKQI+6RSvmOwwCD75utGFX D8n593Q17lT/crFQfanXAFmIVSo+/vuVVYZIROAjIf1ZQhdv7m6SoXptBdiS7t2rUDrKvSKqq29eC CxOdqQM41OiJfiWpys2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQBoP-0002Aw-2Z; Thu, 31 Oct 2019 14:52:33 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQBoL-00029s-Vk for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2019 14:52:31 +0000 Received: by verein.lst.de (Postfix, from userid 2005) id 0102D68BE1; Thu, 31 Oct 2019 15:52:24 +0100 (CET) Date: Thu, 31 Oct 2019 15:52:24 +0100 From: Torsten Duwe To: Maxime Ripard Subject: Re: [PATCH v4 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20191031145224.GA5973@lst.de> References: <20191029153815.C631668C4E@verein.lst.de> <20191029153953.8EE9B68D04@verein.lst.de> <20191031125100.qprbdaaysg3tmhif@hendrix> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191031125100.qprbdaaysg3tmhif@hendrix> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_075230_169611_E6E21780 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Daniel Vetter , Harald Geyer , Sean Paul , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 31, 2019 at 01:51:00PM +0100, Maxime Ripard wrote: > On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote: > > + > > + ports: > > + anyOf: > > + - port@0: > > + description: Video port for LVTTL input > > + - port@1: > > + description: Video port for eDP output (panel or connector). > > + May be omitted if EDID works reliably. > > + required: > > + - port@0 > > Have you tried to validate those two ports in a DT? Yes, it validates as expected, like I wrote. Various sources told me that json-schema is not always straightforward so I assumed anyOf was OK. > I'm not quite sure what you wanted to express with that anyOf, but if > it was something like port@0 is mandatory, and port@1 is optional, it > should be something like this: > > properties: > > ... > > ports: > type: object > > properties: > port@0: > type: object > description: | > Video port for LVTTL input > > port@1: > type: object > description: | > Video port for eDP output (..) > > required: > - port@0 > > This way, you express that both port@0 and port@1 must by nodes, under > a node called ports, and port@0 is mandatory. That validates, too. Looks better, admittedly. I don't have a strong opinion here. It's just that Rob wrote in : | For this case specifically, we do need to define a common graph | schema, but haven't yet. You can assume we do and only really need to | capture what Maxime said above. (your points back then were port@N descriptions and neccessity for port@0) Are you sure that "object" is specific enough? > You should even push this a bit further by adding > additionalProperties: false to prevent a DT from having undocumented > properties and children for the main node and ports node. You mean like | jsonschema.exceptions.SchemaError: Additional properties are not allowed ('unevaluatedProperties' was unexpected) [...] | On schema: | {'$id': 'http://devicetree.org/schemas/watchdog/allwinner,sun4i-a10-wdt.yaml#', [...] | 'unevaluatedProperties': False} ? ;-) But yes, this patch series passes even with additionalProperties: false. In which form would you like to receive the update? Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15BDCA9ECB for ; Thu, 31 Oct 2019 14:52:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A88D2086D for ; Thu, 31 Oct 2019 14:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728052AbfJaOw2 (ORCPT ); Thu, 31 Oct 2019 10:52:28 -0400 Received: from verein.lst.de ([213.95.11.211]:51479 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728021AbfJaOw2 (ORCPT ); Thu, 31 Oct 2019 10:52:28 -0400 Received: by verein.lst.de (Postfix, from userid 2005) id 0102D68BE1; Thu, 31 Oct 2019 15:52:24 +0100 (CET) Date: Thu, 31 Oct 2019 15:52:24 +0100 From: Torsten Duwe To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Vasily Khoruzhick , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20191031145224.GA5973@lst.de> References: <20191029153815.C631668C4E@verein.lst.de> <20191029153953.8EE9B68D04@verein.lst.de> <20191031125100.qprbdaaysg3tmhif@hendrix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031125100.qprbdaaysg3tmhif@hendrix> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 31, 2019 at 01:51:00PM +0100, Maxime Ripard wrote: > On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote: > > + > > + ports: > > + anyOf: > > + - port@0: > > + description: Video port for LVTTL input > > + - port@1: > > + description: Video port for eDP output (panel or connector). > > + May be omitted if EDID works reliably. > > + required: > > + - port@0 > > Have you tried to validate those two ports in a DT? Yes, it validates as expected, like I wrote. Various sources told me that json-schema is not always straightforward so I assumed anyOf was OK. > I'm not quite sure what you wanted to express with that anyOf, but if > it was something like port@0 is mandatory, and port@1 is optional, it > should be something like this: > > properties: > > ... > > ports: > type: object > > properties: > port@0: > type: object > description: | > Video port for LVTTL input > > port@1: > type: object > description: | > Video port for eDP output (..) > > required: > - port@0 > > This way, you express that both port@0 and port@1 must by nodes, under > a node called ports, and port@0 is mandatory. That validates, too. Looks better, admittedly. I don't have a strong opinion here. It's just that Rob wrote in : | For this case specifically, we do need to define a common graph | schema, but haven't yet. You can assume we do and only really need to | capture what Maxime said above. (your points back then were port@N descriptions and neccessity for port@0) Are you sure that "object" is specific enough? > You should even push this a bit further by adding > additionalProperties: false to prevent a DT from having undocumented > properties and children for the main node and ports node. You mean like | jsonschema.exceptions.SchemaError: Additional properties are not allowed ('unevaluatedProperties' was unexpected) [...] | On schema: | {'$id': 'http://devicetree.org/schemas/watchdog/allwinner,sun4i-a10-wdt.yaml#', [...] | 'unevaluatedProperties': False} ? ;-) But yes, this patch series passes even with additionalProperties: false. In which form would you like to receive the update? Torsten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 494CACA9EC9 for ; Fri, 1 Nov 2019 08:10:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AB20208E3 for ; Fri, 1 Nov 2019 08:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AB20208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1DC46F767; Fri, 1 Nov 2019 08:10:35 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B08B6EEC2 for ; Thu, 31 Oct 2019 14:52:29 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2005) id 0102D68BE1; Thu, 31 Oct 2019 15:52:24 +0100 (CET) Date: Thu, 31 Oct 2019 15:52:24 +0100 From: Torsten Duwe To: Maxime Ripard Subject: Re: [PATCH v4 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20191031145224.GA5973@lst.de> References: <20191029153815.C631668C4E@verein.lst.de> <20191029153953.8EE9B68D04@verein.lst.de> <20191031125100.qprbdaaysg3tmhif@hendrix> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191031125100.qprbdaaysg3tmhif@hendrix> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Fri, 01 Nov 2019 08:09:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Harald Geyer , Sean Paul , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191031145224.ynf1gd8FlkCD163z9wkyaM9AmyImThV46qt1kw6nomU@z> T24gVGh1LCBPY3QgMzEsIDIwMTkgYXQgMDE6NTE6MDBQTSArMDEwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiBPbiBUdWUsIE9jdCAyOSwgMjAxOSBhdCAwMToxNjo1N1BNICswMTAwLCBUb3JzdGVu IER1d2Ugd3JvdGU6Cj4gPiArCj4gPiArICBwb3J0czoKPiA+ICsgICAgYW55T2Y6Cj4gPiArICAg ICAgLSBwb3J0QDA6Cj4gPiArICAgICAgICBkZXNjcmlwdGlvbjogVmlkZW8gcG9ydCBmb3IgTFZU VEwgaW5wdXQKPiA+ICsgICAgICAtIHBvcnRAMToKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOiBW aWRlbyBwb3J0IGZvciBlRFAgb3V0cHV0IChwYW5lbCBvciBjb25uZWN0b3IpLgo+ID4gKyAgICAg ICAgICAgICAgICAgICAgIE1heSBiZSBvbWl0dGVkIGlmIEVESUQgd29ya3MgcmVsaWFibHkuCj4g PiArICAgIHJlcXVpcmVkOgo+ID4gKyAgICAgIC0gcG9ydEAwCj4gCj4gSGF2ZSB5b3UgdHJpZWQg dG8gdmFsaWRhdGUgdGhvc2UgdHdvIHBvcnRzIGluIGEgRFQ/CgpZZXMsIGl0IHZhbGlkYXRlcyBh cyBleHBlY3RlZCwgbGlrZSBJIHdyb3RlLiBWYXJpb3VzIHNvdXJjZXMgdG9sZCBtZSB0aGF0Cmpz b24tc2NoZW1hIGlzIG5vdCBhbHdheXMgc3RyYWlnaHRmb3J3YXJkIHNvIEkgYXNzdW1lZCBhbnlP ZiB3YXMgT0suCgo+IEknbSBub3QgcXVpdGUgc3VyZSB3aGF0IHlvdSB3YW50ZWQgdG8gZXhwcmVz cyB3aXRoIHRoYXQgYW55T2YsIGJ1dCBpZgo+IGl0IHdhcyBzb21ldGhpbmcgbGlrZSBwb3J0QDAg aXMgbWFuZGF0b3J5LCBhbmQgcG9ydEAxIGlzIG9wdGlvbmFsLCBpdAo+IHNob3VsZCBiZSBzb21l dGhpbmcgbGlrZSB0aGlzOgo+IAo+IHByb3BlcnRpZXM6Cj4gCj4gICAuLi4KPiAKPiAgIHBvcnRz Ogo+ICAgICB0eXBlOiBvYmplY3QKPiAKPiAgICAgcHJvcGVydGllczoKPiAgICAgICBwb3J0QDA6 Cj4gICAgICAgICB0eXBlOiBvYmplY3QKPiAgICAgICAgIGRlc2NyaXB0aW9uOiB8Cj4gCSAgVmlk ZW8gcG9ydCBmb3IgTFZUVEwgaW5wdXQKPiAKPiAgICAgICBwb3J0QDE6Cj4gICAgICAgICB0eXBl OiBvYmplY3QKPiAgICAgICAgIGRlc2NyaXB0aW9uOiB8Cj4gCSAgVmlkZW8gcG9ydCBmb3IgZURQ IG91dHB1dCAoLi4pCj4gCj4gICAgIHJlcXVpcmVkOgo+ICAgICAgIC0gcG9ydEAwCj4gCj4gVGhp cyB3YXksIHlvdSBleHByZXNzIHRoYXQgYm90aCBwb3J0QDAgYW5kIHBvcnRAMSBtdXN0IGJ5IG5v ZGVzLCB1bmRlcgo+IGEgbm9kZSBjYWxsZWQgcG9ydHMsIGFuZCBwb3J0QDAgaXMgbWFuZGF0b3J5 LgoKVGhhdCB2YWxpZGF0ZXMsIHRvby4gTG9va3MgYmV0dGVyLCBhZG1pdHRlZGx5LiBJIGRvbid0 IGhhdmUgYSBzdHJvbmcKb3BpbmlvbiBoZXJlLiBJdCdzIGp1c3QgdGhhdCBSb2Igd3JvdGUgaW4K PENBTF9Kc3FLQVUzV0czTD1LUDhBOHU0dlc9cV9CUVdQTi1tX2MrQURPd1Rpb0oyLWNtZ0BtYWls LmdtYWlsLmNvbT46Cgp8IEZvciB0aGlzIGNhc2Ugc3BlY2lmaWNhbGx5LCB3ZSBkbyBuZWVkIHRv IGRlZmluZSBhIGNvbW1vbiBncmFwaAp8IHNjaGVtYSwgYnV0IGhhdmVuJ3QgeWV0LiBZb3UgY2Fu IGFzc3VtZSB3ZSBkbyBhbmQgb25seSByZWFsbHkgbmVlZCB0byAgICAKfCBjYXB0dXJlIHdoYXQg TWF4aW1lIHNhaWQgYWJvdmUuCih5b3VyIHBvaW50cyBiYWNrIHRoZW4gd2VyZSBwb3J0QE4gZGVz Y3JpcHRpb25zIGFuZCBuZWNjZXNzaXR5IGZvciBwb3J0QDApCgpBcmUgeW91IHN1cmUgdGhhdCAi b2JqZWN0IiBpcyBzcGVjaWZpYyBlbm91Z2g/Cgo+IFlvdSBzaG91bGQgZXZlbiBwdXNoIHRoaXMg YSBiaXQgZnVydGhlciBieSBhZGRpbmcKPiBhZGRpdGlvbmFsUHJvcGVydGllczogZmFsc2UgdG8g cHJldmVudCBhIERUIGZyb20gaGF2aW5nIHVuZG9jdW1lbnRlZAo+IHByb3BlcnRpZXMgYW5kIGNo aWxkcmVuIGZvciB0aGUgbWFpbiBub2RlIGFuZCBwb3J0cyBub2RlLgoKWW91IG1lYW4gbGlrZQoK fCBqc29uc2NoZW1hLmV4Y2VwdGlvbnMuU2NoZW1hRXJyb3I6IEFkZGl0aW9uYWwgcHJvcGVydGll cyBhcmUgbm90IGFsbG93ZWQgKCd1bmV2YWx1YXRlZFByb3BlcnRpZXMnIHdhcyB1bmV4cGVjdGVk KQpbLi4uXQp8IE9uIHNjaGVtYToKfCAgICB7JyRpZCc6ICdodHRwOi8vZGV2aWNldHJlZS5vcmcv c2NoZW1hcy93YXRjaGRvZy9hbGx3aW5uZXIsc3VuNGktYTEwLXdkdC55YW1sIycsClsuLi5dCnwg ICAgICAndW5ldmFsdWF0ZWRQcm9wZXJ0aWVzJzogRmFsc2V9Cgo/IDstKQoKQnV0IHllcywgdGhp cyBwYXRjaCBzZXJpZXMgcGFzc2VzIGV2ZW4gd2l0aCBhZGRpdGlvbmFsUHJvcGVydGllczogZmFs c2UuCgpJbiB3aGljaCBmb3JtIHdvdWxkIHlvdSBsaWtlIHRvIHJlY2VpdmUgdGhlIHVwZGF0ZT8K CglUb3JzdGVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=