From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A68BCA9ECB for ; Thu, 31 Oct 2019 17:54:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50AF62080F for ; Thu, 31 Oct 2019 17:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UVqftwxs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EST86sBD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50AF62080F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2vMh0148hZM2NuaC216KiMEakK9Pp/09OwMVxcsE+SM=; b=UVqftwxsgwyjsw 3PgvfQPdZWxkx6dlE3OIvlZ8ov+0/j4p/8ER+MmqaIeszaZDHbCWVgRvVExJzPtWRJvV30dEkeD6G BeQ6P2VaCrI2CCF2ucC7Jr5YAeT6NjNdwjttI7w1PlQsstDXZN7Df3Q3Fy6dcz62DkPRqxK4x9WQ0 guds6OucCCz4SwcPRmNQ3rJmwHBtCpDC+8r8sn9nscFzG+ESkBis9JVACf1CUxhRbwD95lKWptwG5 2RuCPCISqNwa71wa/twNPCdx3m4c5ehTiIgD6hvMKmMbdbqK5OiHa1Zb3rn0pVoMqiksW5l+X0CbO Y0/FG1mjc98IQj2KI57A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQEeW-00060f-Eu; Thu, 31 Oct 2019 17:54:32 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQEeT-00060H-Sq for linux-nvme@lists.infradead.org; Thu, 31 Oct 2019 17:54:31 +0000 Received: by mail-pf1-x443.google.com with SMTP id c13so4864790pfp.5 for ; Thu, 31 Oct 2019 10:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kz/FCtj2PF4gxBdcIEXsfbI3RO9QLhbBmTNUon1wjBw=; b=EST86sBDiClx5CY1TbLmQF3b5slqCpp8BgmFv4VLc7H8M+gWS4n0FyV7tJl/SNCedP x+RIjeA/vG/S844grBTtcbmvcnGfRwRgmdoeUSOCuvmE+08qpPH2Uew7FU/IbFCTaNXV NpOGNwzYATmj3M6w2DDZ86mwPurmvgfdrfNEb96YHl6L+leWAc3qLdpRuuod4c22wjbZ dbUTVnX4+UJkxWXqRXIFlGytjAhwWnqjf5mYXYr11Z9rB+b6yF1fgfpPI7azzX29zQ1x SwZE+rDreClmrLI3TroX6/PZGpkboSq9KsDv1ati/aajpk7JNZBDXS2U5Ed8zkFTM/Kz dc/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=kz/FCtj2PF4gxBdcIEXsfbI3RO9QLhbBmTNUon1wjBw=; b=cYTTN/gegB7Ujpq+Nb8TIZ57NtnfUrdyQx+I5mekNxaN7TGN7jFFW7C7RpOSj2h9A/ vB4ajlbXmBsTKcqxmWWffW4V3R49JPslJ6aabg6fwiJqD9bFv4dNH2gprqCqiP3AxQHD it2mKGcfJX6yQVyTtr18Jl39AOnkvcIXMpNv3GEpO4YtuXUA5H2EmnZuhOext7uQJT2Z kVNy8WPMJ2CqLR9umbTeb5xddZ5xSLSjcv8UlrUHvAst9ZphnIg09xE4xYx3f+9Whd1D 51KQ6degfusO7LEDKSsAIIu9tDg3FfUVJPzF7yTdhfYkDazihrYtS9XuwlLqbaVQdikI RQXg== X-Gm-Message-State: APjAAAVRcya3hssNjqPk3rz1QM2yCxNxsBH9jR2Z3SStHWOngLXDlYiQ FrAA3FnHpLflwfdTtqY20UA= X-Google-Smtp-Source: APXvYqzPEkkqE2XdSGKjYOFeXoi4DM/BqcfRzbuG+/8iiXNsBYnzSNslwun+1RAYM3et3ScThxGGzw== X-Received: by 2002:a63:1a46:: with SMTP id a6mr7805345pgm.3.1572544467672; Thu, 31 Oct 2019 10:54:27 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j7sm3523599pgl.38.2019.10.31.10.54.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Oct 2019 10:54:26 -0700 (PDT) Date: Thu, 31 Oct 2019 10:54:25 -0700 From: Guenter Roeck To: Christoph Hellwig Subject: Re: [PATCH v2] nvme: Add hardware monitoring support Message-ID: <20191031175425.GA25602@roeck-us.net> References: <20191029223214.18889-1-linux@roeck-us.net> <20191031134549.GB4763@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191031134549.GB4763@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_105429_932687_02009894 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Linux PM , Akinobu Mita , linux-nvme@lists.infradead.org, LKML , Jens Axboe , Keith Busch , Chris Healy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 31, 2019 at 02:45:49PM +0100, Christoph Hellwig wrote: > On Wed, Oct 30, 2019 at 07:20:37PM -0700, Guenter Roeck wrote: > >> The nvme_init_identify() can be called multiple time in nvme ctrl's > >> lifetime (e.g 'nvme reset /dev/nvme*' or suspend/resume paths), so > >> should we need to prevent nvme_hwmon_init() from registering hwmon > >> device more than twice? > >> > >> In the nvme thermal zone patchset[1], thernal zone is registered in > >> nvme_init_identify and unregistered in nvme_stop_ctrl(). > >> > > > > Doesn't that mean that the initialization should happen in nvme_start_ctrl() > > and not here ? > > I think calling it from nvme_init_identify is fine, it just needs to > be in the "if (!ctrl->identified)" section of that function. Excellent, I'll do that. Thanks a lot for the hint! Guenter _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FA8CA9ECB for ; Thu, 31 Oct 2019 17:54:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCC5C2086D for ; Thu, 31 Oct 2019 17:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EST86sBD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729073AbfJaRya (ORCPT ); Thu, 31 Oct 2019 13:54:30 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40879 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbfJaRya (ORCPT ); Thu, 31 Oct 2019 13:54:30 -0400 Received: by mail-pf1-f195.google.com with SMTP id r4so4862345pfl.7; Thu, 31 Oct 2019 10:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kz/FCtj2PF4gxBdcIEXsfbI3RO9QLhbBmTNUon1wjBw=; b=EST86sBDiClx5CY1TbLmQF3b5slqCpp8BgmFv4VLc7H8M+gWS4n0FyV7tJl/SNCedP x+RIjeA/vG/S844grBTtcbmvcnGfRwRgmdoeUSOCuvmE+08qpPH2Uew7FU/IbFCTaNXV NpOGNwzYATmj3M6w2DDZ86mwPurmvgfdrfNEb96YHl6L+leWAc3qLdpRuuod4c22wjbZ dbUTVnX4+UJkxWXqRXIFlGytjAhwWnqjf5mYXYr11Z9rB+b6yF1fgfpPI7azzX29zQ1x SwZE+rDreClmrLI3TroX6/PZGpkboSq9KsDv1ati/aajpk7JNZBDXS2U5Ed8zkFTM/Kz dc/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=kz/FCtj2PF4gxBdcIEXsfbI3RO9QLhbBmTNUon1wjBw=; b=Zw3ydVs4mPPVGreKYSAOPbJPczc/UpOsqj2vLifZRouQthVSFDvlydlsKoF2YXISM8 1upCHH/AoGzNslJWL1UIIm/dPJl0VLP132H/39FLIIozp5GAYexsO2KmtXNXJIhc1wzZ gR6zuF7zP9dvAYyF2q85a4adCOw40J/nir/DU1jV55VMe4s+EtIIW0cl1hlw21GMzj/G EgK0hAgkUKFp4qVH2vBmx74IATBkBU/FLu5FZrIcSZfQ6TTxRzV25D5PzgskWe04WeYR jvx3uVNrkxxitkSyPzlZSmIvjnR2g/9KMoksZ4Rq486RTXREuo+gkCwVOV8bqwGU3R5d QsBQ== X-Gm-Message-State: APjAAAUERY3z1V10ECJa85Wi4RbCR6yGPqUu938DZNtJ0qCIdYM2hM0h CV/kmjYsiaVwV94kbt7aeHY= X-Google-Smtp-Source: APXvYqzPEkkqE2XdSGKjYOFeXoi4DM/BqcfRzbuG+/8iiXNsBYnzSNslwun+1RAYM3et3ScThxGGzw== X-Received: by 2002:a63:1a46:: with SMTP id a6mr7805345pgm.3.1572544467672; Thu, 31 Oct 2019 10:54:27 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j7sm3523599pgl.38.2019.10.31.10.54.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Oct 2019 10:54:26 -0700 (PDT) Date: Thu, 31 Oct 2019 10:54:25 -0700 From: Guenter Roeck To: Christoph Hellwig Cc: Akinobu Mita , Keith Busch , Jens Axboe , Sagi Grimberg , LKML , linux-nvme@lists.infradead.org, Linux PM , Chris Healy Subject: Re: [PATCH v2] nvme: Add hardware monitoring support Message-ID: <20191031175425.GA25602@roeck-us.net> References: <20191029223214.18889-1-linux@roeck-us.net> <20191031134549.GB4763@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031134549.GB4763@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Oct 31, 2019 at 02:45:49PM +0100, Christoph Hellwig wrote: > On Wed, Oct 30, 2019 at 07:20:37PM -0700, Guenter Roeck wrote: > >> The nvme_init_identify() can be called multiple time in nvme ctrl's > >> lifetime (e.g 'nvme reset /dev/nvme*' or suspend/resume paths), so > >> should we need to prevent nvme_hwmon_init() from registering hwmon > >> device more than twice? > >> > >> In the nvme thermal zone patchset[1], thernal zone is registered in > >> nvme_init_identify and unregistered in nvme_stop_ctrl(). > >> > > > > Doesn't that mean that the initialization should happen in nvme_start_ctrl() > > and not here ? > > I think calling it from nvme_init_identify is fine, it just needs to > be in the "if (!ctrl->identified)" section of that function. Excellent, I'll do that. Thanks a lot for the hint! Guenter