From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Fri, 01 Nov 2019 08:58:03 +0000 Subject: Re: [PATCH v7 0/9] backlight: gpio: simplify the driver Message-Id: <20191101085803.GD5700@dell> List-Id: References: <20191022083630.28175-1-brgl@bgdev.pl> <20191023155941.q563d3cfizre4zvt@holly.lan> <20191024064726.GB15843@dell> <20191024071703.6keoebzlfnn2qmyd@uno.localdomain> In-Reply-To: <20191024071703.6keoebzlfnn2qmyd@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jacopo Mondi Cc: Daniel Thompson , Rich Felker , Yoshinori Sato , Bartlomiej Zolnierkiewicz , Jingoo Han , Bartosz Golaszewski , Linux-sh list , Linux Kernel Mailing List , "open list:DRM PANEL DRIVERS" , Bartosz Golaszewski , Linux Fbdev development list , Andy Shevchenko On Thu, 24 Oct 2019, Jacopo Mondi wrote: > Hello, > > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote: > > On Wed, 23 Oct 2019, Daniel Thompson wrote: > > > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote: > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski napisał(a): > > > > > > > > > > From: Bartosz Golaszewski > > > > > > > > > > While working on my other series related to gpio-backlight[1] I noticed > > > > > that we could simplify the driver if we made the only user of platform > > > > > data use GPIO lookups and device properties. This series tries to do > > > > > that. > > > > > > > > > > First two patches contain minor fixes. Third patch makes the driver > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data > > > > > fields. Last two patches contain additional improvements for the GPIO > > > > > backlight driver while we're already modifying it. > > > > > > > > > > I don't have access to this HW but hopefully this works. Only compile > > > > > tested. > > > > > > > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > > > > > > > v1 -> v2: > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > > > > - added additional two patches with minor improvements > > > > > > > > > > v2 -> v3: > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > > > > > > > v3 -> v4: > > > > > - rebased on top of v5.4-rc1 > > > > > - removed changes that are no longer relevant after commit ec665b756e6f > > > > > ("backlight: gpio-backlight: Correct initial power state handling") > > > > > - added patch 7/7 > > > > > > > > > > v4 -> v5: > > > > > - in patch 7/7: added a comment replacing the name of the function being > > > > > pulled into probe() > > > > > > > > > > v5 -> v6: > > > > > - added a patch making the driver explicitly set the direction of the GPIO > > > > > to output > > > > > - added a patch removing a redundant newline > > > > > > > > > > v6 -> v7: > > > > > - renamed the function calculating the new GPIO value for status update > > > > > - collected more tags > > > > > > > > > > Bartosz Golaszewski (9): > > > > > backlight: gpio: remove unneeded include > > > > > backlight: gpio: remove stray newline > > > > > backlight: gpio: explicitly set the direction of the GPIO > > > > > sh: ecovec24: add additional properties to the backlight device > > > > > backlight: gpio: simplify the platform data handling > > > > > sh: ecovec24: don't set unused fields in platform data > > > > > backlight: gpio: remove unused fields from platform data > > > > > backlight: gpio: use a helper variable for &pdev->dev > > > > > backlight: gpio: pull gpio_backlight_initial_power_state() into probe > > > > > > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 +++-- > > > > > drivers/video/backlight/gpio_backlight.c | 128 +++++++------------ > > > > > include/linux/platform_data/gpio_backlight.h | 3 - > > > > > 3 files changed, 69 insertions(+), 95 deletions(-) > > > > > > > > > > > > > > > > > > Lee, Daniel, Jingoo, > > > > > > > > Jacopo is travelling until November 1st and won't be able to test this > > > > again before this date. Do you think you can pick it up and in case > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it > > > > doesn't miss another merge window? > > > > November 1st (-rc6) will be fine. > > > > I'd rather apply it late-tested than early-non-tested. > > > > Hopefully Jacopo can prioritise testing this on Thursday or Friday, > > since Monday will be -rc7 which is really cutting it fine. > > I'll do my best, I'll get home Friday late afternoon :) Welcome home! Just a little reminder in your inbox. TIA. :) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 0/9] backlight: gpio: simplify the driver Date: Fri, 1 Nov 2019 08:58:03 +0000 Message-ID: <20191101085803.GD5700@dell> References: <20191022083630.28175-1-brgl@bgdev.pl> <20191023155941.q563d3cfizre4zvt@holly.lan> <20191024064726.GB15843@dell> <20191024071703.6keoebzlfnn2qmyd@uno.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 240056E1F9 for ; Fri, 1 Nov 2019 08:58:07 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id e6so7128775wrw.1 for ; Fri, 01 Nov 2019 01:58:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191024071703.6keoebzlfnn2qmyd@uno.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacopo Mondi Cc: Daniel Thompson , Rich Felker , Yoshinori Sato , Bartlomiej Zolnierkiewicz , Jingoo Han , Bartosz Golaszewski , Linux-sh list , Linux Kernel Mailing List , "open list:DRM PANEL DRIVERS" , Bartosz Golaszewski , Linux Fbdev development list , Andy Shevchenko List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyNCBPY3QgMjAxOSwgSmFjb3BvIE1vbmRpIHdyb3RlOgoKPiBIZWxsbywKPiAKPiBP biBUaHUsIE9jdCAyNCwgMjAxOSBhdCAwNzo0NzoyNkFNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6 Cj4gPiBPbiBXZWQsIDIzIE9jdCAyMDE5LCBEYW5pZWwgVGhvbXBzb24gd3JvdGU6Cj4gPgo+ID4g PiBPbiBUdWUsIE9jdCAyMiwgMjAxOSBhdCAxMToyOTo1NEFNICswMjAwLCBCYXJ0b3N6IEdvbGFz emV3c2tpIHdyb3RlOgo+ID4gPiA+IHd0LiwgMjIgcGHFuiAyMDE5IG8gMTA6MzYgQmFydG9zeiBH b2xhc3pld3NraSA8YnJnbEBiZ2Rldi5wbD4gbmFwaXNhxYIoYSk6Cj4gPiA+ID4gPgo+ID4gPiA+ ID4gRnJvbTogQmFydG9zeiBHb2xhc3pld3NraSA8YmdvbGFzemV3c2tpQGJheWxpYnJlLmNvbT4K PiA+ID4gPiA+Cj4gPiA+ID4gPiBXaGlsZSB3b3JraW5nIG9uIG15IG90aGVyIHNlcmllcyByZWxh dGVkIHRvIGdwaW8tYmFja2xpZ2h0WzFdIEkgbm90aWNlZAo+ID4gPiA+ID4gdGhhdCB3ZSBjb3Vs ZCBzaW1wbGlmeSB0aGUgZHJpdmVyIGlmIHdlIG1hZGUgdGhlIG9ubHkgdXNlciBvZiBwbGF0Zm9y bQo+ID4gPiA+ID4gZGF0YSB1c2UgR1BJTyBsb29rdXBzIGFuZCBkZXZpY2UgcHJvcGVydGllcy4g VGhpcyBzZXJpZXMgdHJpZXMgdG8gZG8KPiA+ID4gPiA+IHRoYXQuCj4gPiA+ID4gPgo+ID4gPiA+ ID4gRmlyc3QgdHdvIHBhdGNoZXMgY29udGFpbiBtaW5vciBmaXhlcy4gVGhpcmQgcGF0Y2ggbWFr ZXMgdGhlIGRyaXZlcgo+ID4gPiA+ID4gZXhwbGljaXRseSBkcml2ZSB0aGUgR1BJTyBsaW5lLiBG b3VydGggcGF0Y2ggYWRkcyBhbGwgbmVjZXNzYXJ5IGRhdGEKPiA+ID4gPiA+IHN0cnVjdHVyZXMg dG8gZWNvdmVjMjQuIFBhdGNoIDUvOSB1bmlmaWVzIG11Y2ggb2YgdGhlIGNvZGUgZm9yIGJvdGgK PiA+ID4gPiA+IHBkYXRhIGFuZCBub24tcGRhdGEgY2FzZXMuIFBhdGNoZXMgNi03LzkgcmVtb3Zl IHVudXNlZCBwbGF0Zm9ybSBkYXRhCj4gPiA+ID4gPiBmaWVsZHMuIExhc3QgdHdvIHBhdGNoZXMg Y29udGFpbiBhZGRpdGlvbmFsIGltcHJvdmVtZW50cyBmb3IgdGhlIEdQSU8KPiA+ID4gPiA+IGJh Y2tsaWdodCBkcml2ZXIgd2hpbGUgd2UncmUgYWxyZWFkeSBtb2RpZnlpbmcgaXQuCj4gPiA+ID4g Pgo+ID4gPiA+ID4gSSBkb24ndCBoYXZlIGFjY2VzcyB0byB0aGlzIEhXIGJ1dCBob3BlZnVsbHkg dGhpcyB3b3Jrcy4gT25seSBjb21waWxlCj4gPiA+ID4gPiB0ZXN0ZWQuCj4gPiA+ID4gPgo+ID4g PiA+ID4gWzFdIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE5LzYvMjUvOTAwCj4gPiA+ID4gPgo+ ID4gPiA+ID4gdjEgLT4gdjI6Cj4gPiA+ID4gPiAtIHJlYmFzZWQgb24gdG9wIG9mIHY1LjMtcmMx IGFuZCBhZGp1c3RlZCB0byB0aGUgcmVjZW50IGNoYW5nZXMgZnJvbSBBbmR5Cj4gPiA+ID4gPiAt IGFkZGVkIGFkZGl0aW9uYWwgdHdvIHBhdGNoZXMgd2l0aCBtaW5vciBpbXByb3ZlbWVudHMKPiA+ ID4gPiA+Cj4gPiA+ID4gPiB2MiAtPiB2MzoKPiA+ID4gPiA+IC0gaW4gcGF0Y2ggNy83OiB1c2Vk IGluaXRpYWxpemVycyB0byBzZXQgdmFsdWVzIGZvciBwZGF0YSBhbmQgZGV2IGxvY2FsIHZhcnMK PiA+ID4gPiA+Cj4gPiA+ID4gPiB2MyAtPiB2NDoKPiA+ID4gPiA+IC0gcmViYXNlZCBvbiB0b3Ag b2YgdjUuNC1yYzEKPiA+ID4gPiA+IC0gcmVtb3ZlZCBjaGFuZ2VzIHRoYXQgYXJlIG5vIGxvbmdl ciByZWxldmFudCBhZnRlciBjb21taXQgZWM2NjViNzU2ZTZmCj4gPiA+ID4gPiAgICgiYmFja2xp Z2h0OiBncGlvLWJhY2tsaWdodDogQ29ycmVjdCBpbml0aWFsIHBvd2VyIHN0YXRlIGhhbmRsaW5n IikKPiA+ID4gPiA+IC0gYWRkZWQgcGF0Y2ggNy83Cj4gPiA+ID4gPgo+ID4gPiA+ID4gdjQgLT4g djU6Cj4gPiA+ID4gPiAtIGluIHBhdGNoIDcvNzogYWRkZWQgYSBjb21tZW50IHJlcGxhY2luZyB0 aGUgbmFtZSBvZiB0aGUgZnVuY3Rpb24gYmVpbmcKPiA+ID4gPiA+ICAgcHVsbGVkIGludG8gcHJv YmUoKQo+ID4gPiA+ID4KPiA+ID4gPiA+IHY1IC0+IHY2Ogo+ID4gPiA+ID4gLSBhZGRlZCBhIHBh dGNoIG1ha2luZyB0aGUgZHJpdmVyIGV4cGxpY2l0bHkgc2V0IHRoZSBkaXJlY3Rpb24gb2YgdGhl IEdQSU8KPiA+ID4gPiA+ICAgdG8gb3V0cHV0Cj4gPiA+ID4gPiAtIGFkZGVkIGEgcGF0Y2ggcmVt b3ZpbmcgYSByZWR1bmRhbnQgbmV3bGluZQo+ID4gPiA+ID4KPiA+ID4gPiA+IHY2IC0+IHY3Ogo+ ID4gPiA+ID4gLSByZW5hbWVkIHRoZSBmdW5jdGlvbiBjYWxjdWxhdGluZyB0aGUgbmV3IEdQSU8g dmFsdWUgZm9yIHN0YXR1cyB1cGRhdGUKPiA+ID4gPiA+IC0gY29sbGVjdGVkIG1vcmUgdGFncwo+ ID4gPiA+ID4KPiA+ID4gPiA+IEJhcnRvc3ogR29sYXN6ZXdza2kgKDkpOgo+ID4gPiA+ID4gICBi YWNrbGlnaHQ6IGdwaW86IHJlbW92ZSB1bm5lZWRlZCBpbmNsdWRlCj4gPiA+ID4gPiAgIGJhY2ts aWdodDogZ3BpbzogcmVtb3ZlIHN0cmF5IG5ld2xpbmUKPiA+ID4gPiA+ICAgYmFja2xpZ2h0OiBn cGlvOiBleHBsaWNpdGx5IHNldCB0aGUgZGlyZWN0aW9uIG9mIHRoZSBHUElPCj4gPiA+ID4gPiAg IHNoOiBlY292ZWMyNDogYWRkIGFkZGl0aW9uYWwgcHJvcGVydGllcyB0byB0aGUgYmFja2xpZ2h0 IGRldmljZQo+ID4gPiA+ID4gICBiYWNrbGlnaHQ6IGdwaW86IHNpbXBsaWZ5IHRoZSBwbGF0Zm9y bSBkYXRhIGhhbmRsaW5nCj4gPiA+ID4gPiAgIHNoOiBlY292ZWMyNDogZG9uJ3Qgc2V0IHVudXNl ZCBmaWVsZHMgaW4gcGxhdGZvcm0gZGF0YQo+ID4gPiA+ID4gICBiYWNrbGlnaHQ6IGdwaW86IHJl bW92ZSB1bnVzZWQgZmllbGRzIGZyb20gcGxhdGZvcm0gZGF0YQo+ID4gPiA+ID4gICBiYWNrbGln aHQ6IGdwaW86IHVzZSBhIGhlbHBlciB2YXJpYWJsZSBmb3IgJnBkZXYtPmRldgo+ID4gPiA+ID4g ICBiYWNrbGlnaHQ6IGdwaW86IHB1bGwgZ3Bpb19iYWNrbGlnaHRfaW5pdGlhbF9wb3dlcl9zdGF0 ZSgpIGludG8gcHJvYmUKPiA+ID4gPiA+Cj4gPiA+ID4gPiAgYXJjaC9zaC9ib2FyZHMvbWFjaC1l Y292ZWMyNC9zZXR1cC5jICAgICAgICAgfCAgMzMgKysrLS0KPiA+ID4gPiA+ICBkcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9ncGlvX2JhY2tsaWdodC5jICAgICB8IDEyOCArKysrKysrLS0tLS0tLS0t LS0tCj4gPiA+ID4gPiAgaW5jbHVkZS9saW51eC9wbGF0Zm9ybV9kYXRhL2dwaW9fYmFja2xpZ2h0 LmggfCAgIDMgLQo+ID4gPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNjkgaW5zZXJ0aW9ucygrKSwg OTUgZGVsZXRpb25zKC0pCj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPgo+ID4gPiA+IExlZSwg RGFuaWVsLCBKaW5nb28sCj4gPiA+ID4KPiA+ID4gPiBKYWNvcG8gaXMgdHJhdmVsbGluZyB1bnRp bCBOb3ZlbWJlciAxc3QgYW5kIHdvbid0IGJlIGFibGUgdG8gdGVzdCB0aGlzCj4gPiA+ID4gYWdh aW4gYmVmb3JlIHRoaXMgZGF0ZS4gRG8geW91IHRoaW5rIHlvdSBjYW4gcGljayBpdCB1cCBhbmQg aW4gY2FzZQo+ID4gPiA+IGFueXRoaW5nJ3MgYnJva2VuIG9uIFNILCB3ZSBjYW4gZml4IGl0IGFm dGVyIHY1LjUtcmMxLCBzbyB0aGF0IGl0Cj4gPiA+ID4gZG9lc24ndCBtaXNzIGFub3RoZXIgbWVy Z2Ugd2luZG93Pwo+ID4KPiA+IE5vdmVtYmVyIDFzdCAoLXJjNikgd2lsbCBiZSBmaW5lLgo+ID4K PiA+IEknZCByYXRoZXIgYXBwbHkgaXQgbGF0ZS10ZXN0ZWQgdGhhbiBlYXJseS1ub24tdGVzdGVk Lgo+ID4KPiA+IEhvcGVmdWxseSBKYWNvcG8gY2FuIHByaW9yaXRpc2UgdGVzdGluZyB0aGlzIG9u IFRodXJzZGF5IG9yIEZyaWRheSwKPiA+IHNpbmNlIE1vbmRheSB3aWxsIGJlIC1yYzcgd2hpY2gg aXMgcmVhbGx5IGN1dHRpbmcgaXQgZmluZS4KPiAKPiBJJ2xsIGRvIG15IGJlc3QsIEknbGwgZ2V0 IGhvbWUgRnJpZGF5IGxhdGUgYWZ0ZXJub29uIDopCgpXZWxjb21lIGhvbWUhCgpKdXN0IGEgbGl0 dGxlIHJlbWluZGVyIGluIHlvdXIgaW5ib3guIFRJQS4gOikKCi0tIApMZWUgSm9uZXMgW+adjueQ vOaWr10KTGluYXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB629CA9ECF for ; Fri, 1 Nov 2019 08:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7CC0204FD for ; Fri, 1 Nov 2019 08:58:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="svMRcQ9v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbfKAI6J (ORCPT ); Fri, 1 Nov 2019 04:58:09 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36943 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfKAI6J (ORCPT ); Fri, 1 Nov 2019 04:58:09 -0400 Received: by mail-wr1-f67.google.com with SMTP id t1so3033564wrv.4 for ; Fri, 01 Nov 2019 01:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=S5fQT2eVO9V38Zm9JZGmC3M3bk7YmWSMdjQ7Ok2mRcE=; b=svMRcQ9vBjrXT2qn/6kethfQvV0UlAW5sEgQDR41qIHly1Y8PT1R9cce8OhGLd23tx 8OoR73wILPiH79hKzZCAP4sQknRdUDbuhN75ObUIOZBq09vMSCRi22PnDvfGt/T0EhnD U5/eHFT8izrZnKoCnfjiweDd96fr0mvLCl5r8+vViQtyq+6hcMM8SPjXuYD3mZMmj6T9 wacRNcNQzaoyxuCBaFRrC4aQEkNk5mG1x3+V5UrYyc5eZoMYWBGjYGTLOu01I/64e0c3 INlnHrvci6GbXLmUf64Lhq54JPwhwZOI90GH32o9yIvWsKOhBmPKzkWv1ln45tHgT0p1 VWrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=S5fQT2eVO9V38Zm9JZGmC3M3bk7YmWSMdjQ7Ok2mRcE=; b=UGCb56Yn5l2ZbqSjSg6xuvdHePemAw0YxkGXhCGULO6RxnAVP+5a6dmgUuYWEJQ6dZ 1bq/yYaR2JjZcvWzRZ8uEdPjkmFs2pmJHMEam2yqt4Z9GETfKIaCZd8Od1b9r0SPcu4C u033J1I+aIALP5/+OhkIFx9PW3CthyHQTfbxjfjxxFmMpLID8L1MYHlHdSkZ5jjeE/5p z2TJldMgXz7WPjHpdUCpQQAGUNRTvwhe8MPr+Y5dpE84zpWDNjJJD63W0dB4hHRqosNr C/aJ9/5/PGE3th2FyhQOTo9HFhHYesrBfcvG6wMQEZXvgi49QRLFKQvKBYjOx9Cum/7Q aLmQ== X-Gm-Message-State: APjAAAWmoT/PJ01d5LMtCqVFX/5II1AGM56QqBkyRTh31BV0A/UTOnKO HS2TxJIv5VYXNmo0ryCI3HbRMg== X-Google-Smtp-Source: APXvYqx/0D/E3fqHGg3SO471Ql1SFjgo2/8jy1O0UmD3LhH76T/0FxaRwKHUwv0G597dXLhvqq/DfA== X-Received: by 2002:adf:f048:: with SMTP id t8mr5980197wro.237.1572598685466; Fri, 01 Nov 2019 01:58:05 -0700 (PDT) Received: from dell ([2.31.163.64]) by smtp.gmail.com with ESMTPSA id s21sm9001511wrb.31.2019.11.01.01.58.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 01:58:04 -0700 (PDT) Date: Fri, 1 Nov 2019 08:58:03 +0000 From: Lee Jones To: Jacopo Mondi Cc: Daniel Thompson , Bartosz Golaszewski , Yoshinori Sato , Rich Felker , Jingoo Han , Bartlomiej Zolnierkiewicz , Linus Walleij , Andy Shevchenko , Linux-sh list , Linux Kernel Mailing List , "open list:DRM PANEL DRIVERS" , Linux Fbdev development list , Bartosz Golaszewski Subject: Re: [PATCH v7 0/9] backlight: gpio: simplify the driver Message-ID: <20191101085803.GD5700@dell> References: <20191022083630.28175-1-brgl@bgdev.pl> <20191023155941.q563d3cfizre4zvt@holly.lan> <20191024064726.GB15843@dell> <20191024071703.6keoebzlfnn2qmyd@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191024071703.6keoebzlfnn2qmyd@uno.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Oct 2019, Jacopo Mondi wrote: > Hello, > > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote: > > On Wed, 23 Oct 2019, Daniel Thompson wrote: > > > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote: > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski napisał(a): > > > > > > > > > > From: Bartosz Golaszewski > > > > > > > > > > While working on my other series related to gpio-backlight[1] I noticed > > > > > that we could simplify the driver if we made the only user of platform > > > > > data use GPIO lookups and device properties. This series tries to do > > > > > that. > > > > > > > > > > First two patches contain minor fixes. Third patch makes the driver > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data > > > > > fields. Last two patches contain additional improvements for the GPIO > > > > > backlight driver while we're already modifying it. > > > > > > > > > > I don't have access to this HW but hopefully this works. Only compile > > > > > tested. > > > > > > > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > > > > > > > v1 -> v2: > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > > > > - added additional two patches with minor improvements > > > > > > > > > > v2 -> v3: > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > > > > > > > v3 -> v4: > > > > > - rebased on top of v5.4-rc1 > > > > > - removed changes that are no longer relevant after commit ec665b756e6f > > > > > ("backlight: gpio-backlight: Correct initial power state handling") > > > > > - added patch 7/7 > > > > > > > > > > v4 -> v5: > > > > > - in patch 7/7: added a comment replacing the name of the function being > > > > > pulled into probe() > > > > > > > > > > v5 -> v6: > > > > > - added a patch making the driver explicitly set the direction of the GPIO > > > > > to output > > > > > - added a patch removing a redundant newline > > > > > > > > > > v6 -> v7: > > > > > - renamed the function calculating the new GPIO value for status update > > > > > - collected more tags > > > > > > > > > > Bartosz Golaszewski (9): > > > > > backlight: gpio: remove unneeded include > > > > > backlight: gpio: remove stray newline > > > > > backlight: gpio: explicitly set the direction of the GPIO > > > > > sh: ecovec24: add additional properties to the backlight device > > > > > backlight: gpio: simplify the platform data handling > > > > > sh: ecovec24: don't set unused fields in platform data > > > > > backlight: gpio: remove unused fields from platform data > > > > > backlight: gpio: use a helper variable for &pdev->dev > > > > > backlight: gpio: pull gpio_backlight_initial_power_state() into probe > > > > > > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 +++-- > > > > > drivers/video/backlight/gpio_backlight.c | 128 +++++++------------ > > > > > include/linux/platform_data/gpio_backlight.h | 3 - > > > > > 3 files changed, 69 insertions(+), 95 deletions(-) > > > > > > > > > > > > > > > > > > Lee, Daniel, Jingoo, > > > > > > > > Jacopo is travelling until November 1st and won't be able to test this > > > > again before this date. Do you think you can pick it up and in case > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it > > > > doesn't miss another merge window? > > > > November 1st (-rc6) will be fine. > > > > I'd rather apply it late-tested than early-non-tested. > > > > Hopefully Jacopo can prioritise testing this on Thursday or Friday, > > since Monday will be -rc7 which is really cutting it fine. > > I'll do my best, I'll get home Friday late afternoon :) Welcome home! Just a little reminder in your inbox. TIA. :) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog