From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 529BFCA9ECF for ; Fri, 1 Nov 2019 09:08:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 209A72080F for ; Fri, 1 Nov 2019 09:08:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SQsu0lHs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SsOvMknt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 209A72080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DgXC2eGyslORkIABIcqxcvM1y6Xyr7sn05KHur40wRo=; b=SQsu0lHsOKh5J2 7qSXuW6OChx5GrTAAjeO+yrSrJArXwMbpD83xQPjnxkfE8Xq6ozCTzQMc1JTnxE6EGsJ1HGKI5c/S xIlKbfU8wnIMPJSiXdF9Gh+Tjz+0f1QhwESBPGXl5MvP+I5LLZv28NEf/HT07KKGjDb6SrlD7MffE We3giIYQXW8dFijVHnDEqFqgVUxK+SxyHFhlmnbjloOVoI7AV8JCkyghC4BGsC/XN4iKJt/+Q/aJR LErFrxIwqnuj1tdRHBQyvf1qbhhu8PvO/4qV+rGOFqm4b7Hg4N12U3R78Ezz5/5FhG9Tzt/WtXl7g siMZcpsM7AgOrTbzHT6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQSuU-0000zD-0H; Fri, 01 Nov 2019 09:07:58 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQSuR-0000yr-8N for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2019 09:07:56 +0000 Received: by mail-wr1-x441.google.com with SMTP id o28so8972548wro.7 for ; Fri, 01 Nov 2019 02:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=SsOvMknt1CgP4cY/63FFDv1ZR8D0n+krXXaB5s5xMmzPjmA9CkbyU0N+Ejr+ciaV13 gR97mDAeA039WaHynZ8ezlNuHhZQpK7DX9WAu7zzrQ6a0270jypZhco6I/26gnBb2jh2 Y5qUbR05PW9qioLG7ivWKF0bD/CUzuo0sU1VYiONAu+QAXowSbW8Fxf6KH06C6W/r2jK bp6z+v64ZuLc8XEj9DutDiV/dxcUXN++oy0ASMO2W98M1+gpyHAx46Ax3HGa1hz9IQlj sP1CDeTapR1u4KlRtlTZFoUr2PjV8hSeTspziMOPtFRzPizoOin36lQ5OFFG/NPh3lFB 5+WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=hLPpnliYcfMuvD+OryVg7JI4ShA2G7P4culqVmYkZQ1vcpOpuydXGPODs1I1T7OUpi RxlwxZgMz2lTLMNhgcU9h3P3gr4i/2X2Ra5FeeYYMH3QXpXnV4W++vVCJ0/mHqBfmpz4 HED4fKKIK0KFMi4iHfIv/C9GeT6RNHAh+j639C6Lwci1i5UAHrR8V4zs3YjSpwZVOIhB tEbO4VGe1pS2SksfMf/n2nwqjKabV+7JeWduxVlYjtMpmnbmFz58kYZRpg27uHB1iIza u++hIfba/4itoiB0mXnSu6vlSUg8KY11O9uqDlP2sVNbJlKJms14Hnoie1Ft8IdAjbnI bqZw== X-Gm-Message-State: APjAAAUSWtbMKxmVfoSvf0ahzRUeOSiOdhuonoNGrDJFuwqzrOIMQPeL nBL9gQXCAgXZDiqYwhjbzYOJbg== X-Google-Smtp-Source: APXvYqyfoMw7OuR1oI2KzzBgFBcp8lQVObfEgf4rxJio3Ka98Rj3xERF8zwG/TDC9/tvnJDSE9vsFw== X-Received: by 2002:a05:6000:18d:: with SMTP id p13mr9509311wrx.396.1572599273351; Fri, 01 Nov 2019 02:07:53 -0700 (PDT) Received: from dell ([2.31.163.64]) by smtp.gmail.com with ESMTPSA id n3sm6921838wrr.50.2019.11.01.02.07.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 02:07:52 -0700 (PDT) Date: Fri, 1 Nov 2019 09:07:51 +0000 From: Lee Jones To: Lubomir Rintel Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191101090751.GH5700@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021115339.GF4365@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191101_020755_301064_05D3CB96 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Arnd Bergmann , stephan@gerhold.net, Linus Walleij , Daniel Thompson , "linux-kernel@vger.kernel.org" , Mark Brown , Daniel Drake , Linux ARM , James Cameron Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMSBPY3QgMjAxOSwgTHVib21pciBSaW50ZWwgd3JvdGU6Cj4gT24gTW9uLCAyMDE5 LTEwLTIxIGF0IDEyOjUzICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBNb24sIDIxIE9j dCAyMDE5LCBMdWJvbWlyIFJpbnRlbCB3cm90ZToKPiA+IAo+ID4gPiBPbiBNb24sIDIwMTktMTAt MjEgYXQgMTM6MjkgKzAyMDAsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gPiA+ID4gT24gTW9uLCBP Y3QgMjEsIDIwMTkgYXQgMTI6NTggUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4g d3JvdGU6Cj4gPiA+ID4gPiBNRkQgY3VycmVudGx5IGhhcyBvbmUgb3Zlci1jb21wbGljYXRlZCB1 c2VyLiAgQ1M1NTM1IHVzZXMgYSBtaXh0dXJlIG9mCj4gPiA+ID4gPiBjZWxsIGNsb25pbmcsIHJl ZmVyZW5jZSBjb3VudGluZyBhbmQgc3Vic3lzdGVtLWxldmVsIGNhbGwtYmFja3MgdG8KPiA+ID4g PiA+IGFjaGlldmUgaXRzIGdvYWwgb2YgcmVxdWVzdGluZyBhbiBJTyBtZW1vcnkgcmVnaW9uIG9u bHkgb25jZSBhY3Jvc3MgMwo+ID4gPiA+ID4gY29uc3VtZXJzLiAgVGhlIHNhbWUgY2FuIGJlIGFj aGlldmVkIGJ5IGhhbmRsaW5nIHRoZSByZWdpb24gY2VudHJhbGx5Cj4gPiA+ID4gPiBkdXJpbmcg dGhlIHBhcmVudCBkZXZpY2UncyAucHJvYmUoKSBzZXF1ZW5jZS4gIFJlbGVhc2luZyBjYW4gYmUg aGFuZGVkCj4gPiA+ID4gPiBpbiBhIHNpbWlsYXIgd2F5IGR1cmluZyAucmVtb3ZlKCkuCj4gPiA+ ID4gPiAKPiA+ID4gPiA+IFdoaWxlIHdlJ3JlIGhlcmUsIHRha2UgdGhlIG9wcG9ydHVuaXR5IHRv IHByb3ZpZGUgc29tZSBjbGVhbi11cHMgYW5kCj4gPiA+ID4gPiBlcnJvciBjaGVja2luZyB0byBp c3N1ZXMgbm90aWNlZCBhbG9uZyB0aGUgd2F5Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGlzIGFs c28gcGF2ZXMgdGhlIHdheSBmb3IgY2xlYW4gY2VsbCBkaXNhYmxpbmcgdmlhIERldmljZSBUcmVl IGJlaW5nCj4gPiA+ID4gPiBkaXNjdXNzZWQgYXQgWzBdCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFsw XSBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOS8xMC8xOC82MTIuCj4gPiA+ID4gCj4gPiA+ID4g QXMgdGhlIENTNTUzNSBpcyBwcmltYXJpbHkgdXNlZCBvbiB0aGUgT0xQQyBYTzEsIGl0IHdvdWxk IGJlCj4gPiA+ID4gZ29vZCB0byBoYXZlIHNvbWVvbmUgdGVzdCB0aGUgc2VyaWVzIG9uIHN1Y2gg YSBtYWNoaW5lLgo+ID4gPiA+IAo+ID4gPiA+IEkndmUgYWRkZWQgYSBmZXcgcGVvcGxlIHRvIENj IHRoYXQgbWF5IGJlIGFibGUgdG8gaGVscCB0ZXN0IGl0LCBvcgo+ID4gPiA+IGtub3cgc29tZW9u ZSB3aG8gY2FuLgo+ID4gPiA+IAo+ID4gPiA+IEZvciB0aGUgYWN0dWFsIHBhdGNoZXMsIHNlZQo+ ID4gPiA+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvMjAxOTEwMjExMDU4MjIuMjAyNzEt MS1sZWUuam9uZXNAbGluYXJvLm9yZy9ULyN0Cj4gPiA+IAo+ID4gPiBUaGFua3MgZm9yIHRoZSBw b2ludGVyLiBJJ2QgYnkgaGFwcHkgdG8gdGVzdCB0aGlzLgo+ID4gPiAKPiA+ID4gV2hpY2ggdHJl ZSBkbyB0aGUgcGF0Y2hlcyBhcHBseSB0bz8KPiA+ID4gT3IsIGJldHRlciwgaXMgdGhlcmUgYSB0 cmVlIHdpdGggdGhlIHBhdGNoZXMgYXBwbGllZCB0aGF0IEkgY291bGQgdXNlPwo+ID4gCj4gPiBJ ZGVhbC4gIFRoYW5rIHlvdS4KPiA+IAo+ID4gaHR0cDovL2dpdC5saW5hcm8ub3JnL3Blb3BsZS9s ZWUuam9uZXMvbGludXguZ2l0L2xvZy8/aD10b3BpYy9tZmQtcmVtb3ZlLWNsb25lLWNzNTUzNS1t ZmQKPiAKPiBUaGFua3MuIE15IGJvb3QgYXR0ZW1wdCBlbmRzIHVwIGluIGEgcGFuaWMgWzFdOgoK TmV3IHBhdGNoZXMgaGF2ZSBiZWVuIGRyYWZ0ZWQsIHJldmlld2VkIGFuZCBwdXNoZWQgdG8gdGhl IHNhbWUgYnJhbmNoLgoKV291bGQgeW91IGJlIGtpbmQgZW5vdWdoIHRvIGJvb3QgdGVzdCB0aGVt IGZvciBtZSBwbGVhc2UgTHVibz8KClRJQS4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGlu YXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNv ZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBC bG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB4E2CA9ECF for ; Fri, 1 Nov 2019 09:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB5B92080F for ; Fri, 1 Nov 2019 09:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SsOvMknt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbfKAJHz (ORCPT ); Fri, 1 Nov 2019 05:07:55 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42306 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727026AbfKAJHz (ORCPT ); Fri, 1 Nov 2019 05:07:55 -0400 Received: by mail-wr1-f67.google.com with SMTP id a15so8975295wrf.9 for ; Fri, 01 Nov 2019 02:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=SsOvMknt1CgP4cY/63FFDv1ZR8D0n+krXXaB5s5xMmzPjmA9CkbyU0N+Ejr+ciaV13 gR97mDAeA039WaHynZ8ezlNuHhZQpK7DX9WAu7zzrQ6a0270jypZhco6I/26gnBb2jh2 Y5qUbR05PW9qioLG7ivWKF0bD/CUzuo0sU1VYiONAu+QAXowSbW8Fxf6KH06C6W/r2jK bp6z+v64ZuLc8XEj9DutDiV/dxcUXN++oy0ASMO2W98M1+gpyHAx46Ax3HGa1hz9IQlj sP1CDeTapR1u4KlRtlTZFoUr2PjV8hSeTspziMOPtFRzPizoOin36lQ5OFFG/NPh3lFB 5+WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=sSzw71KuirrOBmQvUAs+uePi0B/HarRTDyvXS6zJv1Qf+4qBhdW3E2H2a6X3UlaEsD u0JWx0N99FAf37B/9BH3djrFi7jXOEtgiDhzR6IAVPa+md3feLEJsKMJNwDWqSzgV0Uw 1lwjczCx84bRy9a5VJ2sbOrcUJN/fgZd8piNSx9r7jw29wi4SoQlzDgZkzQBhEMQmTyu tq3nMvqdkn6QsTVbdD2auxp1elxjMSuUDRWW2tIrSCEDtMHB0vU84pCsEoChh4A6ITiB Aqjjp5q2qQ/I9KH+9Dmkc+16+JdI4f4pJTarFd/VQ/k7gH5cIqNtjNgULZD7lkpMjgzT aRmg== X-Gm-Message-State: APjAAAWWqF7eeq2JB7FOro1h+k4QEg5uqT0FmMvu2HPzKfliN3Mz2/cU fFYVvuA3Lvzq3XMK8Cbnl6qREw== X-Google-Smtp-Source: APXvYqyfoMw7OuR1oI2KzzBgFBcp8lQVObfEgf4rxJio3Ka98Rj3xERF8zwG/TDC9/tvnJDSE9vsFw== X-Received: by 2002:a05:6000:18d:: with SMTP id p13mr9509311wrx.396.1572599273351; Fri, 01 Nov 2019 02:07:53 -0700 (PDT) Received: from dell ([2.31.163.64]) by smtp.gmail.com with ESMTPSA id n3sm6921838wrr.50.2019.11.01.02.07.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 02:07:52 -0700 (PDT) Date: Fri, 1 Nov 2019 09:07:51 +0000 From: Lee Jones To: Lubomir Rintel Cc: Arnd Bergmann , Daniel Thompson , Mark Brown , Linus Walleij , Barry Song , stephan@gerhold.net, "linux-kernel@vger.kernel.org" , Linux ARM , Daniel Drake , James Cameron Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191101090751.GH5700@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021115339.GF4365@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Lubomir Rintel wrote: > On Mon, 2019-10-21 at 12:53 +0100, Lee Jones wrote: > > On Mon, 21 Oct 2019, Lubomir Rintel wrote: > > > > > On Mon, 2019-10-21 at 13:29 +0200, Arnd Bergmann wrote: > > > > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > > > > MFD currently has one over-complicated user. CS5535 uses a mixture of > > > > > cell cloning, reference counting and subsystem-level call-backs to > > > > > achieve its goal of requesting an IO memory region only once across 3 > > > > > consumers. The same can be achieved by handling the region centrally > > > > > during the parent device's .probe() sequence. Releasing can be handed > > > > > in a similar way during .remove(). > > > > > > > > > > While we're here, take the opportunity to provide some clean-ups and > > > > > error checking to issues noticed along the way. > > > > > > > > > > This also paves the way for clean cell disabling via Device Tree being > > > > > discussed at [0] > > > > > > > > > > [0] https://lkml.org/lkml/2019/10/18/612. > > > > > > > > As the CS5535 is primarily used on the OLPC XO1, it would be > > > > good to have someone test the series on such a machine. > > > > > > > > I've added a few people to Cc that may be able to help test it, or > > > > know someone who can. > > > > > > > > For the actual patches, see > > > > https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t > > > > > > Thanks for the pointer. I'd by happy to test this. > > > > > > Which tree do the patches apply to? > > > Or, better, is there a tree with the patches applied that I could use? > > > > Ideal. Thank you. > > > > http://git.linaro.org/people/lee.jones/linux.git/log/?h=topic/mfd-remove-clone-cs5535-mfd > > Thanks. My boot attempt ends up in a panic [1]: New patches have been drafted, reviewed and pushed to the same branch. Would you be kind enough to boot test them for me please Lubo? TIA. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog