All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jamal Shareef <jamal.k.shareef@gmail.com>
Cc: outreachy-kernel@googlegroups.com, eric@anholt.net, wahrenst@gmx.net
Subject: Re: [PATCH v2 1/7] staging: vc04_services: Remove enum typedefs in vchi
Date: Fri, 1 Nov 2019 10:54:28 +0100	[thread overview]
Message-ID: <20191101095428.GA2786419@kroah.com> (raw)
In-Reply-To: <b422f45f5120ccdb8d83036a5340ba9eb92d3fec.1572585566.git.jamal.k.shareef@gmail.com>

On Thu, Oct 31, 2019 at 10:28:29PM -0700, Jamal Shareef wrote:
> -// Opaque type for a connection API
> -typedef struct opaque_vchi_connection_api_t VCHI_CONNECTION_API_T;
> -
> -// Opaque type for a message driver
> -typedef struct opaque_vchi_message_driver_t VCHI_MESSAGE_DRIVER_T;

These are not enum typedefs, as your subject line said you were doing :(

Please fix up and redo the series as a new version.

thanks,

greg k-h


  reply	other threads:[~2019-11-01  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01  5:28 [PATCH v2 0/7] staging: vc04_services: Remove typedefs Jamal Shareef
2019-11-01  5:28 ` [PATCH v2 1/7] staging: vc04_services: Remove enum typedefs in vchi Jamal Shareef
2019-11-01  9:54   ` Greg KH [this message]
2019-11-01  5:28 ` [PATCH v2 2/7] staging: vc04_services: Remove struct " Jamal Shareef
2019-11-01  5:28 ` [PATCH v2 3/7] staging: vc04_services: Remove function pointer typedef Jamal Shareef
2019-11-01  5:28 ` [PATCH v2 4/7] staging: vc04_services: Remove vchiq_arm enum typedefs Jamal Shareef
2019-11-01  5:28 ` [PATCH v2 5/7] staging: vc04_services: Remove callback typedef Jamal Shareef
2019-11-01  5:28 ` [PATCH v2 6/7] staging: vc04_services: Remove int typedef Jamal Shareef
2019-11-01  5:28 ` [PATCH v2 7/7] staging: vc04_services: Remove struct typedefs vchiq_arm Jamal Shareef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101095428.GA2786419@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=eric@anholt.net \
    --cc=jamal.k.shareef@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.