From: "Javier F. Arias" <jarias.linux@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters
Date: Fri, 1 Nov 2019 18:47:18 -0500 [thread overview]
Message-ID: <20191101234718.veroftfioe7qjx2x@gmail.com> (raw)
In-Reply-To: <20191030092456.GA637833@kroah.com>
Hello Greg,
I've updated the patch and decided to drop the coverletter. Now all
the changes are clearly defined. I also added your suggestion about
the argument wrapping that I didn't see the first time.
Thanks.
On Wed, Oct 30, 2019 at 10:24:56AM +0100, Greg KH wrote:
> On Tue, Oct 29, 2019 at 07:48:49PM -0500, Javier F. Arias wrote:
> > Fix line over 80 characters by wrapping arguments in function call.
> >
> > Suggested-by: Julia Lawall <julia.lawall@lip6.fr>.
> > Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> > ---
> > Changes in V3:
> > - Edit the commit message to properly use the Suggested-by
> > tag.
> > Changes in V2:
> > - Edit the commit message to use the Suggested-by tag.
>
> This is a v5 patch, but you only show what happened in v2 and v3, what
> about the other 2?
>
> Also, you don't seem to have changed this patch from my last review, why
> not? I will not take this as-is, sorry. Please fix up and send a new
> version based on that review.
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030092456.GA637833%40kroah.com.
next prev parent reply other threads:[~2019-11-01 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 0:48 [RESEND PATCH v5 0/2] Adjustments in function call Javier F. Arias
2019-10-30 0:48 ` [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
2019-10-30 9:24 ` Greg KH
2019-10-31 23:16 ` [Outreachy kernel] " Javier F. Arias
2019-11-01 23:47 ` Javier F. Arias [this message]
2019-10-30 0:49 ` [RESEND PATCH v5 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101234718.veroftfioe7qjx2x@gmail.com \
--to=jarias.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.