All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: eric@anholt.net, wahrenst@gmx.net, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] staging: vc04_services: replace g_free_fragments_mutex with spinlock
Date: Sat, 2 Nov 2019 11:35:15 +0100	[thread overview]
Message-ID: <20191102103515.GA135926@kroah.com> (raw)
In-Reply-To: <20191101182949.21225-1-dave@stgolabs.net>

On Fri, Nov 01, 2019 at 11:29:49AM -0700, Davidlohr Bueso wrote:
> There is no need to be using a semaphore, or a sleeping lock
> in the first place: critical region is extremely short, does not
> call into any blocking calls and furthermore lock and unlocking
> operations occur in the same context.
> 
> Get rid of another semaphore user by replacing it with a spinlock.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> This is in an effort to further reduce semaphore users in the kernel.
> 
> This is a resend, which just seems simpler given the confusions.
> 
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

This patch does not apply to my tree at all, what did you make it
against?

Please fix up and resend.

thanks,

greg k-h

  parent reply	other threads:[~2019-11-02 10:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-27 22:15 [PATCH] staging: vc04_services: replace g_free_fragments_mutex with spinlock Davidlohr Bueso
     [not found] ` <576df522-f012-9dd1-9dcc-b7e444e82ac6@gmx.net>
2019-10-28 15:21   ` Davidlohr Bueso
2019-10-28 15:37     ` Greg KH
2019-10-28 15:53 ` Davidlohr Bueso
2019-10-28 16:24   ` Greg KH
2019-10-28 16:35     ` Davidlohr Bueso
2019-10-28 16:59       ` Greg KH
2019-11-01 18:29         ` [PATCH resend] " Davidlohr Bueso
2019-11-02 10:33           ` Stefan Wahren
2019-11-02 10:35           ` Greg KH [this message]
2019-10-28 19:08       ` [PATCH] " Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102103515.GA135926@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dave@stgolabs.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.