Re: [PATCH v4 3/8] staging: vc04_services: Remove struct typedefs in vchi

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Nov 01, 2019 at 05:04:15PM -0700, Jamal Shareef wrote:
>  // Opaque handle for a VCHI instance
> -typedef struct opaque_vchi_instance_handle_t *VCHI_INSTANCE_T;
> +struct vchi_instance_handle;
>  
>  // Opaque handle for a server or client
> -typedef struct opaque_vchi_service_handle_t *VCHI_SERVICE_HANDLE_T;
> +struct vchi_service_handle;

So you are changing 2 different typedefs in this patch?  I asked you to
break this up into "one change per patch please".

Also:

>  //Callback used by all services / bulk transfers
> -typedef void (*VCHI_CALLBACK_T)(void *callback_param, //my service local param
> -				enum vchi_callback_reason reason,
> -				void *handle); //for transmitting msg's only
> + typedef void (*VCHI_CALLBACK_T)(void *callback_param, //my service local param
> +				 enum vchi_callback_reason reason,
> +				 void *handle); //for transmitting msg's only

Why did you indent this by 1 space?

I took the first 2 patches here, please fix up and resend this as a
totally new series.

thanks,

greg k-h