All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
	"MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"Peter Geis" <pgwipeout@gmail.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v8 06/18] PM / devfreq: tegra30: Use kHz units uniformly in the code
Date: Sun,  3 Nov 2019 23:41:18 +0300	[thread overview]
Message-ID: <20191103204130.2172-7-digetx@gmail.com> (raw)
In-Reply-To: <20191103204130.2172-1-digetx@gmail.com>

Part of the code uses Hz units and the other kHz, let's switch to kHz
everywhere for consistency. A small benefit from this change (besides
code's cleanup) is that now powertop utility correctly displays devfreq's
stats, for some reason it expects them to be in kHz.

Tested-by: Peter Geis <pgwipeout@gmail.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/devfreq/tegra30-devfreq.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 7d7b7eecc19c..9ccde64be0a0 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -448,7 +448,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
 	rate = dev_pm_opp_get_freq(opp);
 	dev_pm_opp_put(opp);
 
-	err = clk_set_min_rate(tegra->emc_clock, rate);
+	err = clk_set_min_rate(tegra->emc_clock, rate * KHZ);
 	if (err)
 		return err;
 
@@ -477,7 +477,7 @@ static int tegra_devfreq_get_dev_status(struct device *dev,
 	stat->private_data = tegra;
 
 	/* The below are to be used by the other governors */
-	stat->current_frequency = cur_freq * KHZ;
+	stat->current_frequency = cur_freq;
 
 	actmon_dev = &tegra->devices[MCALL];
 
@@ -527,7 +527,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 		target_freq = max(target_freq, dev->target_freq);
 	}
 
-	*freq = target_freq * KHZ;
+	*freq = target_freq;
 
 	return 0;
 }
@@ -663,7 +663,7 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 			goto remove_opps;
 		}
 
-		err = dev_pm_opp_add(&pdev->dev, rate, 0);
+		err = dev_pm_opp_add(&pdev->dev, rate / KHZ, 0);
 		if (err) {
 			dev_err(&pdev->dev, "Failed to add OPP: %d\n", err);
 			goto remove_opps;
@@ -686,7 +686,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 		goto unreg_notifier;
 	}
 
-	tegra_devfreq_profile.initial_freq = clk_get_rate(tegra->emc_clock);
+	tegra_devfreq_profile.initial_freq = tegra->cur_freq;
+
 	devfreq = devfreq_add_device(&pdev->dev, &tegra_devfreq_profile,
 				     "tegra_actmon", NULL);
 	if (IS_ERR(devfreq)) {
-- 
2.23.0


  parent reply	other threads:[~2019-11-03 20:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 20:41 [PATCH v8 00/18] More improvements for Tegra30 devfreq driver Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 01/18] PM / devfreq: tegra30: Change irq type to unsigned int Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 02/18] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 03/18] PM / devfreq: tegra30: Handle possible round-rate error Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 04/18] PM / devfreq: tegra30: Drop write-barrier Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 05/18] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out Dmitry Osipenko
2019-11-03 20:41 ` Dmitry Osipenko [this message]
2019-11-03 20:41 ` [PATCH v8 07/18] PM / devfreq: tegra30: Use CPUFreq notifier Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 08/18] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 09/18] PM / devfreq: tegra30: Reset boosting on startup Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 10/18] PM / devfreq: tegra30: Don't enable consecutive-down interrupt " Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 11/18] PM / devfreq: tegra30: Constify structs Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 12/18] PM / devfreq: tegra30: Include appropriate header Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 13/18] PM / devfreq: tegra30: Don't enable already enabled consecutive interrupts Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 14/18] PM / devfreq: tegra30: Disable consecutive interrupts when appropriate Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 15/18] PM / devfreq: Add new interrupt_driven flag for governors Dmitry Osipenko
2019-11-04  2:48   ` Chanwoo Choi
2019-11-04 14:15     ` Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 16/18] PM / devfreq: tegra30: Support variable polling interval Dmitry Osipenko
2019-11-04  2:53   ` Chanwoo Choi
2019-11-04 14:36     ` Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 17/18] PM / devfreq: tegra30: Tune up MCCPU boost-down coefficient Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 18/18] PM / devfreq: tegra20/30: Add Dmitry as a maintainer Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191103204130.2172-7-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=myungjoo.ham@samsung.com \
    --cc=pgwipeout@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.