All of lore.kernel.org
 help / color / mirror / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: pn532_dev_up(): Error handling issues
Date: Mon, 4 Nov 2019 09:41:42 -0800	[thread overview]
Message-ID: <201911040941.4AECB815@keescook> (raw)

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

c656aa4c27b1 ("nfc: pn533: add UART phy driver")

Coverity reported the following:

*** CID 1487395:  Error handling issues  (CHECKED_RETURN)
/drivers/nfc/pn533/uart.c: 107 in pn532_dev_up()
101     }
102
103     static void pn532_dev_up(struct pn533 *dev)
104     {
105     	struct pn532_uart_phy *pn532 = dev->phy;
106
vvv     CID 1487395:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "serdev_device_open" without checking return value (as is done elsewhere 10 out of 11 times).
107     	serdev_device_open(pn532->serdev);
108     	pn532->send_wakeup = PN532_SEND_LAST_WAKEUP;
109     }
110
111     static void pn532_dev_down(struct pn533 *dev)
112     {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487395 ("Error handling issues")
Fixes: c656aa4c27b1 ("nfc: pn533: add UART phy driver")


Thanks for your attention!

-- 
Coverity-bot

                 reply	other threads:[~2019-11-04 17:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201911040941.4AECB815@keescook \
    --to=keescook@chromium.org \
    --cc=davem@davemloft.net \
    --cc=gustavo@embeddedor.com \
    --cc=linux-next@vger.kernel.org \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.