diff for duplicates of <20191104110352.GD10409@kadam> diff --git a/a/1.txt b/N1/1.txt index da4f1ff..acb5b5f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,9 +40,9 @@ See the start of the function: 872 struct ieee80211_mgmt *mgmt; 873 struct hif_mib_template_frame *p; 874 - 875 if (wvif->vif->type = NL80211_IFTYPE_STATION || - 876 wvif->vif->type = NL80211_IFTYPE_MONITOR || - 877 wvif->vif->type = NL80211_IFTYPE_UNSPECIFIED) + 875 if (wvif->vif->type == NL80211_IFTYPE_STATION || + 876 wvif->vif->type == NL80211_IFTYPE_MONITOR || + 877 wvif->vif->type == NL80211_IFTYPE_UNSPECIFIED) 878 goto done; ^^^^^^^^^ This why I argue that goto done is monkey poop. You see this and you diff --git a/a/content_digest b/N1/content_digest index 919901c..4a55798 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,12 +2,12 @@ "ref\04126113.6ZGdBP45BV@pc-42\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH v2] staging: wfx: Fix a memory leak in 'wfx_upload_beacon'\0" - "Date\0Mon, 04 Nov 2019 11:03:52 +0000\0" + "Date\0Mon, 4 Nov 2019 14:03:52 +0300\0" "To\0Jerome Pouiller <Jerome.Pouiller@silabs.com>\0" - "Cc\0devel@driverdev.osuosl.org <devel@driverdev.osuosl.org>" + "Cc\0Christophe JAILLET <christophe.jaillet@wanadoo.fr>" + devel@driverdev.osuosl.org <devel@driverdev.osuosl.org> gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org> - Christophe JAILLET <christophe.jaillet@wanadoo.fr> " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" @@ -53,9 +53,9 @@ " 872 struct ieee80211_mgmt *mgmt;\n" " 873 struct hif_mib_template_frame *p;\n" " 874 \n" - " 875 if (wvif->vif->type = NL80211_IFTYPE_STATION ||\n" - " 876 wvif->vif->type = NL80211_IFTYPE_MONITOR ||\n" - " 877 wvif->vif->type = NL80211_IFTYPE_UNSPECIFIED)\n" + " 875 if (wvif->vif->type == NL80211_IFTYPE_STATION ||\n" + " 876 wvif->vif->type == NL80211_IFTYPE_MONITOR ||\n" + " 877 wvif->vif->type == NL80211_IFTYPE_UNSPECIFIED)\n" " 878 goto done;\n" " ^^^^^^^^^\n" "This why I argue that goto done is monkey poop. You see this and you\n" @@ -83,4 +83,4 @@ "regards,\n" dan carpenter -7755df929850bb4aef87780bc4b1d1385e7b47eb1532ad0d34e8fd7e1268665c +1c8dbad2e2ec1d2224610aa7832589419ef093de384a60ab51c38acc2fa5afe5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.